This is a tracking bug for supporting KeyframeEffect::target() and KeyframeEffectReadOnly::target(). It is likely that for now we will only be able to support the Element part of these methods, as Chromium does not yet support CSSPseudoElement.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0 commit 83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0 Author: Stephen McGruer <smcgruer@chromium.org> Date: Wed Feb 21 22:55:23 2018 Partially implement KeyframeEffectReadOnly::target() Unfortunately Chromium does not yet support CSSPseudoElement, so we can't fully match the proper idl, but this is a small step in the right direction and an easy win. Note that this only implements the readonly version of target(); the writable version in KeyframeEffect is much more complicated as changing the target changes everything about the animation. TBR=caseq@chromium.org Bug: 813902 Change-Id: I05ab30e11388cff5cf07c983c5f9563a204fcd8c Reviewed-on: https://chromium-review.googlesource.com/927402 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538239} [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/LayoutTests/external/wpt/css/css-timing/cubic-bezier-timing-functions-output-expected.txt [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/keyframe-effects/effect-value-context-expected.txt [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animatable/animate-expected.txt [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/idlharness-expected.txt [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/target-expected.txt [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/animation/ElementAnimation.cpp [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/83b0a6ecb64bfd7d0def8a1e7dc4e58e90cad4f0/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.cpp
No current plan to implement setTarget, moving to Available.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b822dab24251df3891739e3cedb37dab519ebff7 commit b822dab24251df3891739e3cedb37dab519ebff7 Author: Stephen McGruer <smcgruer@chromium.org> Date: Wed Aug 01 16:57:57 2018 Implement KeyframeEffect::setTarget This CL implements the writable part of KeyframeEffect's target member. This brings us into line with the spec, except that Chromium still don't support CSSPseudoElement and so we only allow setting Elements. Bug: 813902 Test: external/wpt/web-animations/interfaces/KeyframeEffect/target.html Test: external/wpt/web-animations/interfaces/KeyframeEffect/idlharness.window.js Change-Id: I91faf22473e7776a8cad6165ff60c5d9ee47a9a6 Reviewed-on: https://chromium-review.googlesource.com/1157002 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579840} [delete] https://crrev.com/73294c6ca75e15ca6f23d8e640b4576ba73f6411/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/keyframe-effects/effect-value-context-expected.txt [modify] https://crrev.com/b822dab24251df3891739e3cedb37dab519ebff7/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/idlharness.window-expected.txt [delete] https://crrev.com/73294c6ca75e15ca6f23d8e640b4576ba73f6411/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/target-expected.txt [modify] https://crrev.com/b822dab24251df3891739e3cedb37dab519ebff7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/b822dab24251df3891739e3cedb37dab519ebff7/third_party/blink/renderer/core/animation/keyframe_effect.cc [modify] https://crrev.com/b822dab24251df3891739e3cedb37dab519ebff7/third_party/blink/renderer/core/animation/keyframe_effect.h [modify] https://crrev.com/b822dab24251df3891739e3cedb37dab519ebff7/third_party/blink/renderer/core/animation/keyframe_effect.idl
Comment 1 by smcgruer@chromium.org
, Feb 20 2018