New issue
Advanced search Search tips

Issue 813897 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Reject instruments.set() with TypeError when instrument icons are bad.

Project Member Reported by rouslan@chromium.org, Feb 20 2018

Issue description

Reject instruments.set() with TypeError when instrument icons are bad. Currently NotFoundError is used instead. Spec:

https://w3c.github.io/payment-handler/#set-method
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fb509a86bd8efc0b8be5619278c5b5be8b85f32

commit 6fb509a86bd8efc0b8be5619278c5b5be8b85f32
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Thu Feb 22 21:41:21 2018

[Payment Handler] Reject with TypeError for bad instrument icons.

Before this patch, failures to download and parse instrument icons would
result in a NotFoundError. This is contrary to the specification, which
states that a TypeError should be thrown:
https://w3c.github.io/payment-handler/#set-method

This patch changes from NotFoundError to TypeError when instrument icons
failed to download or parse.

After this patch, failures to download and parse instrument icons result
in a TypeError.

Bug:  813897 
Change-Id: I124bf7789df37ffcccf43ffa45d5218818530514
Reviewed-on: https://chromium-review.googlesource.com/927461
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538573}
[modify] https://crrev.com/6fb509a86bd8efc0b8be5619278c5b5be8b85f32/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment