New issue
Advanced search Search tips

Issue 813870 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
STS
Team-Accessibility

Blocked on:
issue 815378



Sign in to add a comment

Select-to-Speak does poorly with bullets

Project Member Reported by katie@chromium.org, Feb 20 2018

Issue description

Bullets seem to be ignored or not read by TTS, which throws off character indexes, and select-to-speak ends up highlighting the wrong node
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by katie@chromium.org, Feb 27 2018

Comment #1 and Comment #2 were entered on the wrong bug.

This can be fixed by an update to TTS. See b/73660996 internally.

Comment 4 by katie@chromium.org, Mar 5 2018

Labels: M-67

Comment 5 by katie@chromium.org, Mar 6 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/a9d303a3cc498799f16050f97b7a27b5cb8d2fea

commit a9d303a3cc498799f16050f97b7a27b5cb8d2fea
Author: Katie D <katie@chromium.org>
Date: Wed Mar 07 04:18:59 2018

Updates the Chrome OS TTS engine.

This fixes a bug where unknown unicode start characters caused
the 'start' events not to be fired.

See b/73660996 for updates to the .nexe.zip files and more
background.

TEST=Tried TTS Debug extension and some manual tests with Select-
to-Speak on Chrome OS on linux, x86 architecture (snappy), and
arm architecture (peach pit). Other than a large delay before
starting speech (2-3 seconds), everything seemed fine. I believe
the delay was in the last version as well, nothing new.

BUG=chromium:813870

Change-Id: I22f0b714ba17f7c2aa70cea5b7190d2f1d8e193d
Reviewed-on: https://chromium-review.googlesource.com/950314
Commit-Ready: Katie Dektar <katie@chromium.org>
Tested-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>

[modify] https://crrev.com/a9d303a3cc498799f16050f97b7a27b5cb8d2fea/speech_synthesis/patts/tts_service_x86_64.nexe.zip
[modify] https://crrev.com/a9d303a3cc498799f16050f97b7a27b5cb8d2fea/speech_synthesis/patts/tts_controller.js
[modify] https://crrev.com/a9d303a3cc498799f16050f97b7a27b5cb8d2fea/speech_synthesis/patts/tts_service_x86_32.nexe.zip
[modify] https://crrev.com/a9d303a3cc498799f16050f97b7a27b5cb8d2fea/speech_synthesis/patts/manifest.json
[modify] https://crrev.com/a9d303a3cc498799f16050f97b7a27b5cb8d2fea/speech_synthesis/patts/tts_service_arm.nexe.zip

Comment 7 by katie@chromium.org, Mar 7 2018

Next step is that bullets are nodes in the tree which need to be skipped if speech continues after them. As a test, use a simple unordered list.

Comment 8 by katie@chromium.org, Mar 19 2018

Components: UI>Accessibility>SelectToSpeak

Comment 9 by katie@chromium.org, Mar 19 2018

Components: -UI>Accessibility

Comment 10 by katie@chromium.org, Apr 13 2018

 Issue 832533  has been merged into this issue.

Comment 11 by katie@chromium.org, Apr 13 2018

To get this to work, we'd really want a word end character index from the TTS engine in addition to the start character.

Alternate: move the startChar to the first spoken character:
(hi) had a startChar of 1 instead of 0
((((hi)))) had a startChar of 4 instead of 0
Blockedon: 815378
Owner: ----
Status: Available (was: Started)
Moving back to "available", we need additional TTS work to fix this completely.
Labels: STS_TTS
This bug requires a change to TTS to be completely fixed.

Sign in to add a comment