New issue
Advanced search Search tips

Issue 813856 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

chromeos-bsp-dev-root-moblab is unused - clean up

Project Member Reported by haddowk@chromium.org, Feb 20 2018

Issue description


in overlays/project-moblab  chromeos-bsp-dev-root-moblab is not used, and some of the code used will no longer work on newer moblab hardware.

Remove the unused code.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a1b31c2ad4d021c3af64f9c168eb5cf3c9a8c7f9

commit a1b31c2ad4d021c3af64f9c168eb5cf3c9a8c7f9
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Feb 22 03:52:13 2018

[moblab] Clean up unused dev-root code.

Some of this code no longer works on next gen moblabs - remove it.

BUG= chromium:813856 
TEST=built fizz and guado moblab.

Change-Id: Ibaf7955beb4285008a8c6583e4f1123c2a9166a6
Reviewed-on: https://chromium-review.googlesource.com/926967
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/a1b31c2ad4d021c3af64f9c168eb5cf3c9a8c7f9/project-moblab/chromeos-base/chromeos-bsp-moblab/files/checkfiles/moblab/upstart_services_running_check.py
[delete] https://crrev.com/b171d3d6162f7d92d03fda4c31e0840d3514e989/project-moblab/virtual/chromeos-bsp-dev-root/chromeos-bsp-dev-root-1.5.ebuild
[rename] https://crrev.com/a1b31c2ad4d021c3af64f9c168eb5cf3c9a8c7f9/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-base-container-init.conf
[rename] https://crrev.com/a1b31c2ad4d021c3af64f9c168eb5cf3c9a8c7f9/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-network-bridge-init.conf
[modify] https://crrev.com/a1b31c2ad4d021c3af64f9c168eb5cf3c9a8c7f9/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-9999.ebuild
[delete] https://crrev.com/b171d3d6162f7d92d03fda4c31e0840d3514e989/project-moblab/chromeos-base/chromeos-bsp-dev-root-moblab/chromeos-bsp-dev-root-moblab-0.0.1-r1.ebuild
[delete] https://crrev.com/b171d3d6162f7d92d03fda4c31e0840d3514e989/project-moblab/chromeos-base/chromeos-bsp-dev-root-moblab/chromeos-bsp-dev-root-moblab-0.0.1.ebuild
[delete] https://crrev.com/b171d3d6162f7d92d03fda4c31e0840d3514e989/project-moblab/chromeos-base/chromeos-bsp-moblab/files/moblab-network-init.conf
[delete] https://crrev.com/b171d3d6162f7d92d03fda4c31e0840d3514e989/project-moblab/virtual/chromeos-bsp-dev-root/chromeos-bsp-dev-root-1.5-r1.ebuild

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/moblab/+/a01c819b99b1c1a91a8a05eb17403ee12bb487d8

commit a01c819b99b1c1a91a8a05eb17403ee12bb487d8
Author: Matt Mallett <mattmallett@chromium.org>
Date: Sat Mar 10 04:05:16 2018

[moblab] Remove moblab-network-init check

BUG= chromium:813856 
TEST=local moblab device

Change-Id: I3b7506f8b63f6ca60502b79c41e46c01587d8fd9
Reviewed-on: https://chromium-review.googlesource.com/946567
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/a01c819b99b1c1a91a8a05eb17403ee12bb487d8/src/mobmonitor/checkfiles/moblab/upstart_services_running_check.py

Sign in to add a comment