New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813835 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 417782



Sign in to add a comment

Part of page lost with 66.0.3350.0

Project Member Reported by mar...@mwiacek.com, Feb 20 2018

Issue description

Device name:s7

From "Settings > About Chrome"
Application version:66.0.3350.0 canary
Operating system:7

URLs (if applicable):https://developers.google.com/android/images

Steps to reproduce:
(1)open url
(2)scroll down

Expected result:
all content is displayed

Actual result:
"shamu" list is cut off

it can be https://bugs.chromium.org/p/chromium/issues/detail?id=811486 related (then pls merge), but also something new.

 
Screenshot_20180220-182722.png
169 KB View Download

Comment 1 by szager@chromium.org, Feb 20 2018

Blocking: 417782
Cc: chrishtr@chromium.org vmp...@chromium.org
Status: Available (was: Unconfirmed)
I was able to reproduce this on a Pixel 2 using the same release of chrome (current canary).  I had to scroll pretty far down the page.
Labels: -Arch-x86_64 hasbisect-per-revision M-66 ReleaseBlock-Beta FoundIn-66 Target-66
Owner: skobes@chromium.org
Status: Assigned (was: Available)
We are able to repro the issue on Chrome:66.0.3350.0 Device:Nexus 6P/N2G48H

Bisect info:
Good build:66.0.3344.0
Bad build:66.0.3345.0
Regression range:
https://chromium.googlesource.com/chromium/src/+log/66.0.3344.0..66.0.3345.0?pretty=fuller&n=10000

Good commit:535635
Bad commit:535636
Culprit CL: 
https://chromium.googlesource.com/chromium/src/+/96f85b68747a679ea1ac4cd05d6743ae5f7142b7

Comment 3 by junov@chromium.org, Feb 21 2018

Components: -UI -Blink Blink>Paint

Comment 4 by vmp...@chromium.org, Feb 22 2018

Cc: skobes@chromium.org
Owner: vmp...@chromium.org

Comment 5 by vmp...@chromium.org, Feb 22 2018

Status: Started (was: Assigned)
Confirmed that this is RLS. Reduced case attached that reproduces in pixel2 dev tools emulation.

Looking into it. 
t.html
2.5 KB View Download

Comment 6 by vmp...@chromium.org, Feb 22 2018

Simpler repro that also repros on Linux:

<!doctype HTML>

<div style="height:2000px; width:100px; background-color:lightblue;"></div>
<div style="will-change:transform; height:6000px; width:100px; background:linear-gradient(blue, yellow);"></div>


The problem is that we intersect the paint rect with the visible content rect from the local frame. However, in RLS that rect is not scrolled as the paint code expects.

Comment 7 by vmp...@chromium.org, Feb 24 2018

Cc: nyerramilli@chromium.org manoranj...@chromium.org rbasuvula@chromium.org
 Issue 813532  has been merged into this issue.
Hi guys, I see some broken scrollbars on twitter too with 66.0.3350.0 (for example on this: https://twitter.com/TrueCar/status/967228511286112256) the scrollbar is stuck to the top, I'm not able to scroll using the mouse wheel. If I click the scrollbar and scroll, I end up with some "missing part" like in this bug.

Not sure this is the same issue, feel free to ask me to create a new one if you think it's required.

OS: Linux, working: 66.0.3346.8, broken: 66.0.3350.0

Regards,
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/276d2aa768f8ef1082a4a543dfbe509d9a819f71

commit 276d2aa768f8ef1082a4a543dfbe509d9a819f71
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Mon Feb 26 19:49:23 2018

[RLS] Adjust the interest rect by scroll offset for non-root anchors.

This patch updates the position on screen of non-root anchored layers
for interest rect calculation. This is needed, because the paint clip
always uses (0, 0) positioned viewport, so for content that is larger
than 4k pixels in height that is scrolled, we clip out the tail of
the content because we're not accounting for the scroll.

R=wangxianzhu@chromium.org, szager@chromium.org

Bug:  813835 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3dabcd4fdb907c949593bed7a076e88cdabed53a
Reviewed-on: https://chromium-review.googlesource.com/933731
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539241}
[add] https://crrev.com/276d2aa768f8ef1082a4a543dfbe509d9a819f71/third_party/WebKit/LayoutTests/compositing/composited-tall-layer-fully-renders-expected.html
[add] https://crrev.com/276d2aa768f8ef1082a4a543dfbe509d9a819f71/third_party/WebKit/LayoutTests/compositing/composited-tall-layer-fully-renders.html
[modify] https://crrev.com/276d2aa768f8ef1082a4a543dfbe509d9a819f71/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/276d2aa768f8ef1082a4a543dfbe509d9a819f71/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMappingTest.cpp

Comment 10 by pdr@chromium.org, Feb 26 2018

Re comment 8: I'm not able to reproduce that issue on 66.0.3350.0 on linux. Can you file a separate bug with as much info as possible?
pdr@, I just reopened the link in comment 8 and yes scroll works, but it's broken if the "open" starts from twitter (ie. click on some tweet in your timeline). I did open  bug #816660 .

Thanks for you answer.

Comment 12 by bokan@chromium.org, Feb 27 2018

Status: Fixed (was: Started)
Cc: bokan@chromium.org szager@chromium.org
 Issue 820008  has been merged into this issue.

Sign in to add a comment