Write equivalent python scripts for bash scripts found in vboot_reference/scripts/image_signing. Targeting scripts that are required for sign_official_build.sh New code will be inside chromite/signing/image_signing directory. Relevant docs: https://docs.google.com/document/d/16pWOcoVAGLyTEWcwnPMU_kLKc_X-ln2dAC_NBD0tHOs/edit#heading=h.y0zywjr6itqk https://docs.google.com/document/d/13aPioEkA3sd-VxNlpF5rlRNrQTGf4Ve2u6-QC2uC3Dg/edit
triaging out of general 'Infra' component
(also adding ChromeOS as another potential component)
i don't think any of this needs to be done in private. we want to keep it all public (e.g. in chromite/) anyways.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/21c61c0123473d81cf2851a139eaf78449ce0493 commit 21c61c0123473d81cf2851a139eaf78449ce0493 Author: Chris Ching <chingcodes@google.com> Date: Sat Aug 11 05:43:52 2018 signing: Add Signer for image signing Base classes showing new structure for configuring signing logic going forward. BUG=chromium:813829 TEST=./signer_unittest Change-Id: Ib49e06866b9913cf72ee8051ae2e86bd099b62e1 Reviewed-on: https://chromium-review.googlesource.com/1155814 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [add] https://crrev.com/21c61c0123473d81cf2851a139eaf78449ce0493/signing/lib/signer.py [add] https://crrev.com/21c61c0123473d81cf2851a139eaf78449ce0493/signing/lib/signer_unittest.py [add] https://crrev.com/21c61c0123473d81cf2851a139eaf78449ce0493/signing/lib/signer_unittest
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4b7637730de04ecc8b1d7e8647822cebc66a0049 commit 4b7637730de04ecc8b1d7e8647822cebc66a0049 Author: Chris Ching <chingcodes@google.com> Date: Sat Aug 11 05:43:52 2018 signing: Add key management Initial implementation focused on managing signing keys and keyblocks BUG=chromium:813829 TEST=./keys_unittest Change-Id: I879475811171de74a75434ebca8cbaf0ecc7d5c9 Reviewed-on: https://chromium-review.googlesource.com/1159204 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [add] https://crrev.com/4b7637730de04ecc8b1d7e8647822cebc66a0049/signing/lib/keys.py [add] https://crrev.com/4b7637730de04ecc8b1d7e8647822cebc66a0049/signing/lib/keys_unittest.py [add] https://crrev.com/4b7637730de04ecc8b1d7e8647822cebc66a0049/signing/lib/__init__.py [add] https://crrev.com/4b7637730de04ecc8b1d7e8647822cebc66a0049/signing/lib/keys_unittest [add] https://crrev.com/4b7637730de04ecc8b1d7e8647822cebc66a0049/signing/__init__.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8e5bc151159ca440d48d3c275f9d82b9fb3abaf5 commit 8e5bc151159ca440d48d3c275f9d82b9fb3abaf5 Author: Chris Ching <chingcodes@google.com> Date: Thu Aug 30 21:41:48 2018 signing: Add FutilitySigner Class is for creating Signers that call the futility utility BUG=chromium:813829 TEST=./firmware_unittest Change-Id: Id383ea39615669a4f29f6bd98c248f0f13f66463 Reviewed-on: https://chromium-review.googlesource.com/1155815 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/8e5bc151159ca440d48d3c275f9d82b9fb3abaf5/signing/lib/signer.py [modify] https://crrev.com/8e5bc151159ca440d48d3c275f9d82b9fb3abaf5/signing/lib/signer_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/691092089522ff128d7d8183bbe1d3a4b2b408b8 commit 691092089522ff128d7d8183bbe1d3a4b2b408b8 Author: Chris Ching <chingcodes@google.com> Date: Thu Aug 30 21:41:49 2018 signing: Add ECSigner Class responsible for signing EC bin files BUG=chromium:813829 TEST=./firmware_unittest Change-Id: I03097eb57b00ec5e5bf943b4355d5fb8c1c2cd3e Reviewed-on: https://chromium-review.googlesource.com/1155816 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [add] https://crrev.com/691092089522ff128d7d8183bbe1d3a4b2b408b8/signing/lib/firmware.py [add] https://crrev.com/691092089522ff128d7d8183bbe1d3a4b2b408b8/signing/lib/firmware_unittest [add] https://crrev.com/691092089522ff128d7d8183bbe1d3a4b2b408b8/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5053a10675a76fe5cdb80530bd5cdccc55739f8a commit 5053a10675a76fe5cdb80530bd5cdccc55739f8a Author: Chris Ching <chingcodes@google.com> Date: Thu Aug 30 21:41:49 2018 signing: Add BiosSigner Class responsible for signing BIOS with futility BUG=chromium:813829 TEST=./firmware_unittest Change-Id: I75f74874f493bdf3cc3f6c9a7cbf1718b6f127ab Reviewed-on: https://chromium-review.googlesource.com/1155817 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/5053a10675a76fe5cdb80530bd5cdccc55739f8a/signing/lib/firmware.py [modify] https://crrev.com/5053a10675a76fe5cdb80530bd5cdccc55739f8a/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/583d57785e856f5594e61ad451ef0990968099d6 commit 583d57785e856f5594e61ad451ef0990968099d6 Author: Chris Ching <chingcodes@google.com> Date: Fri Aug 31 22:08:47 2018 signing: add Shellball extract and repack operations Add needed operations for resign_firmware_payload operation. Note: this only works for shellballs that were packed by pack_firmware after 2014. BUG=chromium:813829 TEST=signing/firmware_unittest Change-Id: I41417209807491a8a102d4ef3450b2130dbfb5f8 Reviewed-on: https://chromium-review.googlesource.com/931784 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/583d57785e856f5594e61ad451ef0990968099d6/signing/lib/firmware.py [modify] https://crrev.com/583d57785e856f5594e61ad451ef0990968099d6/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3af24a77bf076b245e64647247ef66e70c52c860 commit 3af24a77bf076b245e64647247ef66e70c52c860 Author: Chris Ching <chingcodes@google.com> Date: Wed Sep 05 23:11:05 2018 signing: Add Signer Configuration via INI files BUG=chromium:813829 TEST=signing/signer_unittest Change-Id: I92a2bb3cdc964d27bfd457066f2215529b318cb9 Reviewed-on: https://chromium-review.googlesource.com/1191942 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/3af24a77bf076b245e64647247ef66e70c52c860/signing/lib/signer.py [modify] https://crrev.com/3af24a77bf076b245e64647247ef66e70c52c860/signing/lib/signer_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/96a84e6e65d9dd9ba7db829c6892c0585def15f6 commit 96a84e6e65d9dd9ba7db829c6892c0585def15f6 Author: Chris Ching <chingcodes@google.com> Date: Wed Sep 05 23:11:06 2018 signing: Add Subkey to KeyPair and Keyset KeyPair * Moved Keyblock into KeyPair * Added subkeys * Removed Keyset GetKey() since didn't add much value Keyset * Add KeysetMock * AddSubkey for easy adding new subkeys * Add subkey_aliases for mapping loems to board names KeysetFromDir * Added support for subkeys * Added aliases to Keyset based on loem.ini file BUG=chromium:813829 TEST=signing/*_unittest Change-Id: Ie5fefc32bbfea2af93d98e8dd8a8fa2dbaf9b8e2 Reviewed-on: https://chromium-review.googlesource.com/1196831 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/96a84e6e65d9dd9ba7db829c6892c0585def15f6/signing/lib/keys.py [modify] https://crrev.com/96a84e6e65d9dd9ba7db829c6892c0585def15f6/signing/lib/firmware.py [modify] https://crrev.com/96a84e6e65d9dd9ba7db829c6892c0585def15f6/signing/lib/signer_unittest.py [modify] https://crrev.com/96a84e6e65d9dd9ba7db829c6892c0585def15f6/signing/lib/keys_unittest.py [modify] https://crrev.com/96a84e6e65d9dd9ba7db829c6892c0585def15f6/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/867aebe10898c0858ab4d5ec4d66a632bb577ff3 commit 867aebe10898c0858ab4d5ec4d66a632bb577ff3 Author: Chris Ching <chingcodes@google.com> Date: Tue Sep 11 00:17:59 2018 signing: add errors and add/update signers * Add GBBSigner * updated BiosSigner use of keys, version and loemdir * Rewrite ECSigner to do signing in tempdir * Add Key and Signer errors * Add ec key for KeysetFromDir() * Add subdir arg to KeysetFromSigner BUG=chromium:813829 TEST=signing/*_unittest Change-Id: Ifee5e537024e47be14a9687df689ad07be9df612 Reviewed-on: https://chromium-review.googlesource.com/1211122 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/867aebe10898c0858ab4d5ec4d66a632bb577ff3/signing/lib/keys.py [modify] https://crrev.com/867aebe10898c0858ab4d5ec4d66a632bb577ff3/signing/lib/firmware.py [modify] https://crrev.com/867aebe10898c0858ab4d5ec4d66a632bb577ff3/signing/lib/firmware_unittest.py [modify] https://crrev.com/867aebe10898c0858ab4d5ec4d66a632bb577ff3/signing/lib/signer.py [modify] https://crrev.com/867aebe10898c0858ab4d5ec4d66a632bb577ff3/signing/lib/keys_unittest.py [modify] https://crrev.com/867aebe10898c0858ab4d5ec4d66a632bb577ff3/signing/lib/signer_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5cd43f707f5801304dcf450a279bb29f2df15fb3 commit 5cd43f707f5801304dcf450a279bb29f2df15fb3 Author: Chris Ching <chingcodes@google.com> Date: Fri Sep 14 19:08:25 2018 signing: Add KeyPair.GetSha1sum() BUG=chromium:813829 TEST=signing/keys_unittest Change-Id: Id24338e0ba818741944e1d3863b2698405849d84 Reviewed-on: https://chromium-review.googlesource.com/1222156 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/5cd43f707f5801304dcf450a279bb29f2df15fb3/signing/lib/keys.py [modify] https://crrev.com/5cd43f707f5801304dcf450a279bb29f2df15fb3/signing/lib/keys_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/02d79d59f82a1dbf29b39c8423b4b53948c30756 commit 02d79d59f82a1dbf29b39c8423b4b53948c30756 Author: Chris Ching <chingcodes@google.com> Date: Tue Sep 18 21:03:30 2018 signing: Add FirmwareSigner and ResignImageFirmware * Add higher level FirmwareSigner to replace the resign_firmware_payload function in vboot_reference * Changed Signer required_keys to be public * Changed keypair version to be string * Add missing common keys to KeysetMock * Add SignerConfigsFromCSV for reading signer_config.csv files * Signers now raise Signing errors BUG=chromium:813829 TEST=signing/firmware_unittest Change-Id: I1cd0e77c3bac47613d226c10436b61cb2cc14830 Reviewed-on: https://chromium-review.googlesource.com/1211123 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/02d79d59f82a1dbf29b39c8423b4b53948c30756/signing/lib/keys.py [modify] https://crrev.com/02d79d59f82a1dbf29b39c8423b4b53948c30756/signing/lib/firmware.py [modify] https://crrev.com/02d79d59f82a1dbf29b39c8423b4b53948c30756/signing/lib/firmware_unittest.py [modify] https://crrev.com/02d79d59f82a1dbf29b39c8423b4b53948c30756/signing/lib/signer.py [modify] https://crrev.com/02d79d59f82a1dbf29b39c8423b4b53948c30756/signing/lib/keys_unittest.py [modify] https://crrev.com/02d79d59f82a1dbf29b39c8423b4b53948c30756/signing/lib/signer_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f6cd342ffebfbf5901a6981b62060cfc3e8476a7 commit f6cd342ffebfbf5901a6981b62060cfc3e8476a7 Author: Chris Ching <chingcodes@google.com> Date: Tue Sep 18 21:04:21 2018 signing: Add preamble_flag to BiosSigner BUG=chromium:813829 TEST=signing/firmware_unittest Change-Id: Ia06aa027b89f20ad8751ec0c1f501a659fab2a72 Reviewed-on: https://chromium-review.googlesource.com/1226171 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/f6cd342ffebfbf5901a6981b62060cfc3e8476a7/signing/lib/firmware.py [modify] https://crrev.com/f6cd342ffebfbf5901a6981b62060cfc3e8476a7/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/84a1cad0b563e671d849fcebb904a8c42b0579bb commit 84a1cad0b563e671d849fcebb904a8c42b0579bb Author: Chris Ching <chingcodes@google.com> Date: Tue Sep 18 21:03:31 2018 signing: Add FirmwareSigner.WriteSignerNotes BUG=chromium:813829 TEST=signing/firmware_unittest Change-Id: I45f5a76496c1b0452eb4fc400b195b0681e7477d Reviewed-on: https://chromium-review.googlesource.com/1226174 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/84a1cad0b563e671d849fcebb904a8c42b0579bb/signing/lib/firmware.py [modify] https://crrev.com/84a1cad0b563e671d849fcebb904a8c42b0579bb/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/a9ac868c507121bb7450154624e01c7758e2687a commit a9ac868c507121bb7450154624e01c7758e2687a Author: Chris Ching <chingcodes@google.com> Date: Thu Sep 20 18:39:38 2018 signing: Add Mock Signer commands for Firmware signers For use in testing other signer logic. Fixed bug where bio.bin was used for EC RO detection. BUG=chromium:813829 TEST=signing/firmware_unittest && signing/keys_unittest Change-Id: I1d2e17168277c22779f9ab4fa45fb6c386413661 Reviewed-on: https://chromium-review.googlesource.com/1232553 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/a9ac868c507121bb7450154624e01c7758e2687a/signing/lib/firmware.py [modify] https://crrev.com/a9ac868c507121bb7450154624e01c7758e2687a/signing/lib/keys_unittest.py [modify] https://crrev.com/a9ac868c507121bb7450154624e01c7758e2687a/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/cf152698af11c8b52e33f92f2f7ec3abd5263914 commit cf152698af11c8b52e33f92f2f7ec3abd5263914 Author: Chris Ching <chingcodes@google.com> Date: Thu Sep 20 18:39:38 2018 Migrate FirmwarePacker to chromite.signing CQ-DEPEND=CL:1232553 BUG=chromium:813829 TEST=pack_firmware_unittest.py && pack_firmware_functest.py Change-Id: I1bbcc01b93ca0bff498b780ee0af8930221601b0 Reviewed-on: https://chromium-review.googlesource.com/1235133 Commit-Ready: Chris Ching <chingcodes@chromium.org> Tested-by: Chris Ching <chingcodes@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Lann Martin <lannm@chromium.org> [modify] https://crrev.com/cf152698af11c8b52e33f92f2f7ec3abd5263914/pack_firmware_unittest.py [modify] https://crrev.com/cf152698af11c8b52e33f92f2f7ec3abd5263914/pack_firmware.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e39ebf2417b3e801a9803ce7c81db847ef37b797 commit e39ebf2417b3e801a9803ce7c81db847ef37b797 Author: LaMont Jones <lamontjones@chromium.org> Date: Thu Nov 15 10:16:37 2018 signing: Add sanity checks to values in KeyPair KeyPair.version should be an int internally, not a str. BUG=chromium:813829 TEST=All (updated) unittests pass. Change-Id: I518b9478adea3a092b37c0375e02df35f1d7bc02 Reviewed-on: https://chromium-review.googlesource.com/1321352 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: C Shapiro <shapiroc@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e39ebf2417b3e801a9803ce7c81db847ef37b797/signing/lib/keys.py [modify] https://crrev.com/e39ebf2417b3e801a9803ce7c81db847ef37b797/signing/lib/firmware.py [modify] https://crrev.com/e39ebf2417b3e801a9803ce7c81db847ef37b797/signing/lib/keys_unittest.py [modify] https://crrev.com/e39ebf2417b3e801a9803ce7c81db847ef37b797/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e570fab7b358bfab4fffbc45fd16fd43c7d840a1 commit e570fab7b358bfab4fffbc45fd16fd43c7d840a1 Author: LaMont Jones <lamontjones@chromium.org> Date: Fri Nov 16 23:10:56 2018 signing: Fix unittest errors. There is never a bios.bin and bios.loem1.bin in the same buildtarget. Other minor unittest cleanup. BUG=chromium:813829 TEST=All (updated) unittests pass. Change-Id: Ifff7a08ff99b16bba4d914885d5edb261cf2c202 Reviewed-on: https://chromium-review.googlesource.com/1336699 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: C Shapiro <shapiroc@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e570fab7b358bfab4fffbc45fd16fd43c7d840a1/signing/lib/keys_unittest.py [modify] https://crrev.com/e570fab7b358bfab4fffbc45fd16fd43c7d840a1/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/44bef83f2be0f01d410f436c519da2987cca5747 commit 44bef83f2be0f01d410f436c519da2987cca5747 Author: LaMont Jones <lamontjones@chromium.org> Date: Tue Nov 20 13:52:36 2018 signing: KeyPair filename extension cleanup Refine the definition of pub_ext and priv_ext for KeyPair files, and allow the code to automatically recognize the two different suffix formats and properly handle the public keyfile name without special casing. BUG=chromium:813829 TEST=All (updated) unittests pass. Change-Id: Ib5282ca73da6177dab20594ee2743cea8af459e8 Reviewed-on: https://chromium-review.googlesource.com/1336700 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/44bef83f2be0f01d410f436c519da2987cca5747/signing/lib/keys.py [modify] https://crrev.com/44bef83f2be0f01d410f436c519da2987cca5747/signing/lib/keys_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7be4b74b65e7f28666576b45ec740526855040b0 commit 7be4b74b65e7f28666576b45ec740526855040b0 Author: LaMont Jones <lamontjones@chromium.org> Date: Wed Nov 21 02:27:51 2018 signing: Add KeyPair.ParsePrivateKeyFilename This function will be used in Keyset.__init__ to recognize private keys and create KeyPairs from them. BUG=chromium:813829 TEST=All (updated) unittests pass. Change-Id: I6b793af5eed86d0f1433d7b30119a4d178aa2978 Reviewed-on: https://chromium-review.googlesource.com/1339179 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/7be4b74b65e7f28666576b45ec740526855040b0/signing/lib/keys.py [modify] https://crrev.com/7be4b74b65e7f28666576b45ec740526855040b0/signing/lib/keys_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/cf8713004302e8981f525b6d2700b0f244837aa7 commit cf8713004302e8981f525b6d2700b0f244837aa7 Author: LaMont Jones <lamontjones@chromium.org> Date: Thu Nov 22 06:49:05 2018 signing: refactor Keyset and Keypair for buildtarget-specific keys KeyPair should only know about, well, key pairs. KeySet should have knowledge of buildtarget-specific KeyPairs. BUG=chromium:813829 TEST=All (updated) unittests pass. Change-Id: Ia3a6d657ef56f81eed6c2fc1d46f47b33b20d667 Reviewed-on: https://chromium-review.googlesource.com/1336701 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/cf8713004302e8981f525b6d2700b0f244837aa7/signing/lib/keys.py [modify] https://crrev.com/cf8713004302e8981f525b6d2700b0f244837aa7/signing/lib/firmware.py [modify] https://crrev.com/cf8713004302e8981f525b6d2700b0f244837aa7/signing/lib/keys_unittest.py [modify] https://crrev.com/cf8713004302e8981f525b6d2700b0f244837aa7/signing/lib/firmware_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/27dc4749c9ca0e52cbc334e349c3730710ebc28b commit 27dc4749c9ca0e52cbc334e349c3730710ebc28b Author: LaMont Jones <lamontjones@chromium.org> Date: Thu Nov 22 06:49:05 2018 signing: add support for key.versions Parse and support key.versions file BUG=chromium:813829 TEST=All (updated) unittests pass. Change-Id: Iac40cdf0444378c3e8d8dcb414dd6220ad4aef9f Reviewed-on: https://chromium-review.googlesource.com/1337446 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/27dc4749c9ca0e52cbc334e349c3730710ebc28b/signing/lib/keys.py [modify] https://crrev.com/27dc4749c9ca0e52cbc334e349c3730710ebc28b/signing/lib/keys_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5174c94b7b81618fd459d5209bdf0342a6112a85 commit 5174c94b7b81618fd459d5209bdf0342a6112a85 Author: LaMont Jones <lamontjones@chromium.org> Date: Thu Nov 22 06:49:05 2018 Add README.md to chromite/signing. BUG=chromium:813829 TEST=NONE Change-Id: I02de9884fe23f010fb52bf0d617f1e504996bc42 Reviewed-on: https://chromium-review.googlesource.com/1338504 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [add] https://crrev.com/5174c94b7b81618fd459d5209bdf0342a6112a85/signing/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/cde48580e93da01999f0032e32ebf7fbca0e474e commit cde48580e93da01999f0032e32ebf7fbca0e474e Author: LaMont Jones <lamontjones@chromium.org> Date: Wed Nov 28 03:14:03 2018 Add missing unit tests. Last week's CLs missed a function in unittesting. BUG=chromium:813829 TEST=Updated unit tests pass. Change-Id: I1c5663f8aa7a240e7fdc795d2a221b1135bdde65 Reviewed-on: https://chromium-review.googlesource.com/1351630 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/cde48580e93da01999f0032e32ebf7fbca0e474e/signing/lib/keys_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5f4970fb945607cfbefee166b07cd31048b7cfc0 commit 5f4970fb945607cfbefee166b07cd31048b7cfc0 Author: LaMont Jones <lamontjones@chromium.org> Date: Fri Dec 14 00:12:40 2018 image_lib: extend LoopbackPartition to provide Mount/Unmount. Extend LoopbackPartition to be a superset of osutils.MountImageContext, largely by copying code over. Add a note to osutils.MountImageContext recommending LoopbackPartition. Removing osutils.MountImageContext will be done as a separate commit. BUG=chromium:813829 TEST=Updated unit tests pass Change-Id: I6ac0d40a65cbf5dcf8df78af8fd717ef2e57d4c1 Reviewed-on: https://chromium-review.googlesource.com/1366413 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/5f4970fb945607cfbefee166b07cd31048b7cfc0/lib/image_lib.py [modify] https://crrev.com/5f4970fb945607cfbefee166b07cd31048b7cfc0/lib/image_lib_unittest.py [modify] https://crrev.com/5f4970fb945607cfbefee166b07cd31048b7cfc0/lib/osutils.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3017a40dda25cd16c6dd9b1ed053e27615fdfa14 commit 3017a40dda25cd16c6dd9b1ed053e27615fdfa14 Author: LaMont Jones <lamontjones@chromium.org> Date: Sat Dec 15 13:27:12 2018 image_lib: always return directory path from LoopbackPartitions._Mount Also, extend LoopbackPartitionsMock for testing ease. BUG=chromium:813829 TEST=Updated unit tests pass Change-Id: I9a88d3938adb70dd0a32cffa75b2089cdbb445fd Reviewed-on: https://chromium-review.googlesource.com/1374812 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/3017a40dda25cd16c6dd9b1ed053e27615fdfa14/lib/image_lib.py [modify] https://crrev.com/3017a40dda25cd16c6dd9b1ed053e27615fdfa14/lib/image_lib_unittest.py
Lamont is working on this, so update the owner.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ccf97ef6bafc057b4a680e0e2842a820e8e8af1d commit ccf97ef6bafc057b4a680e0e2842a820e8e8af1d Author: LaMont Jones <lamontjones@chromium.org> Date: Fri Dec 21 02:06:23 2018 signing: begin converting sign_official_build.sh Starting with SignImage. BUG=chromium:813829 TEST=Unittests pass Change-Id: I22b89149274da7bbd5913ce96ba2c9230c9dece8 Reviewed-on: https://chromium-review.googlesource.com/1361675 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/ccf97ef6bafc057b4a680e0e2842a820e8e8af1d/signing/image_signing/imagefile.py [add] https://crrev.com/ccf97ef6bafc057b4a680e0e2842a820e8e8af1d/signing/image_signing/imagefile_unittest.py [add] https://crrev.com/ccf97ef6bafc057b4a680e0e2842a820e8e8af1d/signing/image_signing/__init__.py [add] https://crrev.com/ccf97ef6bafc057b4a680e0e2842a820e8e8af1d/signing/image_signing/imagefile_unittest
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f3f9bf19ed2cbff553a017bdc9b1b59a55c41e24 commit f3f9bf19ed2cbff553a017bdc9b1b59a55c41e24 Author: LaMont Jones <lamontjones@chromium.org> Date: Fri Dec 21 02:06:19 2018 image_lib: Add support for enable/disable rw mount, isext2fs BUG=chromium:813829 TEST=Unit tests pass. Change-Id: I7cd3ebbbb03ed9e2d62f2a5f412aa6c617c012f4 Reviewed-on: https://chromium-review.googlesource.com/1380235 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f3f9bf19ed2cbff553a017bdc9b1b59a55c41e24/lib/image_lib.py [modify] https://crrev.com/f3f9bf19ed2cbff553a017bdc9b1b59a55c41e24/lib/image_lib_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6611f37f9fb3743a603d771106e610e81818644b commit 6611f37f9fb3743a603d771106e610e81818644b Author: LaMont Jones <lamontjones@chromium.org> Date: Thu Jan 03 02:14:02 2019 signing: correctly find the vboot_reference signing scripts BUG=chromium:813829 TEST=Unit tests pass. Change-Id: If1a151db816043a0e6b8bc995e260ca8e2a45d14 Reviewed-on: https://chromium-review.googlesource.com/1376672 Commit-Ready: LaMont Jones <lamontjones@chromium.org> Tested-by: LaMont Jones <lamontjones@chromium.org> Reviewed-by: LaMont Jones <lamontjones@chromium.org> [modify] https://crrev.com/6611f37f9fb3743a603d771106e610e81818644b/signing/image_signing/imagefile.py [modify] https://crrev.com/6611f37f9fb3743a603d771106e610e81818644b/signing/image_signing/imagefile_unittest.py
Comment 1 by iannucci@chromium.org
, Feb 20 2018