[MacViews] Menus don't respect system appearance setting |
|||||||||
Issue descriptionTo repro: System Preferences > Appearance > Graphite Open wrench menu in MacViews browser (polychrome build with -enable-features=ViewsBrowserWindows) Observe blue highlight (contrast with Cocoa browser wrench menu, or system menus in MacViews)
,
Mar 23 2018
MacViews triage: assigning to sdy@ targeting M-68 as part of other menu work.
,
Mar 27 2018
,
Mar 27 2018
,
Mar 29 2018
** Bulk Edit ** FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.
,
Mar 30 2018
,
Mar 30 2018
,
Mar 30 2018
,
Apr 16 2018
This is Fixed as of <https://chromium-review.googlesource.com/c/chromium/src/+/998016>, which added logic for Graphite highlights.
,
May 4 2018
Tried checking the issue on latest canary 68.0.3419.0 using Mac 10.13.1 with the below mentioned steps. 1. System Preferences > Appearance 2. Changed Appearance to Graphite (...from Blue) 3. In chrome://flags enabled "ViewsBrowserWindows" 4. Hovered mouse over the wrench menu. We observed grey highlighting in latest canary and also in one of the older versions(68.0.3397.0-Assuming this version as without the fix). Attaching the screen shots of both. @ellyjones: Could you please have a look at the screen shots and let us know if we have missed anything in the process. Please help us in verifying the fix.
,
May 7 2018
#10: yup, this bug got superseded by https://bugs.chromium.org/p/chromium/issues/detail?id=829467#c9 so this bug, while it was fixed in the past, is now obsolete. No need to verify. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tapted@chromium.org
, Feb 21 2018Part of this is going to be void NativeThemeMac::PaintMenuItemBackground( cc::PaintCanvas* canvas, State state, const gfx::Rect& rect, const MenuItemExtraParams& menu_item) const { cc::PaintFlags flags; switch (state) { case NativeTheme::kNormal: case NativeTheme::kDisabled: // Draw nothing over the regular background. break; case NativeTheme::kHovered: // TODO(tapted): Draw a gradient, and use [NSColor currentControlTint] to // pick colors. The System color "selectedMenuItemColor" is actually still // blue for Graphite. And while "keyboardFocusIndicatorColor" does change, // and is a good shade of gray, it's not blue enough for the Blue theme. flags.setColor(GetSystemColor(kColorId_FocusedMenuItemBackgroundColor)); canvas->drawRect(gfx::RectToSkRect(rect), flags); Probably... we should still use a native menu for the wrench menu, and find a nice way to delegate the insertion of the custom NSView*s Long-term we may want to consider ditching NSMenu for the wrench menu completely and just making it a popup/bubble window the way most* other browsers do (.e.g similar to the profile switcher). This would allow us to: - enable drag&drop in the bookmarks submenu, which we currently can not do no Mac (but can on other platforms) - fix a11y issues with zoom/cut/copy/paste and the extension icon container - allow opening menus on the extension icons - make it pretty / add branding / promos