New issue
Advanced search Search tips

Issue 813799 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Refactor RemoteCommandJob to use better default implementations of IsExpired/GetCommandTimeout

Project Member Reported by isandrk@chromium.org, Feb 20 2018

Issue description

All the subclasses override the default implementations with more sensible values, so pull them into the default to delete some code.
 
Summary: Refactor RemoteCommandJob to use better default implementations of IsExpired/GetCommandTimeout (was: Refactor RemoteCommandJob to use better default implementations of IsExpired/GetCommmandTimeout)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/421a0bb636d7fe67e4712a71c85c92c101c42268

commit 421a0bb636d7fe67e4712a71c85c92c101c42268
Author: Ivan Sandrk <isandrk@google.com>
Date: Wed Feb 21 19:31:11 2018

Refactor RemoteCommandJob to use better default implementations of IsExpired/GetCommandTimeout

All the subclasses override the default implementations with more sensible values, so pull them
into the default to delete some code.


Bug:  chromium:813799 
Change-Id: I201b179ede478a3a05c1a65e0453798b51513fa8
Reviewed-on: https://chromium-review.googlesource.com/926582
Commit-Queue: Ivan Ĺ andrk <isandrk@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538185}
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/chrome/browser/chromeos/policy/remote_commands/device_command_fetch_status_job.cc
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/chrome/browser/chromeos/policy/remote_commands/device_command_fetch_status_job.h
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/chrome/browser/chromeos/policy/remote_commands/device_command_set_volume_job.cc
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/chrome/browser/chromeos/policy/remote_commands/device_command_set_volume_job.h
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/components/policy/core/common/remote_commands/remote_command_job.cc
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/components/policy/core/common/remote_commands/remote_command_job.h
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/components/policy/core/common/remote_commands/remote_commands_queue.cc
[modify] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/components/policy/core/common/remote_commands/remote_commands_queue_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment