external/wpt/service-workers/service-worker/multipart-image.https.html is flaky |
||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fservice-workers%2Fservice-worker%2Fmultipart-image.https.html Seems it fails sometimes with: FAIL same-origin multipart image via SW should be readable assert_equals: expected 255 but got 0 I'm not sure why the image data is flaky but maybe it doesn't need to part of this test? If we didn't get a SecurityError maybe the test should just pass.
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e5d597b39bf0d761c8610409b5f3a88a8445597 commit 1e5d597b39bf0d761c8610409b5f3a88a8445597 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Feb 20 14:51:41 2018 Gardening: external/wpt/service-workers/service-worker/multipart-image.https.html is flaky Bug: 813775 Change-Id: Ifb738ea32c6f06b20aabca21b540a1c39577300f TBR: bashi Reviewed-on: https://chromium-review.googlesource.com/926442 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#537777} [modify] https://crrev.com/1e5d597b39bf0d761c8610409b5f3a88a8445597/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/fe51f83a6097256d4e2a18022a7c9db9cdaa658a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/outofblink-cors/external/wpt/service-workers/service-worker/multipart-image.https-expected.txt [delete] https://crrev.com/fe51f83a6097256d4e2a18022a7c9db9cdaa658a/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/outofblink-cors/external/wpt/service-workers/service-worker/multipart-image.https-expected.txt
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b96f4a7ef3cb5242ecac7623cb1ff58b08dfdb1 commit 3b96f4a7ef3cb5242ecac7623cb1ff58b08dfdb1 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Feb 22 03:48:07 2018 Use red images for service worker multipart-image wpt external/wpt/service-workers/service-worker/multipart-image.https.html checks the image data of multipart image when loading succeeds. The check was flaky because we used different colors for each part (green and red) and the content of the image data depends on which part of the multipart image is currently shown. Since it's difficult to detect which part is currently shown, we use the same color (red) for each part to avoid the flakiness. Bug: 813775 Change-Id: Iaafb4c02b2b72831951b5f6c244eea0b62153cd5 Reviewed-on: https://chromium-review.googlesource.com/930062 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#538339} [modify] https://crrev.com/3b96f4a7ef3cb5242ecac7623cb1ff58b08dfdb1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/multipart-image.py
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/867e4e749890bb160d0cf840c22ce5496422cb89 commit 867e4e749890bb160d0cf840c22ce5496422cb89 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Feb 23 02:54:37 2018 Remove multipart-image.https.html from TestExpectations The fix was landed as r538339 and the test looks working now. Bug: 813775 Change-Id: If949b9399f7eb6fc309ed8c938066bdf5f63520f Reviewed-on: https://chromium-review.googlesource.com/933501 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#538679} [modify] https://crrev.com/867e4e749890bb160d0cf840c22ce5496422cb89/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by falken@chromium.org
, Feb 20 2018