Regression: Recording icon appears in Black instead of red color in tabstrip.
Reported by
db...@etouch.net,
Feb 20 2018
|
|||
Issue descriptionChrome Version: 66.0.3350.0 Revision 2b1109ab0cd74dabb255f79029326f1ddbae6349-refs/heads/master@{#537342}(32/64 bit) OS: Windows(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.4) and Linux(14.04 LTS). What steps will reproduce the problem? (1) Launch chrome, open NTP and click on Search by voice icon (2) Observe recording icon in tab strips. Actual: Recording icon appears in Black instead of red color in tabstrip. Expected: Recording icon should turn red while recording. This is a regression issue, broken in 'M66'and providing bisect using bisect-per-revision: Good Build: 66.0.3345.0(Revision: 536027) Bad Build: 66.0.3346.0(Revision: 536238) You are probably looking for a change made after 536172 (known good), but no later than 536173 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/77e3c37a5378e1e70aad28e260a662a68818ec60..14f736d1b6aefdf1dfe01d1cbd99433a8ac86e62 Suspect: https://chromium.googlesource.com/chromium/src/+/14f736d1b6aefdf1dfe01d1cbd99433a8ac86e62 @Malay Keshav: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/117b507b32ae22a03b1646350005c0d24171cef2 commit 117b507b32ae22a03b1646350005c0d24171cef2 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Feb 20 20:57:55 2018 Change the default color for tab alert indicator The tab recording alert indicator icon no longer has a default color assigned to it in the icon file. Even when touch optimized mode is disabled, the correct color needs to be retrieved from the theme provider. Bug: 813763 Change-Id: I6cf37194aa1498520d973ee4300499ed402b10dc Component: Tab alert icon, recording icon, color Reviewed-on: https://chromium-review.googlesource.com/927110 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#537877} [modify] https://crrev.com/117b507b32ae22a03b1646350005c0d24171cef2/chrome/browser/ui/views/tabs/tab.cc
,
Feb 20 2018
,
Feb 22 2018
Update: Above issue is fixed on Windows(7,8,8.1,10) and Linux(14.04 LTS) using canary build #66.0.3352.0. Issue is still reproducible on Mac(10.12.6,10.13.1,10.13.4) OS using canary build #66.0.3352.0. Thank you.
,
Feb 28 2018
Issue 816841 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by malaykeshav@chromium.org
, Feb 20 2018