HTTP 500 when retrieving a test's results |
|||
Issue descriptionWPT imports are currently blocked because a new test, external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative.html, is not being rebaselined after the first run with the Blink trybots. It is reported as failing there, but running webkit-patch rebaseline-cl --verbose locally I can see that the -actual.txt files are not being retrieved, which leads to a failure in the CQ bots. The failures all look like this: 2018-02-20 12:22:43,389 - webkitpy.tool.commands.rebaseline_test: [DEBUG] Retrieving source https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javasc ript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt for target /data/src/chromium/src/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript -url-abort-return-value-string.tentative-expected.txt. 2018-02-20 12:22:44,208 - webkitpy.common.net.network_transaction: [WARNING] Received HTTP status 500 loading "https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-acro ss-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt". Retrying in 10 seconds... 2018-02-20 12:22:55,052 - webkitpy.common.net.network_transaction: [WARNING] Received HTTP status 500 loading "https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-acro ss-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt". Retrying in 15.0 seconds... 2018-02-20 12:23:10,790 - webkitpy.common.net.network_transaction: [WARNING] Received HTTP status 500 loading "https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-acro ss-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt". Retrying in 22.5 seconds... 2018-02-20 12:23:34,592 - webkitpy.common.net.network_transaction: [WARNING] Received HTTP status 500 loading "https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-acro ss-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt". Retrying in 33.75 seconds... 2018-02-20 12:24:09,107 - webkitpy.common.net.network_transaction: [WARNING] Received HTTP status 500 loading "https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-acro ss-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt". Retrying in 50.625 seconds... 2018-02-20 12:25:00,502 - webkitpy.common.net.network_transaction: [WARNING] Received HTTP status 500 loading "https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-acro ss-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt". Retrying in 75.9375 seconds... 2018-02-20 12:26:17,191 - webkitpy.common.net.network_transaction: [WARNING] Received HTTP status 500 loading "https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt". Retrying in 113.90625 seconds... 2018-02-20 12:28:12,172 - webkitpy.common.net.network_transaction: [WARNING] Received HTTP status 500 loading "https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt". Retrying in 170.859375 seconds... Traceback (most recent call last): File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py", line 110, in main result = command.check_arguments_and_execute(options, args, self) File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py", line 110, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_test.py", line 29, in execute self._rebaseline_test_and_update_expectations(options) File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_test.py", line 50, in _rebaseline_test_and_update_expectations self._rebaseline_test(port_name, options.test, suffix, results_url) File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_test.py", line 81, in _rebaseline_test self._tool.web.get_binary(source_baseline, return_none_on_404=True), File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py", line 37, in get_binary return NetworkTransaction(return_none_on_404=return_none_on_404).run(lambda: urllib2.urlopen(url).read()) File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py", line 61, in run self._check_for_timeout() File "/data/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py", line 68, in _check_for_timeout raise NetworkTimeout() webkitpy.common.net.network_transaction.NetworkTimeout: NetworkTimeout other tests can be rebaselined just fine. For now, I'll skip this test to unblock imports but this needs to be solved properly on the infra side.
,
Feb 20 2018
> WPT imports are currently blocked because a new test, external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative.html, is not being rebaselined after the first run with the Blink trybots. See e.g. https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12609
,
Feb 20 2018
Looking into this. This shouldn't be happening...
,
Feb 20 2018
https://cloud.google.com/appengine/docs/standard/python/memcache/#limits is the problem. I'm using the filepath as a key in memcache, which is ending up longer than the limit for key length. I'll hash it to fix this.
,
Feb 20 2018
https://14080-59dd026-tainted-martiniss-dot-test-results-test-hrd.appspot.com/data/layout_results/mac10_11_blink_rel/6180/layout-test-results/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-actual.txt fixes this problem. Should be deployed by EOD today.
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3c2187ff97269c2708c23e58983e60e779b0c931 commit 3c2187ff97269c2708c23e58983e60e779b0c931 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Feb 20 20:26:01 2018 Test results zip: Hash memcache keys We used to directly put filepaths in memcache. Some filepaths ended up pushing the total key length > 250 bytes, which is a limit for memcache. Hash the key instead. Also fixes a few error messages. Bug: 813762 Change-Id: I261b3cab445496a5eab3c1fd4629e032dd73bdda Reviewed-on: https://chromium-review.googlesource.com/927109 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Sean McCullough <seanmccullough@chromium.org> [modify] https://crrev.com/3c2187ff97269c2708c23e58983e60e779b0c931/go/src/infra/appengine/test-results/frontend/zip_test.go [modify] https://crrev.com/3c2187ff97269c2708c23e58983e60e779b0c931/go/src/infra/appengine/test-results/frontend/zip.go
,
Feb 20 2018
Fix should be live
,
Feb 21 2018
Thank you!
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/228e0c6533713c5856e9b6f8cffed22d24e0a18c commit 228e0c6533713c5856e9b6f8cffed22d24e0a18c Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Wed Feb 21 14:00:57 2018 Rebaseline javascript-url-abort-return-value-string.tentative.html Now that test-results.appspot.com has been fixed, we can fetch the right expectations from the bots and drop its entry from TestExpectations. TBR=foolip Bug: 813762 Change-Id: I4e0d7598e7805cd4533b2e371bd419eb2e0473d0 Reviewed-on: https://chromium-review.googlesource.com/928422 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#538091} [modify] https://crrev.com/228e0c6533713c5856e9b6f8cffed22d24e0a18c/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/228e0c6533713c5856e9b6f8cffed22d24e0a18c/third_party/WebKit/LayoutTests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-expected.txt |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Feb 20 2018