New issue
Advanced search Search tips

Issue 813759 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"BookmarkBrowsertest.Persist" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 20 2018

Issue description

"BookmarkBrowsertest.Persist" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIhtCb29rbWFya0Jyb3dzZXJ0ZXN0LlBlcnNpc3QM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
I'm disabling now...
Status: Available (was: Untriaged)
CL to disable is here: https://chromium-review.googlesource.com/c/chromium/src/+/927454

The mechanism for waiting for the bookmark model to be ready looks quite 'custom', and may not have aged well in the new TaskScheduler world.

I'm guessing that's the root cause of the recent increase in the flakiness, but that's just a guess.

https://cs.chromium.org/chromium/src/chrome/browser/ui/bookmarks/bookmark_browsertest.cc?sq=package:chromium&l=84
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ab5b919a3b689a7d9c8745f3d7472d159640d0d

commit 7ab5b919a3b689a7d9c8745f3d7472d159640d0d
Author: Tommy C. Li <tommycli@chromium.org>
Date: Tue Feb 20 23:10:20 2018

Sheriff: Disable flaky BookmarkBrowsertest.Persist on Windows

TBR=sky@chromium.org

Bug:  813759 
Change-Id: I5896d323742aa3811d0a96a972d7ea4e7cd90769
Reviewed-on: https://chromium-review.googlesource.com/927454
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537923}
[modify] https://crrev.com/7ab5b919a3b689a7d9c8745f3d7472d159640d0d/chrome/browser/ui/bookmarks/bookmark_browsertest.cc

Components: UI>Browser>Bookmarks
Labels: -Sheriff-Chromium
Taking off the sheriff queue, as now this falls to the Bookmarks UI team to fix.
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment