New issue
Advanced search Search tips

Issue 813721 link

Starred by 1 user
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Feb 2018
Cc:
lpalmaro@chromium.org
yawano@chromium.org
dtseng@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-02-19
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

ARC++: AccessibilityNodeInfo tree ordering does not match visual layout

Project Member Reported by dtseng@chromium.org, Feb 20 2018 
accessibility services on Android perform some amount of reordering of the accessibility tree as follows (code within utils):
- for a given node N,
- if N is either not visible or is focusable, consider its children ordered
- otherwise, use the children of N to compute ordering

The ordering is top to bottom, left to right.

Currently, in ARC++, we do not do the right thing. For example, in Play Store, the app drawer (e.g. the navigation menu button) appears at the end of navigation.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04b916e5271836799bd8f0d7888eaa2989acf738

commit 04b916e5271836799bd8f0d7888eaa2989acf738
Author: David Tseng <dtseng@chromium.org>
Date: Mon Feb 26 03:35:29 2018

Reorder ARC++ accessibility nodes using layout

This change is largely motivated by TalkBack utils.

The problem
It seems as though Android's accessibility tree is not in-order (rendered from left to right, top to bottom) when walking the tree in pre order.

As a result, app drawers appear at the end of the navigation linearization.

Bug:  813721 
Test: navigate linearly through Play Store. Verify navigation button/app text/search text field get seen first, then the app contents
Change-Id: I489b18708b8fb3a03a9d6e0cf0d42c830c9ac21f
Reviewed-on: https://chromium-review.googlesource.com/928047
Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539065}
[modify] https://crrev.com/04b916e5271836799bd8f0d7888eaa2989acf738/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/04b916e5271836799bd8f0d7888eaa2989acf738/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/04b916e5271836799bd8f0d7888eaa2989acf738/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h
[add] https://crrev.com/04b916e5271836799bd8f0d7888eaa2989acf738/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc_unittest.cc

Comment 2 by dtseng@chromium.org, Feb 28 2018

Status: fixed (was: Available)
►

Sign in to add a comment