sgabriel@: Could you prepare the following things?


Title on the notification:

1. Title for display mirror error notification
This is shown with a message such as " Mirroring with more than two displays is not supported.", "Could not mirror displays since no supported resolutions found. Entered extended desktop instead.", "This monitor isn't getting along with your Chromebook (the monitor is not supported)."


Vector icons on the top left on the notification:

2. LTE network activation notification icon
(old image: notification_lte.png)
This icon is shown with a title "Mobile data activated" and with a message "Congratulations! Your [CELLULAR NAME] data service has been activated and is ready to go. "

3. 3G network activation notification icon
(old image: notification_3g.png)
This icon is also shown with a title "Mobile data activated" and with a message "Congratulations! Your [CELLULAR NAME] data service has been activated and is ready to go. "

4. Cellular network activation error notification icon
(old image: status_cellular_failed.png)
This icon is shown with a title "Network activation error." and with a message "Activation of [CELLULAR NAME] requires a network connection."

5. Network auto-connection success notification icon
Currently, this notification does not have an image.
This icon is shown with a title "Switched network connection" and with a message "Your connection has switched to a more secure network"

Deleted: notification_lte.png 1.5 KB

	notification_lte.png 1.5 KB View Download

Deleted: notification_3g.png 2.5 KB

	notification_3g.png 2.5 KB View Download

Deleted: status_cellular_failed.png 1.4 KB

	status_cellular_failed.png 1.4 KB View Download

tetsui@ took IDR_DISK_SPACE_NOTIFICATION_CRITICAL and IDR_STORAGE_MANAGER_BUTTON as examples of notifications which still have right side icons.

But, the notification which has IDR_DISK_SPACE_NOTIFICATION_CRITICAL as |small_image| has |icon| already. So could I just remove this |small_image|?

IDR_STORAGE_MANAGER_BUTTON seems not to be used for |small_image|.

sgabriel@: I am sorry for the double comment. Could you also prepare the following things?

According to the spec (go/cros-md-notification-mock), a bluetooth notification has a title "Bluetooth". But there are three types of bluetooth notifications, so it seems to be better to have each title for each type of notifications.

1. The title for bluetooth adapter discoverability notification
The is shown with a message such as "Your computer is discoverable to nearby Bluetooth devices and will appear as Chromebook with address 01:23:45:67:89:0A"

2. The title for bluetooth paring notification
The is shown with a message such as "Bluetooth device Nexus S would like permission to pair. Please enter this PIN code on that device: 123456", "Bluetooth device Nexus S would like permission to pair. Please enter this passkey on that device: 123456", "Bluetooth device Nexus Swould like permission to pair. Before accepting, please confirm that this passkey is shown on that device: 123456", or "Bluetooth device Nexus S would like permission to pair."

3. The title for bluetooth paired notification
The is shown with a message such as "Bluetooth device Nexus S has been paired and is now available to all users. You may remove this pairing using Settings."

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7c3a37480869e8c801742229d6d13f47251462e

commit f7c3a37480869e8c801742229d6d13f47251462e
Author: Megumi Hattori <megumihattori@google.com>
Date: Fri Feb 23 05:26:08 2018

Remove icon on the right side of low disk space error notification.

According to MD notification spec (go/cros-md-notification-mock), all
the notifications should not show an icon on the right side. Instead,
they should show a new icon on the top left. (i.e. |icon| of
CreateSystemNotification should be empty. |small_image| should not be
empty.)

However, ShowLowDiskSpaceErrorNotification have both the right side icon
and the top left icon. This CL removes the right side icon.

BUG= 813708 
TEST=manual

Change-Id: I1434341b4e1b65dc8ac1e49865fd92fd232dbf92
Reviewed-on: https://chromium-review.googlesource.com/930601
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538706}
[modify] https://crrev.com/f7c3a37480869e8c801742229d6d13f47251462e/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc
[delete] https://crrev.com/83df8346ec78d444d6cbf2db4afa216ce0f13f5c/ui/chromeos/resources/default_100_percent/filesystem/notification_disk_space_critical.png
[delete] https://crrev.com/83df8346ec78d444d6cbf2db4afa216ce0f13f5c/ui/chromeos/resources/default_200_percent/filesystem/notification_disk_space_critical.png
[modify] https://crrev.com/f7c3a37480869e8c801742229d6d13f47251462e/ui/chromeos/resources/ui_chromeos_resources.grd

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3391736a5899419605f0a235002cd5d224431b67

commit 3391736a5899419605f0a235002cd5d224431b67
Author: Megumi Hattori <megumihattori@google.com>
Date: Thu Mar 01 03:02:10 2018

Add title and fix message on session timer system notification.

According to MD notification mock, all the notifications should show an
title. However, the session timer system notification (the notification
of TraySessionLengthLimit) does not have a title.  In addtion, the
message of the notification should be changed to the same one as the
mock one. This CL adds the title and fixes the message on the
notification.

Mock: go/cros-md-notification-mock
Screenshot: http://screen/AGxhe6foPeK

BUG= 813708 
TEST=ash_unittests

Change-Id: I03c7dfddd7df6f369e35caa433710540b2c56d65
Reviewed-on: https://chromium-review.googlesource.com/937003
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540008}
[modify] https://crrev.com/3391736a5899419605f0a235002cd5d224431b67/ash/ash_strings.grd
[modify] https://crrev.com/3391736a5899419605f0a235002cd5d224431b67/ash/system/session/tray_session_length_limit.cc
[modify] https://crrev.com/3391736a5899419605f0a235002cd5d224431b67/ash/system/session/tray_session_length_limit.h
[modify] https://crrev.com/3391736a5899419605f0a235002cd5d224431b67/ash/system/session/tray_session_length_limit_unittest.cc