New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 813707 link

Starred by 0 users
Status: Fixed
Owner:
█ megumihattori@google.com
Last visit > 30 days ago
Closed: Feb 2018
Cc:
█ maajid@chromium.org
tetsui@chromium.org
█ yoshiki@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Re-enable settings button and close button on MessageCenterView

Project Member Reported by megumihattori@google.com, Feb 20 2018 
Chrome Version: ToT(950384ffd4e30b1912c088d020e01794e78e98fa)

What steps will reproduce the problem?
(1) Generate a web notification at https://tests.peter.sh/notification-generator/
(2) Click the "1" button on the bottom bar of the screen
(3) Hover the mouse over the top right corner of the notification

What is the expected result?
A settings button and a close button should appear.

What happens instead?
Nothing happened.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca8b566e351baac4c99540fd9076b67075a5774

commit eca8b566e351baac4c99540fd9076b67075a5774
Author: Megumi Hattori <megumihattori@google.com>
Date: Tue Feb 27 01:32:21 2018

Reland "Implement scroll shadow on MessageCenterView."

This is a reland of b5cae0bd8875c5395d45c898906c2667b5264318.

Buttons such as settings buttons and close buttons were missing on
MessageCenterView. The reason for this bug is that the scroll shadow
view is catching mouse events that views behind that should catch.
This CL fixes this bug by changing event handling.

Original change's description:
> Implement scroll shadow on MessageCenterView.
>
> When MessageCenterView can be scrolled, the 2dp scroll shadow is
> displayed at the bottom.
>
> The shadow is displayed over notifications on MessageCenterView.
>
> If MessageCenterView is all scrolled, the shadow is hidden.
>
> BUG=779880
>
> Change-Id: I48fdb3e97c57075114ba4210cea40039c295a6d7
> Reviewed-on: https://chromium-review.googlesource.com/923244
> Commit-Queue: Megumi Hattori <megumihattori@google.com>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537711}

BUG= 813707 ,779880

Change-Id: Ice9c68f3a17848bc3e3d649b07ffd8ed2d3f7b4e
Reviewed-on: https://chromium-review.googlesource.com/925725
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Cr-Commit-Position: refs/heads/master@{#539365}
[modify] https://crrev.com/eca8b566e351baac4c99540fd9076b67075a5774/ash/message_center/message_center_view.cc
[modify] https://crrev.com/eca8b566e351baac4c99540fd9076b67075a5774/ash/message_center/message_center_view.h

Comment 2 by megumihattori@google.com, Feb 27 2018

Status: Fixed (was: Started)
►

Sign in to add a comment