New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813696 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Ill in gfx::Size::GetArea

Project Member Reported by ClusterFuzz, Feb 20 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4781099226759168

Fuzzer: dstockwell-anim-gen
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Ill
Crash Address: 0x000117e832c7
Crash State:
  gfx::Size::GetArea
  cc::ResourcePool::TryAcquireResourceForPartialRaster
  cc::TileManager::CreateRasterTask
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=480776:480824

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4781099226759168

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 20 2018

Components: Internals>Compositing UI>GFX
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Feb 20 2018

Cc: hayleyferr@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Solution to incorrect hit testing of composited transparent overlay by hayleyferr@google.com - https://chromium.googlesource.com/chromium/src/+/7bfdda3f4d9e53f1f3f5848f7228834b62bbf6b1

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.

Comment 3 by piman@chromium.org, Feb 20 2018

Owner: danakj@chromium.org
Status: Assigned (was: Untriaged)
->danakj for recent changes in resource allocation

Comment 4 by danakj@chromium.org, Feb 21 2018

I don't think it's the recent changes I've done, this is before the allocation, in trying to find a resource in the pool. It seems something is making a really big invalidated_rect() now. I'll look thru the CLs.

Comment 5 by danakj@chromium.org, Feb 21 2018

Cc: dstockwell@chromium.org suzyh@chromium.org
Hey, this clusterfuzz repro violates a DCHECK in Animation.cpp. That's not what it's reporting here but I thought you would want to know:

[1:1:0221/170811.188388:FATAL:Animation.cpp(270)] Check failed: result == (held_ ? hold_time_ : CalculateCurrentTime()) (-0.666481 vs. 0)
#0 0x7f1f85e1454c base::debug::StackTrace::StackTrace()
#1 0x7f1f85e3e93b logging::LogMessage::~LogMessage()
#2 0x7f1f7e38abc7 blink::Animation::CurrentTimeInternal()
#3 0x7f1f7e38ca80 blink::Animation::SetPlaybackRateInternal()
#4 0x7f1f7e38c97f blink::Animation::reverse()
#5 0x7f1f7f2c0421 blink::V8Animation::reverseMethodCallback()
#6 0x7f1f7fa8842d v8::internal::FunctionCallbackArguments::Call()
#7 0x7f1f7fb8003f v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#8 0x7f1f7fb7e509 v8::internal::Builtin_Impl_HandleApiCall()
#9 0x7f1f7fb7df4d v8::internal::Builtin_HandleApiCall()

Comment 6 by danakj@chromium.org, Feb 21 2018

Cc: -hayleyferr@google.com vmp...@chromium.org enne@chromium.org
Components: -UI>GFX
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46585243bc64b911aa5c283ca4bb05d2cf66e9b6

commit 46585243bc64b911aa5c283ca4bb05d2cf66e9b6
Author: danakj <danakj@chromium.org>
Date: Thu Feb 22 19:34:41 2018

Use checked math for reading a tiles invalidation rect.

Invalidation rects can be arbitrarily sized, so getting the area can
overflow. Handle this by treating such a rect as max-int sized, which
makes it the lowest priority, where the code is looking for the smallest
rect.

R=enne@chromium.org

Bug:  813696 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I7e9fa2aaf4347583bbf799112cd0f29cd248bed0
Reviewed-on: https://chromium-review.googlesource.com/930082
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538524}
[modify] https://crrev.com/46585243bc64b911aa5c283ca4bb05d2cf66e9b6/cc/resources/resource_pool.cc
[modify] https://crrev.com/46585243bc64b911aa5c283ca4bb05d2cf66e9b6/cc/resources/resource_pool_unittest.cc

Comment 8 by danakj@chromium.org, Feb 22 2018

Status: Fixed (was: Assigned)
Project Member

Comment 9 by ClusterFuzz, Feb 23 2018

ClusterFuzz has detected this issue as fixed in range 538521:538547.

Detailed report: https://clusterfuzz.com/testcase?key=4781099226759168

Fuzzer: dstockwell-anim-gen
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Ill
Crash Address: 0x000117e832c7
Crash State:
  gfx::Size::GetArea
  cc::ResourcePool::TryAcquireResourceForPartialRaster
  cc::TileManager::CreateRasterTask
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=480776:480824
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=538521:538547

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4781099226759168

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Feb 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4781099226759168 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment