Issue 813675 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	tkent@chromium.org
Closed:	Feb 2018
Cc:	domenic@chromium.org
Components:	Blink>HTML>CustomElements
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Blocking:
issue 648828

Update "is" attribute serialization behavior

Project Member Reported by tkent@chromium.org, Feb 20 2018

Issue description

Chrome Version: ToT
OS: All

What steps will reproduce the problem?
(1) Open http://w3c-test.org/custom-elements/parser/serializing-html-fragments.html

What is the expected result?
All tests pass.

What happens instead?
Some tests fail.

Please use labels and text to provide additional information.
We should follow a recent spec change.
https://github.com/whatwg/html/pull/3444


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39d6307683c0e17c74026d2c2d20c33a4ffab383

commit 39d6307683c0e17c74026d2c2d20c33a4ffab383
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Feb 21 02:13:50 2018

custom-elements: Implement "is value" serialization.

https://html.spec.whatwg.org/multipage/parsing.html#html-fragment-serialisation-algorithm
We should serialize "is value" if "is" content attribute is missing.

Bug:  813675 
Change-Id: I01ed69578acf5e4ce4c4eef9000fc9043be8be3b
Reviewed-on: https://chromium-review.googlesource.com/925884
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537995}
[delete] https://crrev.com/c480721603a9cac999bf6aaddc31fc67bc54da87/third_party/WebKit/LayoutTests/external/wpt/custom-elements/parser/serializing-html-fragments-expected.txt
[modify] https://crrev.com/39d6307683c0e17c74026d2c2d20c33a4ffab383/third_party/WebKit/Source/core/dom/AttributeCollection.h
[modify] https://crrev.com/39d6307683c0e17c74026d2c2d20c33a4ffab383/third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp

Comment 2 by tkent@chromium.org, Feb 21 2018

Status: Fixed (was: Assigned)

►

Issue 813675 link

Issue metadata

Update "is" attribute serialization behavior

Issue description

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

Comment 1 Deleted

Comment 2 by tkent@chromium.org, Feb 21 2018

Comment 2 Deleted

Sign in to add a comment