New issue
Advanced search Search tips

Issue 813670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove DispatchLegacyFetchEvent

Project Member Reported by falken@chromium.org, Feb 20 2018

Issue description

Now that we support client id, it should be possible to remove the DispatchLegacyFetchEvent interface. This will reduce the diff between non-S13nSW and S13nSW and simplify the code.
 

Comment 1 by falken@chromium.org, Feb 21 2018

Labels: M-66
Status: Fixed (was: Started)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23482821d11e58e947634e67513fc6a7d42e8c8f

commit 23482821d11e58e947634e67513fc6a7d42e8c8f
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Feb 21 03:38:18 2018

service worker: Eliminate DispatchLegacyFetchEvent.

This reduces the difference between non-S13nServiceWorker and S13nServiceWorker
code.

The main change is moving non-S13nSW to use ResourceRequest instead
of ServiceWorkerFetchRequest. The wrinkle is that SWFetchRequest had three
fields for the requeest body which seems like we still must use. Non-S13nSW
makes a blob out of the request body and sends it to the renderer as
blob UUID, blob size, and a Mojo blob ptr. I've retained this behavior by
passing the blob stuff in addition to ResourceRequest.

R=kinuko, shimazu

Bug:  715640 
Change-Id: I633c9b414e53e8acd1f122a69d6ccb4d2d3c2f62
Reviewed-on: https://chromium-review.googlesource.com/925982
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538015}
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/common/service_worker/dispatch_fetch_event_params.mojom
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/renderer/service_worker/service_worker_context_client.h

Sign in to add a comment