New issue
Advanced search Search tips

Issue 813646 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Timeout in pdf_formcalc_fuzzer

Project Member Reported by ClusterFuzz, Feb 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5247645552214016

Fuzzer: libFuzzer_pdf_formcalc_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_formcalc_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=510507:510587

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5247645552214016

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 19 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Blocking: 62400
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/77c223be193b303b833053a757a2f1f2534da610

commit 77c223be193b303b833053a757a2f1f2534da610
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Mon May 14 18:24:40 2018

Use internal wcstof instead of system wcstod in formcalc lexer

This CL switches the usage of wcstod to use the FXSYS_wcstof to
determine if a given string is a valid floating point number.

Using the internal method makes linux slightly slower (10's of ms)
makes mac a lot faster 900ms to 60ms for the test case in the bug.

The FXSYS_wcstof method has been extended to handle the parsing of
float exponents. Unittests were added for FXSYS_wcstof.

Bug:  chromium:813646 
Change-Id: Ie68287a336e3b95a0c0b845d5bf39db6fc82b39c
Reviewed-on: https://pdfium-review.googlesource.com/32510
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/77c223be193b303b833053a757a2f1f2534da610/core/fxcrt/fx_extension.cpp
[modify] https://crrev.com/77c223be193b303b833053a757a2f1f2534da610/xfa/fxfa/fm2js/cxfa_fmlexer.cpp
[modify] https://crrev.com/77c223be193b303b833053a757a2f1f2534da610/core/fxcrt/fx_extension_unittest.cpp

Status: Fixed (was: Started)
I believe this should be resolved with the above CL.
Project Member

Comment 6 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19319cd537d91d88262c1b4257442a339db88e8b

commit 19319cd537d91d88262c1b4257442a339db88e8b
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon May 14 20:14:29 2018

Roll src/third_party/pdfium/ 22c24441a..77c223be1 (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/22c24441a3a4..77c223be193b

$ git log 22c24441a..77c223be1 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 dsinclair Use internal wcstof instead of system wcstod in formcalc lexer
2018-05-14 tsepez Add regression test for XFA crash under CPDF_LinkList::GetPageLinks().
2018-05-14 hnakashima Cleanup unused members of CFWL_MonthCalendar.
2018-05-14 hnakashima Remove dead code from CFWL_WidgetMgr.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:813646 , chromium:840922 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I663f89d69fd2fe4be1c05357226fec22db967113
Reviewed-on: https://chromium-review.googlesource.com/1058032
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558433}
[modify] https://crrev.com/19319cd537d91d88262c1b4257442a339db88e8b/DEPS

Project Member

Comment 7 by ClusterFuzz, May 15 2018

Labels: OS-Linux
Project Member

Comment 8 by ClusterFuzz, May 16 2018

ClusterFuzz has detected this issue as fixed in range 558334:558579.

Detailed report: https://clusterfuzz.com/testcase?key=5247645552214016

Fuzzer: libFuzzer_pdf_formcalc_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_formcalc_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=510507:510587
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=558334:558579

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5247645552214016

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, May 16 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5247645552214016 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment