I'm rather confused now Simon. You mentioned that "You can set up sub-models with different thermal config with the unified build config." so why do we have this new bug then if it's already doable?

It's doable, but not done. The bug is to track the actual work to do this. At present the config assumes that the thermal characteristics are the same for all sub-models. I checked that just yesterday.

See CL here:

https://chromium-review.googlesource.com/c/chromiumos/platform2/+/927006/1

That sheets comment is very prone to misinterpretation... To my ears and eyes saying "you can do xyz" means that you can actually do it without further change necessary. Otherwise I'd expect a qualifier/explanation saying that it's theoretically doable, but something needs to get done for it to be so. 

OK, I'm very sorry for that. It is just software, we can do anything :-) I'll try to be clearer in future.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/efcbe33efefb733fff5131c2fc2d11e9fe45d37e

commit efcbe33efefb733fff5131c2fc2d11e9fe45d37e
Author: Simon Glass <sjg@chromium.org>
Date: Sat Feb 24 23:16:10 2018

chromeos-config: Add support for per-submodel thermal files

This was requested recently. Update the implementation to support it and
adjust the tests.

BUG= chromium:813626 
TEST=FEATURES=test sudo -E emerge  --nodeps chromeos-config-host \
	chromeos-config-tools

Change-Id: I6694c5ab82791bc0608627c1291f44430a3e2fc8
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/927006
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Patrick Berny <pberny@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/efcbe33efefb733fff5131c2fc2d11e9fe45d37e/chromeos-config/libcros_config/test.dts
[modify] https://crrev.com/efcbe33efefb733fff5131c2fc2d11e9fe45d37e/chromeos-config/cros_config_host/v2/cros_config_schema_example.json
[modify] https://crrev.com/efcbe33efefb733fff5131c2fc2d11e9fe45d37e/chromeos-config/cros_config_host/libcros_config_host_unittest.py
[modify] https://crrev.com/efcbe33efefb733fff5131c2fc2d11e9fe45d37e/chromeos-config/libcros_config/cros_config_unittest.cc
[modify] https://crrev.com/efcbe33efefb733fff5131c2fc2d11e9fe45d37e/chromeos-config/cros_config_host/v2/cros_config_schema_example.yaml
[modify] https://crrev.com/efcbe33efefb733fff5131c2fc2d11e9fe45d37e/chromeos-config/cros_config_host/libcros_config_host.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/13550a4005c8372d2ef99fdf5c6348b9163ecf09

commit 13550a4005c8372d2ef99fdf5c6348b9163ecf09
Author: Simon Glass <sjg@chromium.org>
Date: Sat Feb 24 23:16:11 2018

chromeos-config: Move the yaml example files

Move these files into the same directory as the device-tree example file.
This makes it easier for us to find (e.g.) the yaml file given the FDT
file. It is easier to replace the filename extension than to hunt through
a different directory.

BUG= chromium:813626 
TEST=FEATURES=test sudo -E emerge  --nodeps chromeos-config-host \
	chromeos-config-tools

Change-Id: Id5c4af65fe2eb40bebde8dbaa08bc0432ad24f15
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/927007
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[rename] https://crrev.com/13550a4005c8372d2ef99fdf5c6348b9163ecf09/chromeos-config/libcros_config/test.yaml
[modify] https://crrev.com/13550a4005c8372d2ef99fdf5c6348b9163ecf09/chromeos-config/cros_config_host/cros_config_host_unittest.py
[rename] https://crrev.com/13550a4005c8372d2ef99fdf5c6348b9163ecf09/chromeos-config/libcros_config/test.json
[modify] https://crrev.com/13550a4005c8372d2ef99fdf5c6348b9163ecf09/chromeos-config/cros_config_host/v2/cros_config_schema_unittest.py
[modify] https://crrev.com/13550a4005c8372d2ef99fdf5c6348b9163ecf09/chromeos-config/cros_config_host/libcros_config_host_unittest.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/453d746cbc2956147df92678d4083cbf5aca17f2

commit 453d746cbc2956147df92678d4083cbf5aca17f2
Author: Simon Glass <sjg@chromium.org>
Date: Sun Feb 25 05:38:52 2018

chromeos-config: Use GetModelList() instead of direct access

The API function returns a sorted list which is more reproduceable in a
test. Update the code to use that.

BUG= chromium:813626 
TEST=FEATURES=test sudo -E emerge  --nodeps chromeos-config-host \
	chromeos-config-tools

Change-Id: Ic6cb1b116ff7a0d0a002187e1c235a8cc0dc3d8a
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/933734
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/453d746cbc2956147df92678d4083cbf5aca17f2/chromeos-config/cros_config_host/libcros_config_host_unittest.py