New issue
Advanced search Search tips

Issue 813597 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Remove legacy cygprofile instrumentation.

Project Member Reported by lizeb@chromium.org, Feb 19 2018

Issue description

Tracking bug.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283

commit 5ecdb8cf939ff1d3b53a34e45e283e0975ba8283
Author: Benoit Lize <lizeb@chromium.org>
Date: Wed Feb 21 13:19:40 2018

android: Remove the legacy orderfile instrumentation.

Bug:  813597 
Change-Id: Ie4838ed3b816b483b3b44325f4159856c3b81d4e
Reviewed-on: https://chromium-review.googlesource.com/925424
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538082}
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/BUILD.gn
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/base/android/library_loader/library_prefetcher.cc
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/build/config/android/BUILD.gn
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/build/config/android/abi.gni
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/chrome/android/BUILD.gn
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/tools/cygprofile/BUILD.gn
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/tools/cygprofile/cyglog_to_orderfile.py
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/tools/cygprofile/cyglog_to_orderfile_unittest.py
[delete] https://crrev.com/ed718f52c14b7678c6b1fbce8bb0c86375bbef60/tools/cygprofile/cygprofile.cc
[delete] https://crrev.com/ed718f52c14b7678c6b1fbce8bb0c86375bbef60/tools/cygprofile/cygprofile.h
[delete] https://crrev.com/ed718f52c14b7678c6b1fbce8bb0c86375bbef60/tools/cygprofile/cygprofile_perftest.cc
[delete] https://crrev.com/ed718f52c14b7678c6b1fbce8bb0c86375bbef60/tools/cygprofile/cygprofile_unittest.cc
[delete] https://crrev.com/ed718f52c14b7678c6b1fbce8bb0c86375bbef60/tools/cygprofile/mergetraces.py
[delete] https://crrev.com/ed718f52c14b7678c6b1fbce8bb0c86375bbef60/tools/cygprofile/mergetraces_unittest.py
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/tools/cygprofile/orderfile_generator_backend.py
[modify] https://crrev.com/5ecdb8cf939ff1d3b53a34e45e283e0975ba8283/tools/cygprofile/profile_android_startup.py

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b33f7e21ffa29e67a02d27161c0e03486287744

commit 2b33f7e21ffa29e67a02d27161c0e03486287744
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Thu Feb 22 12:33:02 2018

Revert "android: Remove the legacy orderfile instrumentation."

This reverts commit 5ecdb8cf939ff1d3b53a34e45e283e0975ba8283.

Reason for revert: Speculative revert for crbug.com/814627

Original change's description:
> android: Remove the legacy orderfile instrumentation.
> 
> Bug:  813597 
> Change-Id: Ie4838ed3b816b483b3b44325f4159856c3b81d4e
> Reviewed-on: https://chromium-review.googlesource.com/925424
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Matthew Cary <mattcary@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538082}

TBR=pasko@chromium.org,agrieve@chromium.org,lizeb@chromium.org,mattcary@chromium.org

Change-Id: I161ebcdaf105d561d4b4ad5ebb21a065ebc9be14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  813597 
Reviewed-on: https://chromium-review.googlesource.com/931381
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538414}
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/BUILD.gn
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/base/android/library_loader/library_prefetcher.cc
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/build/config/android/BUILD.gn
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/build/config/android/abi.gni
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/chrome/android/BUILD.gn
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/BUILD.gn
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/cyglog_to_orderfile.py
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/cyglog_to_orderfile_unittest.py
[add] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/cygprofile.cc
[add] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/cygprofile.h
[add] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/cygprofile_perftest.cc
[add] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/cygprofile_unittest.cc
[add] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/mergetraces.py
[add] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/mergetraces_unittest.py
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/orderfile_generator_backend.py
[modify] https://crrev.com/2b33f7e21ffa29e67a02d27161c0e03486287744/tools/cygprofile/profile_android_startup.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/964668123b69ad0bf8852c8ffaacfadbb6182b15

commit 964668123b69ad0bf8852c8ffaacfadbb6182b15
Author: Benoit L <lizeb@chromium.org>
Date: Tue Mar 06 15:58:37 2018

Reland "android: Remove the legacy orderfile instrumentation."

This reverts commit 2b33f7e21ffa29e67a02d27161c0e03486287744.

Reason for reland: The initial CL wasn't related to
                   crbug.com/814627.

Original change's description:
> Revert "android: Remove the legacy orderfile instrumentation."
> 
> This reverts commit 5ecdb8cf939ff1d3b53a34e45e283e0975ba8283.
> 
> Reason for revert: Speculative revert for crbug.com/814627
> 
> Original change's description:
> > android: Remove the legacy orderfile instrumentation.
> > 
> > Bug:  813597 
> > Change-Id: Ie4838ed3b816b483b3b44325f4159856c3b81d4e
> > Reviewed-on: https://chromium-review.googlesource.com/925424
> > Reviewed-by: Egor Pasko <pasko@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Reviewed-by: Matthew Cary <mattcary@chromium.org>
> > Commit-Queue: Benoit L <lizeb@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#538082}
> 
> TBR=pasko@chromium.org,agrieve@chromium.org,lizeb@chromium.org,mattcary@chromium.org
> 
> Change-Id: I161ebcdaf105d561d4b4ad5ebb21a065ebc9be14
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  813597 
> Reviewed-on: https://chromium-review.googlesource.com/931381
> Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538414}

TBR=pasko@chromium.org,trchen@chromium.org,agrieve@chromium.org,lizeb@chromium.org,mattcary@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  813597 
Change-Id: I22daf61b6441336d9158124be3cc71959e426613
Reviewed-on: https://chromium-review.googlesource.com/951422
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541111}
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/BUILD.gn
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/base/android/library_loader/library_prefetcher.cc
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/build/config/android/BUILD.gn
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/build/config/android/abi.gni
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/chrome/android/BUILD.gn
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/tools/cygprofile/BUILD.gn
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/tools/cygprofile/cyglog_to_orderfile.py
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/tools/cygprofile/cyglog_to_orderfile_unittest.py
[delete] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/tools/cygprofile/cygprofile.cc
[delete] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/tools/cygprofile/cygprofile.h
[delete] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/tools/cygprofile/cygprofile_perftest.cc
[delete] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/tools/cygprofile/cygprofile_unittest.cc
[delete] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/tools/cygprofile/mergetraces.py
[delete] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/tools/cygprofile/mergetraces_unittest.py
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/tools/cygprofile/orderfile_generator_backend.py
[modify] https://crrev.com/964668123b69ad0bf8852c8ffaacfadbb6182b15/tools/cygprofile/profile_android_startup.py

Comment 4 by lizeb@chromium.org, Apr 17 2018

Status: Fixed (was: Assigned)

Sign in to add a comment