New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813577 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 771643



Sign in to add a comment

DCHECK in ~FindObjectPropertiesNeedingUpdateScope

Project Member Reported by droger@chromium.org, Feb 19 2018

Issue description

Renderer crashes with this stack:

[1:1:0219/153849.930802:FATAL:FindPropertiesNeedingUpdate.h(167)] Check failed: *original_properties_->Effect() == *object_properties->Effect(). Property was updated without the layout object ("LayoutSVGContainer g id='YGlOvc' class='yhFy6d sOEOU'") needing a paint property update.
Original:
 0x2dcca39488b0 {"parent":"0x2dcca393c1f0","localTransformSpace":"0x2dcca3ae4a50","outputClip":"(nil)","opacity":0,"compositorElementId":"(2376)"}
Updated:
Effect (LayoutSVGContainer g id='YGlOvc' class='yhFy6d sOEOU') 0x2dcca3946e70 {"parent":"0x2dcca393c1f0","localTransformSpace":"0x2dcca3ae4a50","outputClip":"(nil)","opacity":0,"directCompositingReasons":"activeOpacityAnimation","compositorElementId":"(2376)"}
#0 0x7fab53ded9fd base::debug::StackTrace::StackTrace()
#1 0x7fab53debeec base::debug::StackTrace::StackTrace()
#2 0x7fab53e744ca logging::LogMessage::~LogMessage()
#3 0x7fab41925e5c blink::FindObjectPropertiesNeedingUpdateScope::~FindObjectPropertiesNeedingUpdateScope()
#4 0x7fab41910d85 blink::(anonymous namespace)::FragmentPaintPropertyTreeBuilder::UpdateForSelf()
#5 0x7fab41910ace blink::ObjectPaintPropertyTreeBuilder::UpdateForSelf()
#6 0x7fab4193f9b8 blink::PrePaintTreeWalk::WalkInternal()
#7 0x7fab4193f451 blink::PrePaintTreeWalk::Walk()
#8 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#9 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#10 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#11 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#12 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#13 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#14 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#15 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#16 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#17 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#18 0x7fab4193f4aa blink::PrePaintTreeWalk::Walk()
#19 0x7fab4193f075 blink::PrePaintTreeWalk::Walk()
#20 0x7fab4193ead5 blink::PrePaintTreeWalk::WalkTree()
#21 0x7fab40f6d493 blink::LocalFrameView::PrePaint()
#22 0x7fab40f6b631 blink::LocalFrameView::UpdateLifecyclePhasesInternal()
#23 0x7fab40f6abe2 blink::LocalFrameView::UpdateAllLifecyclePhases()
#24 0x7fab4182c61b blink::PageAnimator::UpdateAllLifecyclePhases()
#25 0x7fab41831cbc blink::PageWidgetDelegate::UpdateLifecycle()
#26 0x7fab40e8d468 blink::WebViewImpl::UpdateLifecycle()
#27 0x7fab41003707 blink::WebViewFrameWidget::UpdateLifecycle()
#28 0x7fab4f5d61e6 content::RenderWidget::UpdateVisualState()
#29 0x7fab4f3bebe0 content::RenderWidgetCompositor::UpdateLayerTreeHost()
#30 0x7fab4b6573f0 cc::LayerTreeHost::RequestMainFrameUpdate()
#31 0x7fab4b7480a0 cc::ProxyMain::BeginMainFrame()


This happens in particular on the Google signin webpage accounts.google.com (when trying to add an account).
 

Comment 1 by droger@chromium.org, Feb 19 2018

Labels: M-66 ReleaseBlock-Beta
Labels: OS-Linux
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
P1 due to important page. DCHECK is maybe not such a big deal but it does point to a signifciant problem, I assume.
Cc: yananj@google.com wangxianzhu@chromium.org
 Issue 813770  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7461b2b44d25eb00632baf7d07eb21424156b5f

commit a7461b2b44d25eb00632baf7d07eb21424156b5f
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Feb 20 22:18:41 2018

[SPv175] Disable comparison of some paint property node fields

The fields are used for SPv2 only, so disable comparison of them
for SPv175.

Bug:  813577 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I09f808d7545e49edefdbffcff1bb4385563a47d9
Reviewed-on: https://chromium-review.googlesource.com/926911
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537906}
[modify] https://crrev.com/a7461b2b44d25eb00632baf7d07eb21424156b5f/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
[modify] https://crrev.com/a7461b2b44d25eb00632baf7d07eb21424156b5f/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h
[modify] https://crrev.com/a7461b2b44d25eb00632baf7d07eb21424156b5f/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h

Blocking: 771643
Status: Fixed (was: Assigned)

Sign in to add a comment