New issue
Advanced search Search tips

Issue 813545 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Layout Test media/video-transformed.html is failing

Project Member Reported by tnagel@chromium.org, Feb 19 2018

Issue description

The following layout test is failing on Win7 Tests (dbg)(1)

media/video-transformed.html

Last successful run:

https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66386

First failing run:

https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66387

Curiously the expectation was changed right before the test started to fail: https://chromium-review.googlesource.com/918122

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d2dbc45ca18d051be35ac098427365ba8fea4e

commit b1d2dbc45ca18d051be35ac098427365ba8fea4e
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Mon Feb 19 15:17:29 2018

Allow media/video-transformed.html failures (Win 7)

BUG= 813545 
TBR=media-dev

Change-Id: I1e0f2d69d4e3d962be5e7fbeadc9af7b0e705342
Reviewed-on: https://chromium-review.googlesource.com/924704
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537655}
[modify] https://crrev.com/b1d2dbc45ca18d051be35ac098427365ba8fea4e/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by junov@chromium.org, Feb 19 2018

Components: -Blink Blink>Media>Video
Cc: rogerm@chromium.org
 Issue 796997  has been merged into this issue.
Cc: mlamouri@chromium.org
Status: Assigned (was: Untriaged)
Khushal, can you PTAL?

Comment 5 by kolos@chromium.org, Feb 20 2018

Cc: khushals...@chromium.org
 Issue 813150  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/507676a61982c3feccda59c839fa8493139c4a72

commit 507676a61982c3feccda59c839fa8493139c4a72
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue Feb 20 14:52:31 2018

Mark media/video-transformed.html flaky on Mac

TBR=khushalsagar@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Bug:  813545 ,  813150 
Change-Id: I46869c1d8bb4250fc94416c9083e0d2185d9b8a1
Reviewed-on: https://chromium-review.googlesource.com/926402
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537778}
[modify] https://crrev.com/507676a61982c3feccda59c839fa8493139c4a72/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Pri-3 Pri-1
I'm taking a look now. Is this only Win and Mac?
Cc: enne@chromium.org
+enne fyi. This is failing only on debug builds with tiny differences from blending. I'm going to disable the test for debug builds.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813217c58878ab53f43d707edbac8a06611e1d8f

commit 813217c58878ab53f43d707edbac8a06611e1d8f
Author: Khushal <khushalsagar@chromium.org>
Date: Wed Feb 21 00:23:36 2018

media: Disable media/video-transformed.html on Debug builds.

R=enne@chromium.org

Bug:  813545 
Change-Id: I7cde2b1c4b25e1a8b170a9142cf9498d1cb78b9b
Reviewed-on: https://chromium-review.googlesource.com/927748
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537952}
[modify] https://crrev.com/813217c58878ab53f43d707edbac8a06611e1d8f/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Comment 11 by kolos@chromium.org, Feb 21 2018

Status: (was: Fixed)
it still makes builders red.
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fa4a41304130cdcf678a0567fe9adec56392070

commit 3fa4a41304130cdcf678a0567fe9adec56392070
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Feb 21 12:17:32 2018

Skip media/video-transformed.html flaky on Mac and Win

TBR=khushalsagar@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Bug:  813545 ,  813150 
Change-Id: I51c48e55606139e858ed4212a77cfc088b60cf90
Reviewed-on: https://chromium-review.googlesource.com/928222
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538072}
[modify] https://crrev.com/3fa4a41304130cdcf678a0567fe9adec56392070/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7352b6b82dedcd722b641f86bbb0c9bd9096fa78

commit 7352b6b82dedcd722b641f86bbb0c9bd9096fa78
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Feb 21 14:42:23 2018

Mark media/video-transformed.html flaky on Mac and Win

Skipping doesn't work https://chromium-review.googlesource.com/c/chromium/src/+/928222

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/31235

TBR=khushalsagar@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Bug:  813545 ,  813150 
Change-Id: Id9dd1e35a40164fed7f9a5f78367f021d35c5b5e
Reviewed-on: https://chromium-review.googlesource.com/928645
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538097}
[modify] https://crrev.com/7352b6b82dedcd722b641f86bbb0c9bd9096fa78/third_party/WebKit/LayoutTests/TestExpectations

The failure on Win bot needs a rebaseline. The expectation looks wrong (https://test-results.appspot.com/data/layout_results/WebKit_Win10/31228/layout-test-results/results.html).
https://chromium-review.googlesource.com/c/chromium/src/+/929862 in review for rebaselining on win and disabling the test on debug in review.
Status: Fixed

Comment 18 by hubbe@chromium.org, Mar 26 2018

This test seems to still be an issue.
The Sheriffs attached some information to another bug here:
https://bugs.chromium.org/p/chromium/issues/detail?id=754986#c8

I don't think it's a video issue, as the whole image is gray, not just the video elements.

Comment 19 by hubbe@chromium.org, Mar 26 2018

Actually, I was reading the image wrong, it's not all gray.
After closer examination, the error seems to occur in the 3-pixel red boarder around the image.

Sign in to add a comment