New issue
Advanced search Search tips

Issue 813537 link

Starred by 1 user
Status: Fixed
Owner:
nya@chromium.org
Closed: Feb 2018
Cc:
derat@chromium.org
vapier@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

chromeos-base/feedback package has multiple stable ebuilds

Project Member Reported by nya@chromium.org, Feb 19 2018 
% ls -l third_party/chromiumos-overlay/chromeos-base/feedback
total 12
-rw-r----- 1 nya eng 1497 Aug 28 12:11 feedback-0.0.1-r2071.ebuild
-rw-r--r-- 1 nya eng 1535 Feb 14 15:16 feedback-0.0.1-r519.ebuild
-rw-r--r-- 1 nya eng 1369 Feb 13 12:41 feedback-9999.ebuild

Last year, derat@ added CROS_WORKON_BLACKLIST=1:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/600991

and reverted it:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/600518

... then a new ebuild was created rather than incrementing the existing one. Let's delete the old one.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/311bb84bc7e40defd70a5edcbe82d5c76ac9162d

commit 311bb84bc7e40defd70a5edcbe82d5c76ac9162d
Author: Shuhei Takahashi <nya@chromium.org>
Date: Tue Feb 20 04:32:44 2018

feedback: Delete an orphan stable build.

CL:600991 added CROS_WORKON_BLACKLIST=1 but it was reverted in
CL:600518. It created a new -r1 ebuild rather than incrementing
the existing ebuild.

BUG= chromium:813537 
TEST=emerge-cave --nodeps chromeos-base/feedback

Change-Id: Ib6a9b94e50c36b78eb38ad10ff66563c60950bc0
Reviewed-on: https://chromium-review.googlesource.com/923908
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/0cb3d9339c56a6be4caba427a7430f592cb2ce60/chromeos-base/feedback/feedback-0.0.1-r2071.ebuild

Comment 2 by nya@chromium.org, Feb 20 2018

Status: Fixed (was: Started)
►

Sign in to add a comment