[Local NTP] Handle interactive Doodle iframe failures more gracefully |
|||||||
Issue descriptionOn the local NTP, interactive Doodles are displayed in an iframe. If that iframe fails to load for any reason (see e.g. bug 807604 , bug 813317 ), we just show an error page, which is really ugly. It'd be nice to detect such errors (maybe the iframe's .onerror handler is enough?) and just fall back to the default logo instead.
,
Mar 5 2018
This would be great to have before launching interactive Doodles on the local NTP, but it's not strictly required.
,
Jul 27
,
Sep 20
,
Oct 5
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7673b83313dbd5988dfd070cdec27bdbe83c617 commit b7673b83313dbd5988dfd070cdec27bdbe83c617 Author: Kyle Milka <kmilka@chromium.org> Date: Tue Oct 09 20:41:59 2018 [NTP] Don't display cached interactive doodles when offline Attempting to display a cached interactive doodle while offline results in an error loading the iframe. Fall back to the default logo in this case. Bug: 813513 Change-Id: I81e46db65812caf1baf1340ff1cf0f9921dab6cc Reviewed-on: https://chromium-review.googlesource.com/c/1271583 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#598070} [modify] https://crrev.com/b7673b83313dbd5988dfd070cdec27bdbe83c617/chrome/browser/resources/local_ntp/local_ntp.js
,
Oct 11
,
Oct 24
Looks like there's nothing left we can really do here, we've eliminated all the sources of errors I can identify and issues within the iframe are opaque to the NTP. Interesting note, onerror is never fired for iframes, which is WAI: crbug.com/365457 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pnoland@chromium.org
, Feb 20 2018