New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813498 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Better UI for "Sync disabled" via Cloud Policy state

Project Member Reported by droger@chromium.org, Feb 19 2018

Issue description

See screenshot.

The text in the red button is not right.
It should say something similar to what is displayed in the settings page:
"Sync disabled by your administrator".
 
Screenshot from 2018-02-19 10-19-17.png
80.2 KB View Download
Blocking: -807826
I just tested this and apparently this bug existed before Dice:
https://drive.google.com/file/d/1U53uLl50ZrtuqSIgL11fHq-PDiSPak_n/view?usp=sharing

Comment 2 by ew...@chromium.org, Feb 20 2018

Cc: ew...@chromium.org
Labels: Hotlist-DICE-Followup OS-Linux OS-Mac OS-Windows
Cool, thanks for testing Thomas. If this isn't a regression, we should fix it at some point, but definitely non-blocking.

Comment 3 by ew...@chromium.org, Feb 21 2018

Cc: tangltom@chromium.org
Owner: ew...@chromium.org
Assigning to myself to get mocks for this

Comment 4 by ew...@chromium.org, Feb 23 2018

Labels: -Pri-3 Pri-2
Owner: bklmn@chromium.org
Assigning to Joel per our conversation yesterday. Joel is going to create a mock for what the "Sync disabled by admin" state should look like. It will live here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr63MR-AyU-t-vJzjJoGrl4Ig

Comment 5 by ew...@chromium.org, Feb 28 2018

Cc: scottchen@chromium.org bklmn@chromium.org
Summary: Better UI for "Sync disabled" via Cloud Policy state (was: Wrong error text in user menu)
Joel is working on a mock for this. He'll post it to this bug. It involves updates to both settings and user menu UI. We can start with the user menu updates (since that's in a worse state), and then do the settings updates.

Joel, when you add the mock, please re-assign the bug to Thomas.

Comment 6 by bklmn@chromium.org, Feb 28 2018

Owner: tangltom@chromium.org
Here is a mock for this state. Updated strings and sync badge treatment (color is #BABABA) in user menu. Also not the row changes in settings. 
Screen Shot 2018-02-27 at 4.02.18 PM.png
338 KB View Download

Comment 7 by ew...@chromium.org, Mar 20 2018

Components: -UI>SignIn Services>SignIn
Labels: M-67
Would be nice-to-have for M67, but not a big deal if this slips.
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 20 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Started (was: Available)
Labels: TE-Verified-M68 TE-Verified-68.0.3439.0
Verified this fix on Windows 10 & Mac 10.12.6 with chrome #68.0.3439.0 as per screenshot provided in comment #10 and observed the fix is working as expected.Hence adding TE-Verified labels

Attaching the screen-cast for reference
813498.mp4
586 KB View Download
Note: Unable to Verify this issue on Linux due to lack GPO setup on linux machine.

Comment 13 by ew...@chromium.org, May 24 2018

Can we mark this as Fixed, Thomas?
Status: Fixed (was: Started)
Yes, we can.

Sign in to add a comment