Better UI for "Sync disabled" via Cloud Policy state |
|||||||||||
Issue descriptionSee screenshot. The text in the red button is not right. It should say something similar to what is displayed in the settings page: "Sync disabled by your administrator".
,
Feb 20 2018
Cool, thanks for testing Thomas. If this isn't a regression, we should fix it at some point, but definitely non-blocking.
,
Feb 21 2018
Assigning to myself to get mocks for this
,
Feb 23 2018
Assigning to Joel per our conversation yesterday. Joel is going to create a mock for what the "Sync disabled by admin" state should look like. It will live here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr63MR-AyU-t-vJzjJoGrl4Ig
,
Feb 28 2018
Joel is working on a mock for this. He'll post it to this bug. It involves updates to both settings and user menu UI. We can start with the user menu updates (since that's in a worse state), and then do the settings updates. Joel, when you add the mock, please re-assign the bug to Thomas.
,
Feb 28 2018
Here is a mock for this state. Updated strings and sync badge treatment (color is #BABABA) in user menu. Also not the row changes in settings.
,
Mar 20 2018
Would be nice-to-have for M67, but not a big deal if this slips.
,
Apr 20 2018
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 23 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edccba4e0108a77c868c468c785858927dc0a420 commit edccba4e0108a77c868c468c785858927dc0a420 Author: Thomas Tangl <tangltom@chromium.org> Date: Wed May 23 15:08:46 2018 [Dice] Add sync disabled profile card to the user menu When sync is disabled for the current profile, the user menu shows a sync disabled card on top. Screenshot: https://drive.google.com/file/d/1LiOhCmD2aXZqVxGXq1h62fs2wp5PKIQn/view?usp=sharing Bug: 813498 Change-Id: I6d9155c9e9276af5dae66e8cec02c739246c2298 Reviewed-on: https://chromium-review.googlesource.com/1067924 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#561085} [modify] https://crrev.com/edccba4e0108a77c868c468c785858927dc0a420/chrome/app/generated_resources.grd [modify] https://crrev.com/edccba4e0108a77c868c468c785858927dc0a420/chrome/browser/ui/views/profiles/avatar_button.cc [modify] https://crrev.com/edccba4e0108a77c868c468c785858927dc0a420/chrome/browser/ui/views/profiles/badged_profile_photo.cc [modify] https://crrev.com/edccba4e0108a77c868c468c785858927dc0a420/chrome/browser/ui/views/profiles/badged_profile_photo.h [modify] https://crrev.com/edccba4e0108a77c868c468c785858927dc0a420/chrome/browser/ui/views/profiles/profile_chooser_view.cc
,
May 24 2018
Verified this fix on Windows 10 & Mac 10.12.6 with chrome #68.0.3439.0 as per screenshot provided in comment #10 and observed the fix is working as expected.Hence adding TE-Verified labels Attaching the screen-cast for reference
,
May 24 2018
Note: Unable to Verify this issue on Linux due to lack GPO setup on linux machine.
,
May 24 2018
Can we mark this as Fixed, Thomas?
,
May 24 2018
Yes, we can. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by tangltom@chromium.org
, Feb 19 2018