New issue
Advanced search Search tips

Issue 813480 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

FileManager crashes browser process when there is an empty file with extension m4a

Project Member Reported by joelhockey@chromium.org, Feb 19 2018

Issue description

Create an empty file with file extension m4a

touch /home/chronos/user/Downloads/test.m4a

Now open filemanager (alt-shift-m).  It crashes the browser process.

Fix:

delete the file, or change file extension to something else

 
Owner: joelhockey@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by sashab@chromium.org, Feb 19 2018

Cc: slangley@chromium.org weifangsun@chromium.org
Labels: M-66 OS-Chrome
Assigning to M66 since this is high impact to users. If anyone manages to get an invalid video file into their Downloads folder, it locks up the Chromebook - all renderer processes will crash whenever you open the Files app, with no way of deleting the file.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a23af1e22bf15ca584ee47344800890a83c25943

commit a23af1e22bf15ca584ee47344800890a83c25943
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Feb 21 22:51:58 2018

null check for headers before reading

Creating an empty file in chromeos such as 'test.m4a'
causes FileManager app and browser process to crash
when non-existent headers are dereferenced.

When a file is empty, or headers are not present for any
other reason, length is reported as 0.

Bug:  813480 
Change-Id: Icf261d97834ffd0d9231e342fb539e882ec7eb1a
Reviewed-on: https://chromium-review.googlesource.com/927830
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538234}
[modify] https://crrev.com/a23af1e22bf15ca584ee47344800890a83c25943/extensions/browser/blob_reader.cc

Status: Fixed (was: Started)
Issue 817821 has been merged into this issue.

Sign in to add a comment