Update FilesApp to be able to run in a web page for testing |
|||||||||||||||
Issue descriptionCurrently, the only way to run and test the Files App is in ChromeOS. We could create a much better set of automated tests, as well as speed up development time, if we were able to run the Files App in Chrome as a regular Chrome Packaged App or PWA. We could stub out the required Chrome APIs in Javascript and use this just for testing the front-end. This could also lead to a project to convert the Files App to a PWA, if that's something we wanted. :)
,
Feb 19 2018
,
Feb 26 2018
I've been able to get the filemanager to load in a standard renderer with minor updates to main.html and main_scripts.js. http://crosreview.com/936921 This displays the blank filemanager page. Work is still required to inject some file volumes and files, etc.
,
Feb 26 2018
,
Feb 26 2018
,
Feb 26 2018
,
Feb 28 2018
These issues were slightly different, but we can merge them :) Running a stubbed-out version of the Files App as a webpage is useful for testing. It will never be useful outside of a testing environment. Converting the Files App itself to a PWA would be an alternative to a Chrome App. It would have access to the relevant APIs it needs and potentially be a fully-functioning app. This might be a longer-term goal, since its not clear what the benefits are, or what the long-term goal for apps that come shipped with ChromeOS is (//ash/components maybe?). It might also naturally follow-on from creating a web page first, so let's start with that :)
,
Feb 28 2018
,
Feb 28 2018
,
Mar 1 2018
Weifang - upgrading this to P-1 for M67 as discussed, as it's on the critical path for improving our testing story.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de44755126180ef0a55086444d727b6e5ef83f12 commit de44755126180ef0a55086444d727b6e5ef83f12 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Mar 07 04:49:49 2018 Run CrOS FileManager as a standard webapp for testing. Both background and foreground parts of the app are run in a single renderer. Many chrome.* APIs including chrome.fileManagerPrivate are mocked out to allow the app to run and the existing MockVolumeManager and associated classes provide much of the backing. Script test/scripts/create_test_main.py copies main.html into test/main.html and applies various fixes and injects resources from test/js, and test/css. Run chrome with flag --disable-web-security. Example: ./ui/file_manager/file_manager/test/scripts/create_test_main.py chrome --disable-web-security ui/file_manager/file_manager/test/main.html Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idcbb98d971655ff2e07eead3c19134b9daf98203 Reviewed-on: https://chromium-review.googlesource.com/936921 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#541347} [modify] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/externs/volume_info_list.js [modify] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/file_manager/background/js/volume_info_list_impl.js [modify] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/file_manager/common/js/mock_entry.js [add] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/file_manager/test/.gitignore [add] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/file_manager/test/OWNERS [add] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js [add] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/file_manager/test/js/chrome_file_manager.js [add] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/file_manager/test/js/strings.js [add] https://crrev.com/de44755126180ef0a55086444d727b6e5ef83f12/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7320edd48e37ed5657f5ad45801d1cbed6aef920 commit 7320edd48e37ed5657f5ad45801d1cbed6aef920 Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Mar 09 05:34:33 2018 Set root html overflow: hidden to match apps Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaa6c3f1acb0b6767f491fd437fa58a8764efcdcf Reviewed-on: https://chromium-review.googlesource.com/954802 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#542039} [modify] https://crrev.com/7320edd48e37ed5657f5ad45801d1cbed6aef920/ui/file_manager/file_manager/foreground/css/file_manager.css
,
Mar 14 2018
Design doc: Design at https://docs.google.com/document/d/1zolqdRftCLtg_4r9q50KIjyEVglQ0yqb4L-OgyKfn0I/edit#.
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a04e40f70116e28fef21c459ee5957e190479ff5 commit a04e40f70116e28fef21c459ee5957e190479ff5 Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Mar 15 04:06:56 2018 FileApp MockFileSystem metadata fix Update MockFileSystem.populate to take entries as either strings, or objects include fullPath and metadata. Add additional opt_clear flag to clear all entries before populating. Move MockFileEntry.getMetadata to be on the correct parent class MockEntry to make it available to MockDirectoryEntry. See WebKit/Source/modules/filesystem/Entry.idl Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I820709eb7549bf618163efa189f3d4df40a36353 Reviewed-on: https://chromium-review.googlesource.com/961984 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#543303} [modify] https://crrev.com/a04e40f70116e28fef21c459ee5957e190479ff5/ui/file_manager/file_manager/common/js/mock_entry.js
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52a31949c6cc05ae67c5d37685fa4577dccf23d9 commit 52a31949c6cc05ae67c5d37685fa4577dccf23d9 Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Mar 16 00:07:40 2018 Run integration tests using test/main.html Converted integration_tests/delete.js to test/js/delete.js Copied the parts of integration_tests/test_util.js required for delete.js to test/js/test_util.js and got TestEntryInfo integrated with MockVolumeManager. Added extra API implementations required: - chrome.i18n - chrome.mediaGalleries - window.domAutomationController Added webui_resource_test.js and test_util.js to create script. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie6704f98f8d8c2116c72c2d7a2c22cda246eb0a0 Reviewed-on: https://chromium-review.googlesource.com/961986 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543564} [add] https://crrev.com/52a31949c6cc05ae67c5d37685fa4577dccf23d9/ui/file_manager/file_manager/test/BUILD.gn [add] https://crrev.com/52a31949c6cc05ae67c5d37685fa4577dccf23d9/ui/file_manager/file_manager/test/delete.js [modify] https://crrev.com/52a31949c6cc05ae67c5d37685fa4577dccf23d9/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js [modify] https://crrev.com/52a31949c6cc05ae67c5d37685fa4577dccf23d9/ui/file_manager/file_manager/test/js/chrome_file_manager.js [modify] https://crrev.com/52a31949c6cc05ae67c5d37685fa4577dccf23d9/ui/file_manager/file_manager/test/js/strings.js [add] https://crrev.com/52a31949c6cc05ae67c5d37685fa4577dccf23d9/ui/file_manager/file_manager/test/js/test_util.js [modify] https://crrev.com/52a31949c6cc05ae67c5d37685fa4577dccf23d9/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6338bb14b48d30838391e0b2519f709e366e2df commit c6338bb14b48d30838391e0b2519f709e366e2df Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Mar 16 04:18:08 2018 CrOS FileManager UI Test Runs UI tests for CrOS FileManager using test/main.html. Added //ui/file_manager/file_manager/test:create_test_main as dep for chrome/browser/chromeos:test_support to ensure that test/main.html is generated for chromeos browser_tests. Bug: 813477 Tbr: fukino@chromium.org Change-Id: Icccc53c724e5af79f4fd4412e3e1f03e6515b3e9 Reviewed-on: https://chromium-review.googlesource.com/965542 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543620} [modify] https://crrev.com/c6338bb14b48d30838391e0b2519f709e366e2df/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/c6338bb14b48d30838391e0b2519f709e366e2df/chrome/browser/chromeos/file_manager/file_manager_uitest.cc [modify] https://crrev.com/c6338bb14b48d30838391e0b2519f709e366e2df/chrome/test/BUILD.gn
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/041865f67deb38da2f484ccdeefd5acd8935166a commit 041865f67deb38da2f484ccdeefd5acd8935166a Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Mar 22 09:55:24 2018 CrOS FilesApp move test/main.html to test.html Change to use test.html rather than test/main.html. Having the file in the regular dir makes it much better for many files that load other resources assuming that relative paths of 'foreground/foo/bar' will be valid. This has simplified the create_test_main.py script. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I388b3a914fde3cc99b76503251cbf6ffdd659e81 Reviewed-on: https://chromium-review.googlesource.com/972222 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#545029} [modify] https://crrev.com/041865f67deb38da2f484ccdeefd5acd8935166a/chrome/browser/chromeos/file_manager/file_manager_uitest.cc [add] https://crrev.com/041865f67deb38da2f484ccdeefd5acd8935166a/ui/file_manager/file_manager/.gitignore [delete] https://crrev.com/b62383e306aeeadfd8c19f99f6a8491d8d446bc4/ui/file_manager/file_manager/test/.gitignore [modify] https://crrev.com/041865f67deb38da2f484ccdeefd5acd8935166a/ui/file_manager/file_manager/test/js/test_util.js [modify] https://crrev.com/041865f67deb38da2f484ccdeefd5acd8935166a/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a867e71f96c95bac748270746e1b1fbfa781515 commit 5a867e71f96c95bac748270746e1b1fbfa781515 Author: Noel Gordon <noel@chromium.org> Date: Mon Mar 26 10:11:44 2018 Fix script typo in create_test_main.py Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idaaf4fbc6d0217b5e0e817f8953095ae5d45e707 Reviewed-on: https://chromium-review.googlesource.com/979744 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#545752} [modify] https://crrev.com/5a867e71f96c95bac748270746e1b1fbfa781515/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Mar 28 2018
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d5277c33bb3d019267dae02294fd7995c981201 commit 7d5277c33bb3d019267dae02294fd7995c981201 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Mar 28 05:39:45 2018 Add deps for ui/file_manager/file_manager/test:create_test_main. Tbr: lucmult@chromium.org Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4e97869ff672fbcaba809d13ddf4e665056e30da Reviewed-on: https://chromium-review.googlesource.com/983081 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#546420} [modify] https://crrev.com/7d5277c33bb3d019267dae02294fd7995c981201/ui/file_manager/file_manager/test/BUILD.gn [modify] https://crrev.com/7d5277c33bb3d019267dae02294fd7995c981201/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Apr 6 2018
https://chromium-review.googlesource.com/c/chromium/src/+/999240/3/ui/file_manager/file_manager/test/js/chrome_file_manager.js Other developers have to maintain these chrome.* api mocks, FTR.
,
Apr 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3 commit 22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3 Author: Joel Hockey <joelhockey@chromium.org> Date: Sun Apr 08 23:38:21 2018 FilesApp add support for QuickView in test.html Add support in chrome.fileManagerPrivate.getFileTasks to return file task 'view-in-browser' for a single text file. This is required by QuickView to determine that a text file can be shown. Change QuickView-related files to use iframe rather than webview. Note that this change is only used for testing parts of the UI. Production code is unchanged and still uses webview for security. Put files_quick_view.html path in constants so that it can be overriden in test to use version of file with iframe vs webview. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5b8666a646ce979a99f065aa44a5c802b5420a32 Reviewed-on: https://chromium-review.googlesource.com/968102 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#549093} [modify] https://crrev.com/22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3/ui/file_manager/file_manager/foreground/js/constants.js [modify] https://crrev.com/22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3/ui/file_manager/file_manager/foreground/js/quick_view_controller.js [modify] https://crrev.com/22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3/ui/file_manager/file_manager/test/js/chrome_file_manager.js [modify] https://crrev.com/22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3/ui/file_manager/file_manager/test/js/strings.js [modify] https://crrev.com/22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3/ui/file_manager/file_manager/test/js/test_util.js [modify] https://crrev.com/22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Apr 8 2018
In response to #c21, only developers making changes to FileApp UI need to maintain the test implementations. In this particular instance, there is no need to add the openSettingsSubpage function since it is never called in any tests. Perhaps having the method stubbed out has made the test.html page helpful in development?
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d4399921b44c7b187022da0b02a23b2d2db8275 commit 8d4399921b44c7b187022da0b02a23b2d2db8275 Author: Joel Hockey <joelhockey@chromium.org> Date: Mon Apr 09 01:37:45 2018 CrOS FileApp remove unneeded test/OWNERS Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I96d3d4d4e6743ca584efff7b9e9b4712d4d198de Reviewed-on: https://chromium-review.googlesource.com/1002212 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#549094} [delete] https://crrev.com/22bb0f8b4e1a9ee17bc14e9c31bb42bd8d4239b3/ui/file_manager/file_manager/test/OWNERS
,
Apr 9 2018
#24 >In response to #c21, only developers making changes to FileApp UI need to maintain the test implementations. https://chromium-review.googlesource.com/c/chromium/src/+/999240/ is changing the FilesApp UI, and also adds a new method to file_manager_private.idl.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08a6c84c9bcb247fda0e332bdc3b3b75d146dbb4 commit 08a6c84c9bcb247fda0e332bdc3b3b75d146dbb4 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Apr 11 10:09:21 2018 Add webkit.webprefs.javascript_can_access_clipboard This pref is already defined, but is not able to be set in <user-data-dir>/Default/Preferences. It is used often in conjunction with webkit.webprefs.dom_paste_enabled, and it is helpful to be able to set both during development with either cmdline switch or in prefs file. This field was added in CL https://chromium.googlesource.com/chromium/src/+/a4898ce4a26204138b0e47e1fb6ac59eeb00e1c8%5E%21/ Bug: 813477 Change-Id: I61769ca8fbd989b5833717d53c8cd2495d05028c Reviewed-on: https://chromium-review.googlesource.com/1006561 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#549845} [modify] https://crrev.com/08a6c84c9bcb247fda0e332bdc3b3b75d146dbb4/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/08a6c84c9bcb247fda0e332bdc3b3b75d146dbb4/chrome/browser/ui/prefs/prefs_tab_helper.cc [modify] https://crrev.com/08a6c84c9bcb247fda0e332bdc3b3b75d146dbb4/chrome/common/pref_names.cc [modify] https://crrev.com/08a6c84c9bcb247fda0e332bdc3b3b75d146dbb4/chrome/common/pref_names.h
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f03dffa0272948637274b9441ed2b25c29e69583 commit f03dffa0272948637274b9441ed2b25c29e69583 Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Apr 19 04:42:59 2018 Change repeatUntil to repeat immediately for the first 3 loops Most things that we repeat for will happen within 2 or 3 executions of the event loop so we can save time and run tests faster by not delaying for the first 3. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic0808a10d5cb02e1bd2f20c66320a2d3655c8884 Reviewed-on: https://chromium-review.googlesource.com/1007115 Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551945} [modify] https://crrev.com/f03dffa0272948637274b9441ed2b25c29e69583/ui/file_manager/file_manager/test/js/test_util.js
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/349171ef2357c024bb84faa43d842e52141b20ff commit 349171ef2357c024bb84faa43d842e52141b20ff Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Apr 20 01:44:51 2018 Add better console output to webui_resource_test.js Console shows which test is running, and test status PASS/FAIL and time that each test takes, as well as overall status and time for all tests. This information makes it easier to determine which test fails when there are multiple tests running and one of them times out. Currently webui_resource_test.js is used for FilesApp unit tests and in the FileManagerUITest browser test. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie42d5dcdf678371e1a3692f1764f2d18533da3f2 Reviewed-on: https://chromium-review.googlesource.com/1007114 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#552227} [modify] https://crrev.com/349171ef2357c024bb84faa43d842e52141b20ff/ui/webui/resources/js/webui_resource_test.js
,
May 21 2018
,
May 22 2018
Temp re-open to land a UI test removal here.
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf5305fc4a766d82a53bc1ac27db04693f809360 commit cf5305fc4a766d82a53bc1ac27db04693f809360 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 22 02:00:25 2018 FilesApp remove redundant UI tests Removing create_new_folder.js and delete.js tests which were copied from FileManagerBrowserTests / integration_tests. These tests were disabled at the time in FileManagerBrowserTests, but are now running. This version is redundant and can be deleted. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie279ea0c032c86c1e08f6e92525014cb5df6f846 Reviewed-on: https://chromium-review.googlesource.com/1067523 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#560458} [delete] https://crrev.com/7dc0ff470efdfb2f27f3e43b909f0839f4542a8f/ui/file_manager/file_manager/test/create_new_folder.js [delete] https://crrev.com/7dc0ff470efdfb2f27f3e43b909f0839f4542a8f/ui/file_manager/file_manager/test/delete.js
,
May 22 2018
,
May 22 2018
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/427d98bc421eb322689f6eccbf756b7b91b93c74 commit 427d98bc421eb322689f6eccbf756b7b91b93c74 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 22 04:34:14 2018 FilesApp UI tests README update Removed comment about experimental and dependencies which may sound alarming. These tests are quite similar to the other existing unit tests. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3fc797a929aa0f3a2861371ec1aa29828980b0cb Reviewed-on: https://chromium-review.googlesource.com/1068297 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#560482} [modify] https://crrev.com/427d98bc421eb322689f6eccbf756b7b91b93c74/ui/file_manager/file_manager/test/README
,
May 22 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef1c7e05752e5c9b07481ac3eb0328a27a59a0aa commit ef1c7e05752e5c9b07481ac3eb0328a27a59a0aa Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Jun 06 06:46:41 2018 Continue running next test when async test throws error Currently async tests end up timing out when they call assert but don't catch the resulting exception and call done(true). It seems more natural that when an async test has an assertion failure, that the harness should catch the exception and take care of continuing tests. The alternative that async tests should catch there own errors has the drawback that specific errors are not ever reported. E.g. code below is bad. testAsync(done) { try { assertEquals('foo', 'bar', 'foo should match bar'); done(); } catch (err) { done(true) } } Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idbc88f94f6055eec37ab0d90b4b8d423fba6eb3f Reviewed-on: https://chromium-review.googlesource.com/1088327 Reviewed-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#564806} [modify] https://crrev.com/ef1c7e05752e5c9b07481ac3eb0328a27a59a0aa/ui/webui/resources/js/webui_resource_test.js
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a86c7443ea4266d02305f11a1a3dfbc616bc93b commit 7a86c7443ea4266d02305f11a1a3dfbc616bc93b Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Jun 12 02:21:14 2018 Pass optional testScope to runTests rather than using global 'window' Currently tests (functions named textXXX) are found in the global 'window' scope. This change allows caller to pass an optional scope which contains tests. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia8bebc8019748ab2452fa3cac438c883b7a75f21 Reviewed-on: https://chromium-review.googlesource.com/1094514 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566276} [modify] https://crrev.com/7a86c7443ea4266d02305f11a1a3dfbc616bc93b/ui/webui/resources/js/webui_resource_test.js
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74817954ceee794309f6f376019239b14e2245f0 commit 74817954ceee794309f6f376019239b14e2245f0 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Jun 12 08:13:36 2018 FilesApp UI Tests allow multiple tests from gen dir * Run from gen/ui/file_manager/file_manager/test.html when testing on the bots rather than src. The change here is for the create_test_main.py script to use correct relative paths from gen dir for resources that are loaded. * Group tests into multiple scopes to be run separately. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia9a354ea6cf7a6f765fb0cdf73d7041a8286e1ec Reviewed-on: https://chromium-review.googlesource.com/1092212 Reviewed-by: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566356} [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/chrome/browser/chromeos/file_manager/file_manager_uitest.cc [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/chrome/test/BUILD.gn [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/ui/file_manager/file_manager/test/BUILD.gn [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/ui/file_manager/file_manager/test/README [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/ui/file_manager/file_manager/test/check_select.js [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/ui/file_manager/file_manager/test/crostini.js [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/ui/file_manager/file_manager/test/js/test_util.js [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/ui/file_manager/file_manager/test/scripts/create_test_main.py [modify] https://crrev.com/74817954ceee794309f6f376019239b14e2245f0/ui/file_manager/file_manager/test/uma.js
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f3d5c1816466057d8a23cf1317a56fe8e3dda2c commit 5f3d5c1816466057d8a23cf1317a56fe8e3dda2c Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Jun 13 00:51:27 2018 Fix quick-view path Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iba58be17fcb5b5150677c535f5affd43d3b452c9 Reviewed-on: https://chromium-review.googlesource.com/1096932 Reviewed-by: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566663} [modify] https://crrev.com/5f3d5c1816466057d8a23cf1317a56fe8e3dda2c/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27c6768e03b5e6fb190ece5e0bb68b60240cad5a commit 27c6768e03b5e6fb190ece5e0bb68b60240cad5a Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Jun 14 03:58:10 2018 FilesApp UI test rename file, add test.Event Renamed chrome_file_manager.js to chrome_file_manager_private_test_impl.js to make it clearer that the file is for testing. Added test.Event to be used for all fmp events. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7804480dd27f113005346a049242948c01666f08 Reviewed-on: https://chromium-review.googlesource.com/1100135 Reviewed-by: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#567123} [modify] https://crrev.com/27c6768e03b5e6fb190ece5e0bb68b60240cad5a/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js [rename] https://crrev.com/27c6768e03b5e6fb190ece5e0bb68b60240cad5a/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js [modify] https://crrev.com/27c6768e03b5e6fb190ece5e0bb68b60240cad5a/ui/file_manager/file_manager/test/js/test_util.js [modify] https://crrev.com/27c6768e03b5e6fb190ece5e0bb68b60240cad5a/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e406b0dbadf2de3f754bce650332da711dce7863 commit e406b0dbadf2de3f754bce650332da711dce7863 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Jun 19 06:01:08 2018 FilesApp UI test create script set all sources Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ief0de1355199f9cc69e296f117d93adf4e771206 Reviewed-on: https://chromium-review.googlesource.com/1104620 Reviewed-by: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#568354} [modify] https://crrev.com/e406b0dbadf2de3f754bce650332da711dce7863/ui/file_manager/file_manager/test/BUILD.gn [modify] https://crrev.com/e406b0dbadf2de3f754bce650332da711dce7863/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f559f346bf46b80402d2d84b94ff02a56c5b809 commit 0f559f346bf46b80402d2d84b94ff02a56c5b809 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Jun 27 06:03:04 2018 FilesApp compile UI test JS files * Add BUILD rules to include UI test JS files in closure compilation to help detect type-related errors during compilation phase. * Also including webui_resource_test and test_util_base files which are used by UI tests. * Minor fixes to various files detected by closure compiler. Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I88a798806e732e2d2b35a2685fb954610560b71b Reviewed-on: https://chromium-review.googlesource.com/1114677 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#570673} [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/BUILD.gn [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/externs/background/file_browser_background.js [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/file_manager/background/js/BUILD.gn [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/file_manager/test/BUILD.gn [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/file_manager/test/crostini.js [add] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/file_manager/test/js/BUILD.gn [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js [add] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/file_manager/test/js/externs.js [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/file_manager/file_manager/test/js/test_util.js [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/webui/resources/js/BUILD.gn [add] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/webui/resources/js/dom_automation_controller.js [modify] https://crrev.com/0f559f346bf46b80402d2d84b94ff02a56c5b809/ui/webui/resources/js/webui_resource_test.js
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea5050f1bb798a30652391b9ee7c2f8ce62fbdc9 commit ea5050f1bb798a30652391b9ee7c2f8ce62fbdc9 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Jun 27 07:01:10 2018 FilesApp UI Tests add android strings and team drive setup This fixes some console errors that were showing and catches up with recent changes. Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I37c2a0f39a01727da5860b1df2c79ec293e1ffea Reviewed-on: https://chromium-review.googlesource.com/1116399 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#570679} [modify] https://crrev.com/ea5050f1bb798a30652391b9ee7c2f8ce62fbdc9/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js [modify] https://crrev.com/ea5050f1bb798a30652391b9ee7c2f8ce62fbdc9/ui/file_manager/file_manager/test/js/strings.js
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a88423acf98f847db5ceddb483090949ea11f310 commit a88423acf98f847db5ceddb483090949ea11f310 Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Jun 29 06:41:42 2018 FilesApp UITest populate team_drives to stop console errors Fixes Error: webkitResolveLocalFileSystemURL not found: [filesystem:drive/team_drives] Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6979d279f6986dba4ff5cb0ee6ac63b8f4594bfd Reviewed-on: https://chromium-review.googlesource.com/1119733 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#571410} [modify] https://crrev.com/a88423acf98f847db5ceddb483090949ea11f310/ui/file_manager/file_manager/test/js/test_util.js
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4812c4e7a02aa176aa1f53bbc8412363515cc733 commit 4812c4e7a02aa176aa1f53bbc8412363515cc733 Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Jun 29 08:38:39 2018 FilesApp fix DOMException: Failed to execute 'removeChild' on 'Node' Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iafe64af611275d2a434ad533c3c615a9ccb8abf5 Reviewed-on: https://chromium-review.googlesource.com/1119739 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#571425} [modify] https://crrev.com/4812c4e7a02aa176aa1f53bbc8412363515cc733/ui/webui/resources/js/cr/ui/dialogs.js
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74754a8586cd7bee2275b457d5aed53b697521b0 commit 74754a8586cd7bee2275b457d5aed53b697521b0 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Aug 15 03:27:52 2018 Cros FilesApp ui test fixes Change 'background-color:white' to apply to outer webview/iframe element rather than inner body so that test page picks this up. Add missing string. Bug: 813477 Change-Id: I69d4827e4ec5dd4cc40b1ad229c6c8afd6e2254d Reviewed-on: https://chromium-review.googlesource.com/1174578 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#583147} [modify] https://crrev.com/74754a8586cd7bee2275b457d5aed53b697521b0/ui/file_manager/file_manager/foreground/elements/files_quick_view.css [modify] https://crrev.com/74754a8586cd7bee2275b457d5aed53b697521b0/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/74754a8586cd7bee2275b457d5aed53b697521b0/ui/file_manager/file_manager/foreground/elements/files_safe_text_webview_content.css [modify] https://crrev.com/74754a8586cd7bee2275b457d5aed53b697521b0/ui/file_manager/file_manager/test/js/strings.js
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7492cbb3c87c15a7a17b9d228a726a8e615131a commit e7492cbb3c87c15a7a17b9d228a726a8e615131a Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Sep 07 05:45:38 2018 CrOS FilesApp: refactor strings to allow reuse in tests Created static FileManagerPrivateStrings::GetStrings() which is called by fileManagerPrivate.getStrings() extension function, and can now also be called by utility executable to generate strings.js file for testing rather than having strings duplicated. Bug: 813477 Change-Id: Ife2ac1b018660451a8c32180e5260f1d9fb6baf2 Reviewed-on: https://chromium-review.googlesource.com/1208993 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#589442} [modify] https://crrev.com/e7492cbb3c87c15a7a17b9d228a726a8e615131a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/e7492cbb3c87c15a7a17b9d228a726a8e615131a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.h [add] https://crrev.com/e7492cbb3c87c15a7a17b9d228a726a8e615131a/chrome/browser/chromeos/extensions/file_manager/test/BUILD.gn [add] https://crrev.com/e7492cbb3c87c15a7a17b9d228a726a8e615131a/chrome/browser/chromeos/extensions/file_manager/test/file_manager_strings.cc [modify] https://crrev.com/e7492cbb3c87c15a7a17b9d228a726a8e615131a/ui/file_manager/file_manager/test/BUILD.gn [modify] https://crrev.com/e7492cbb3c87c15a7a17b9d228a726a8e615131a/ui/file_manager/file_manager/test/js/strings.js [modify] https://crrev.com/e7492cbb3c87c15a7a17b9d228a726a8e615131a/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c39dc317116707105c570ec750f2accd2ec227a6 commit c39dc317116707105c570ec750f2accd2ec227a6 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Sep 07 07:17:08 2018 Revert "CrOS FilesApp: refactor strings to allow reuse in tests" This reverts commit e7492cbb3c87c15a7a17b9d228a726a8e615131a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 589442 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U3NDkyY2JiM2M4N2MxNWE3YTE3YjlkMjI4YTcyNmE4ZTYxNTEzMWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/40795 Sample Failed Step: compile Original change's description: > CrOS FilesApp: refactor strings to allow reuse in tests > > Created static FileManagerPrivateStrings::GetStrings() which is called > by fileManagerPrivate.getStrings() extension function, and can now also > be called by utility executable to generate strings.js file for > testing rather than having strings duplicated. > > Bug: 813477 > Change-Id: Ife2ac1b018660451a8c32180e5260f1d9fb6baf2 > Reviewed-on: https://chromium-review.googlesource.com/1208993 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589442} Change-Id: I4b29ee18d2a663e08108aaf796bcae2aa0728d9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 813477 Reviewed-on: https://chromium-review.googlesource.com/1212486 Cr-Commit-Position: refs/heads/master@{#589450} [modify] https://crrev.com/c39dc317116707105c570ec750f2accd2ec227a6/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/c39dc317116707105c570ec750f2accd2ec227a6/chrome/browser/chromeos/extensions/file_manager/private_api_strings.h [delete] https://crrev.com/799e7f9f1c40439ed33c66f4a4e3adc20d452345/chrome/browser/chromeos/extensions/file_manager/test/BUILD.gn [delete] https://crrev.com/799e7f9f1c40439ed33c66f4a4e3adc20d452345/chrome/browser/chromeos/extensions/file_manager/test/file_manager_strings.cc [modify] https://crrev.com/c39dc317116707105c570ec750f2accd2ec227a6/ui/file_manager/file_manager/test/BUILD.gn [modify] https://crrev.com/c39dc317116707105c570ec750f2accd2ec227a6/ui/file_manager/file_manager/test/js/strings.js [modify] https://crrev.com/c39dc317116707105c570ec750f2accd2ec227a6/ui/file_manager/file_manager/test/scripts/create_test_main.py
,
Sep 10
,
Sep 13
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by sashab@chromium.org
, Feb 19 2018