New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813465 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Draw inline settings animation from the correct point on notification list

Project Member Reported by megumihattori@google.com, Feb 19 2018

Issue description

Chrome Version: Chrome Version: ToT (771152fe56a6d6bd53f0cbd63a5db8a71b1c838d)

What steps will reproduce the problem?
(1) Generate a web notification at https://tests.peter.sh/notification-generator/
(2) Click the "1" button on the bottom bar of the screen in order to open the notification list
(3) Click the gear icon on the notification

What is the expected result?
Draw inline settings animation from a point where the mouse was clicked.

What happens instead?
Draw inline settings animation from the bottom-right corner of the notification

 
Owner: megumihattori@google.com
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61797c02d95072344d02f6a290cdda6ccc9c8f39

commit 61797c02d95072344d02f6a290cdda6ccc9c8f39
Author: Megumi Hattori <megumihattori@google.com>
Date: Tue Feb 20 03:23:22 2018

Fix stating point for drawing inline settings animation.

When a gear icon for the inline settings is clicked, the animation
should be drwan from the point where the mouse is cliked. However, if
notifications are shown on MessageCenterView, the animation is not
drawn from the correct point. This CL Fixes the stating point for
drawing animation.

BUG= 813465 

Change-Id: Ic903b86abfd31f0da80b931f5f68234c47c7ac33
Reviewed-on: https://chromium-review.googlesource.com/923689
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Cr-Commit-Position: refs/heads/master@{#537704}
[modify] https://crrev.com/61797c02d95072344d02f6a290cdda6ccc9c8f39/ui/message_center/views/notification_view_md.cc

Status: Fixed (was: Started)

Sign in to add a comment