New issue
Advanced search Search tips

Issue 813463 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Bug Regression: Text on the tab is partially cropped/removed.

Project Member Reported by vamshi.kommuri@chromium.org, Feb 19 2018

Issue description

Chrome Version: 66.0.3350.0
OS: Windows

What steps will reproduce the problem?
(1)Open any/few tabs in chrome 66.0.3350.0
(2)Observe the missing/cropped text on the tab.

What is the expected result?
Text to be visible.

What happens instead?
Text is cropped

Note: Will provide the bisect info soon.

 
Bisect Range:
===================
Last Good Build: 66.0.3349.0
First Bad Build: 66.0.3350.0

Note: Facing an exception error while running gsutil command. 
Attaching the screenshots of the Good and Bad behaviour for reference.

Thanks! 
Good-813463.PNG
43.5 KB View Download
Bad-813463.PNG
39.7 KB View Download
Labels: -Pri-3 ReleaseBlock-Stable RegressedIn-66 M-66 FoundIn-66 Target-66 ET-HYD-Reported hasbisect Pri-1
Owner: malaykeshav@chromium.org
Status: Assigned (was: Untriaged)
Change log:
=============
https://chromium.googlesource.com/chromium/src/+/21620f905fe7cf72d23c16e170e3f9c8018ed0a1

Suspecting the same.
Review URL:  https://chromium-review.googlesource.com/922454

@malaykeshav: Please help in re-assigning it to others if not related to your change. 

Note: Adding RB-stable as this is a recent regression. Currently we don't have proper set-up for tool bisect in HighDPI machine, hence provided with manual Change Log.

Thanks!
Cc: pkasting@chromium.org
Status: Started (was: Assigned)
The scale on clip path only needs to be applied when Pixel Canvas is enabled. Which is not yet the case for Windows. 
Uploading a patch.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51706e1cfa0c8f3b26be99a7d4de4ffaf908f673

commit 51706e1cfa0c8f3b26be99a7d4de4ffaf908f673
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Tue Feb 20 20:56:58 2018

Use paint recording scale factor instead of device scale factor

The paint recording scale factor is set to 1 when pixel canvas is
disabled. We cannot use the value of PaintContext::device_scale_factor
for the recording scale factor in such cases.

Bug:  813463 
Change-Id: If51bfde2e271ce863cf3971016ee6347cbce592a
Component: Tabs, Clipping, Scaling
Reviewed-on: https://chromium-review.googlesource.com/927182
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537876}
[modify] https://crrev.com/51706e1cfa0c8f3b26be99a7d4de4ffaf908f673/chrome/browser/ui/views/tabs/tab.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M66 TE-Verified-66.0.3352.0
Verified the fix on Windows 10 using latest chrome version #66.0.3352.0 as per the comment #0.
Attaching screen shot for reference.
Observed that the text and favicon rendered properly on the tabs without any crop.
Hence, the fix is working as expected.
Note: Able to reproduce the issue on reported chrome version. 
Adding the verified labels.

Thanks...!!
CL 813463.PNG
190 KB View Download

Comment 8 by cnardi@chromium.org, Feb 27 2018

 Issue 816553  has been merged into this issue.

Sign in to add a comment