keyboard_unittest crashes when running all tests. |
||
Issue descriptionIt also crashes when "--single_process_tests" is enabled. ---- trace ---- [14/27] NotificationManagerTest.DoesItConsolidate (0 ms) [130620:130627:0219/112950.463261:844225069313:ERROR:kill_posix.cc(84)] Unable to terminate process group 130630: No such process (3) [15/27] KeyboardControllerTest.AlwaysVisibleWhenLocked (192 ms) [ RUN ] KeyboardControllerTest.CloseKeyboard [130630:130630:0219/112950.307015:844224913046:FATAL:env.cc(177)] Check failed: gfx::ClientNativePixmapFactory::GetInstance(). #0 0x7fb773812dfd base::debug::StackTrace::StackTrace() #1 0x7fb77381142c base::debug::StackTrace::StackTrace() #2 0x7fb773892a2d logging::LogMessage::~LogMessage() #3 0x7fb7725da94c aura::Env::Init() #4 0x7fb7725da7c1 aura::Env::CreateInstance() #5 0x0000009934d7 aura::test::AuraTestHelper::SetUp() #6 0x000000441690 keyboard::KeyboardControllerTest::SetUp() #7 0x0000004c6bfe testing::internal::HandleSehExceptionsInMethodIfSupported<>() #8 0x0000004b6fa2 testing::internal::HandleExceptionsInMethodIfSupported<>() #9 0x0000004a1794 testing::Test::Run() #10 0x0000004a21cd testing::TestInfo::Run() #11 0x0000004a2c7c testing::TestCase::Run() #12 0x0000004aefde testing::internal::UnitTestImpl::RunAllTests() #13 0x0000004c6c8e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #14 0x0000004b8732 testing::internal::HandleExceptionsInMethodIfSupported<>() #15 0x0000004aebe9 testing::UnitTest::Run() #16 0x00000093a831 RUN_ALL_TESTS() #17 0x00000093773b base::TestSuite::Run() #18 0x0000004506ed _ZN4base8internal13FunctorTraitsIMNS_9TestSuiteEFivEvE6InvokeIPN12_GLOBAL__N_117KeyboardTestSuiteEJEEEiS4_OT_DpOT0_ #19 0x000000450634 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMNS_9TestSuiteEFivEJPN12_GLOBAL__N_117KeyboardTestSuiteEEEEiOT_DpOT0_ #20 0x0000004505e5 _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIN12_GLOBAL__N_117KeyboardTestSuiteEEEEEEFivEE7RunImplIRKS5_RKNSt3__15tupleIJS9_EEEJLm0EEEEiOT_OT0_NSG_16integer_sequenceImJXspT1_EEEE #21 0x00000045052c _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIN12_GLOBAL__N_117KeyboardTestSuiteEEEEEEFivEE3RunEPNS0_13BindStateBaseE #22 0x00000094118d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #23 0x000000941e0f base::(anonymous namespace)::LaunchUnitTestsInternal() #24 0x000000941ca5 base::LaunchUnitTests() #25 0x000000450096 main #26 0x7fb76e1bc2b1 __libc_start_main #27 0x00000042f89a _start [16/27] KeyboardControllerTest.CloseKeyboard (CRASHED)
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d963ed9d96274fe198ede650a55b8951a184b57b commit d963ed9d96274fe198ede650a55b8951a184b57b Author: Yuichiro Hanada <yhanada@chromium.org> Date: Thu Feb 22 04:11:37 2018 Fix crashes in keyboard_unittests. - Creatig aura::Env in TestSuite::Initialize() instead of SetUp in each test case. - Using AuraTestBase instead of using AuraTestHelper directly in KeyboardControllerTest. Bug: 813453 Test: Run unit tests 100 times. Change-Id: I3bebc9a8fc7a132c36f4fb182bc2739848e30007 Reviewed-on: https://chromium-review.googlesource.com/928446 Reviewed-by: Blake O'Hare <blakeo@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#538345} [modify] https://crrev.com/d963ed9d96274fe198ede650a55b8951a184b57b/ui/keyboard/keyboard_controller_unittest.cc [modify] https://crrev.com/d963ed9d96274fe198ede650a55b8951a184b57b/ui/keyboard/test/run_all_unittests.cc
,
Feb 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by yhanada@chromium.org
, Feb 21 2018