Some WebUIs should be disabled in guest mode |
|||||||||||||||
Issue descriptionchrome://history and chrome://bookmarks (and possibly others) have their shortcuts disabled in Guest mode, but typing the URLs still goes to the page. The WebUIs should be completely unavailable in Guest mode on desktop, as in ChromeOS.
,
Apr 9 2018
,
Apr 13 2018
Summarizing discussion at https://chromium-review.googlesource.com/c/chromium/src/+/1005724. The current plan is to create a common page to be shown when a WebUI page is not available in Guest mode. C++ UI classes will serve the alternate page when in Guest mode. @aee: We should involve UX to provide us with a mock for the page. As a start, I suggest using the most plain page possible (just a message with a background color).
,
Apr 13 2018
Also, perhaps we can consider branching off to the alternate page as early as possible, within the web_ui_controller_factory itself, see https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc?l=421.
,
Apr 13 2018
@namratakannan: for extensions, we currently load the extensions page with many of the elements hidden. We're thinking about creating a common WebUI page not available for guests page that can be used for history and bookmarks. What are your thoughts on that? If this approach seems reasonable, can you provide mock for a page like that? I'll start implementing something like guest_webui_page.png to be rendered in place of bookmarks when in guest mode.
,
Apr 13 2018
guest_webui_page.png seems fine to me. Just a thought: Maybe the page could look less like a page (no blue bar), and look more like an error message, for example similar to chrome://dino.
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8948e4345bb7b09d205745074137daf4922af05f commit 8948e4345bb7b09d205745074137daf4922af05f Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Apr 18 23:52:15 2018 Settings UI: create page-not-available for history and bookmarks in guest-mode Bug: 813451 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I45095ecfdf54ccbbd1a9b8fac5304f829faf2b55 Reviewed-on: https://chromium-review.googlesource.com/1014404 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#551883} [modify] https://crrev.com/8948e4345bb7b09d205745074137daf4922af05f/chrome/app/settings_strings.grdp [modify] https://crrev.com/8948e4345bb7b09d205745074137daf4922af05f/chrome/browser/browser_resources.grd [add] https://crrev.com/8948e4345bb7b09d205745074137daf4922af05f/chrome/browser/resources/page_not_available_for_guest/app.html [modify] https://crrev.com/8948e4345bb7b09d205745074137daf4922af05f/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/8948e4345bb7b09d205745074137daf4922af05f/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [add] https://crrev.com/8948e4345bb7b09d205745074137daf4922af05f/chrome/browser/ui/webui/page_not_available_for_guest/page_not_available_for_guest_ui.cc [add] https://crrev.com/8948e4345bb7b09d205745074137daf4922af05f/chrome/browser/ui/webui/page_not_available_for_guest/page_not_available_for_guest_ui.h
,
Apr 19 2018
,
Apr 20 2018
Able to reproduce this issue on Windows 10, Mac OS 10.12.6 and Ubuntu 14.04 on the build without fix 68.0.3400.0 and the issue is fixed on the latest Canary 68.0.3401.0. In guest mode, on navigating to chrome://history and chrome://bookmarks, can see the message "Bookmarks/History is not available to Guest users. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Apr 21 2018
- The bookmark manager shows "Bookmarks is not available in Guest mode." I think that "Bookmarking is not available in Guest mode." might be better (you can't bookmark, not that you can't access your bookmarks). - Flags can still be changed in Guest mode (see 798660 for more on that). - The extensions page is styled completely differently from bookmarks and history. It offers to take you to the Chrome Web Store (even though you won't be able to install anything from there), and also has a weird "No search results found" string, even though no search was done. - The history page shows "History is not available to Guest users." |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by aee@chromium.org
, Mar 28 2018