New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813446 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 771643



Sign in to add a comment

Null-dereference READ in blink::SVGForeignObjectPainter::Paint

Project Member Reported by ClusterFuzz, Feb 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6251247875915776

Fuzzer: miaubiz_svg_fuzzer
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000000068
Crash State:
  blink::SVGForeignObjectPainter::Paint
  blink::LayoutSVGForeignObject::Paint
  blink::BoxPainter::PaintChildren
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=537450:537464

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6251247875915776

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 18 2018

Components: Blink>Paint Blink>SVG
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: brajkumar@chromium.org
Labels: -Type-Bug M-66 Test-Predator-Wrong Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.

From the below CL observing some changes related to 'SVGForeignObjectPainter.cpp' hence suspecting the same
https://chromium.googlesource.com/chromium/src/+/0a9a5c311a1d3a298f952e495510bd6fe3faa2f6

wangxianzhu@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Blocking: 771643
Cc: vmp...@chromium.org trchen@chromium.org f...@opera.com
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6a82fc1c8b43938da813697c723c1db6834482b

commit f6a82fc1c8b43938da813697c723c1db6834482b
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 22 19:36:38 2018

[SPv175] Don't crash on circular filter reference containing foreignObject or svg-in-svg

This is a workaround for the crash bugs. The root cause is tracked
in crbug.com/814815.

Bug:  813446 ,  813411 , 814815
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ied370eb2b1f0ffd4424c9c397ea1c899914bdbb0
Reviewed-on: https://chromium-review.googlesource.com/931922
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538527}
[add] https://crrev.com/f6a82fc1c8b43938da813697c723c1db6834482b/third_party/WebKit/LayoutTests/external/wpt/svg/foreignobject/foreign-object-circular-filter-reference-crash.html
[add] https://crrev.com/f6a82fc1c8b43938da813697c723c1db6834482b/third_party/WebKit/LayoutTests/external/wpt/svg/svg-in-svg/svg-in-svg-circular-filter-reference-crash.html
[modify] https://crrev.com/f6a82fc1c8b43938da813697c723c1db6834482b/third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp
[modify] https://crrev.com/f6a82fc1c8b43938da813697c723c1db6834482b/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

Project Member

Comment 6 by ClusterFuzz, Feb 22 2018

ClusterFuzz has detected this issue as fixed in range 538495:538532.

Detailed report: https://clusterfuzz.com/testcase?key=6251247875915776

Fuzzer: miaubiz_svg_fuzzer
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000000068
Crash State:
  blink::SVGForeignObjectPainter::Paint
  blink::LayoutSVGForeignObject::Paint
  blink::BoxPainter::PaintChildren
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=537450:537464
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=538495:538532

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6251247875915776

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Feb 22 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6251247875915776 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment