New issue
Advanced search Search tips

Issue 813442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Drop cros_config_host_py

Project Member Reported by sjg@chromium.org, Feb 18 2018

Issue description

This is an alias of cros_config_host which was used during the C++ migration. We don't need it now that the C++ host tool is gone.

We should replace uses of cros_config_host_py with cros_config_host
 

Comment 1 by sjg@chromium.org, Feb 18 2018

Cc: shapiroc@chromium.org
This could be a good starter bug for Greg?

Comment 2 by sjg@chromium.org, Feb 20 2018

Cc: sjg@chromium.org
Owner: ----
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/de966f486bca6fa6ffc911c1b698f9c29587a386

commit de966f486bca6fa6ffc911c1b698f9c29587a386
Author: Simon Glass <sjg@chromium.org>
Date: Thu Feb 22 04:39:25 2018

chromeos-config: Update TODO to reference its bug

This work has not been completed. Update it to reference the bug which I
just filed.

BUG= chromium:813442 
TEST=none

Change-Id: Ib79a4e6ae2aed5313d10962d462da127186d3b51
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/927005
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/de966f486bca6fa6ffc911c1b698f9c29587a386/chromeos-config/setup.py

Owner: gmeinke@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/aa7c0e1ec53085df985a2cbb7886069b64a982a3

commit aa7c0e1ec53085df985a2cbb7886069b64a982a3
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Thu Mar 08 00:55:11 2018

chromeos-config: replace cros_config_host_py in thirdparty eclass files

Replace calls to cros_config_host_py with cros_config_host in the
thirdparty overlay eclass files.

BUG= chromium:813442 
TEST=Ran local tests and build_packages and build_image for reef board
that failed in previous CL

Change-Id: Id88b8a918720641914fe042f0f003d911a93fcef
Reviewed-on: https://chromium-review.googlesource.com/951849
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/aa7c0e1ec53085df985a2cbb7886069b64a982a3/eclass/cros-unibuild.eclass
[modify] https://crrev.com/aa7c0e1ec53085df985a2cbb7886069b64a982a3/eclass/cros-ec-board.eclass
[modify] https://crrev.com/aa7c0e1ec53085df985a2cbb7886069b64a982a3/eclass/cros-firmware.eclass

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/75274556bcaf04aebcd9aa6002dc177c50035866

commit 75274556bcaf04aebcd9aa6002dc177c50035866
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Thu Mar 08 03:47:08 2018

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7ec4095f14ad36ba1db488d4a87fda8b78ebd83a

commit 7ec4095f14ad36ba1db488d4a87fda8b78ebd83a
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Fri Mar 09 01:00:57 2018

chromeos-config: replace cros_config_host_py in depthcharge

BUG= chromium:813442 
TEST=Full build_packages and build_image for reef board that was
failing on earlier CL

Change-Id: I12c51e0b35ff800cf50995316ef4548a7e4a3b69
Reviewed-on: https://chromium-review.googlesource.com/955939
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/7ec4095f14ad36ba1db488d4a87fda8b78ebd83a/sys-boot/depthcharge/depthcharge-9999.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5deea8b1eb99d707f09773ec80be59916f907333

commit 5deea8b1eb99d707f09773ec80be59916f907333
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Fri Mar 09 01:01:03 2018

chromeos-config: replace cros_config_host_py in coreboot

BUG= chromium:813442 
TEST=Full build_packages and build_image for reef board that was
failing on earlier CL

Change-Id: I2cfef5c49482e99d5760338c0b125f3d47b79098
Reviewed-on: https://chromium-review.googlesource.com/956008
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/5deea8b1eb99d707f09773ec80be59916f907333/sys-boot/coreboot/coreboot-9999.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0fd11cd7da3ca1bf57b885e024a3c0b922c02d58

commit 0fd11cd7da3ca1bf57b885e024a3c0b922c02d58
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Tue Mar 13 07:57:26 2018

chromeos-config: replace cros_config_host_py in chromeos-config ebuild

BUG= chromium:813442 
TEST=Full build_packages and build_image for reef board that was
failing on earlier CL

Change-Id: I8c9d48a73e43e7cda6bed5baaedaf74149acf9d9
Reviewed-on: https://chromium-review.googlesource.com/959116
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/0fd11cd7da3ca1bf57b885e024a3c0b922c02d58/chromeos-base/chromeos-config/chromeos-config-0.0.1.ebuild
[rename] https://crrev.com/0fd11cd7da3ca1bf57b885e024a3c0b922c02d58/chromeos-base/chromeos-config/chromeos-config-0.0.1-r14.ebuild

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/12c1b5bdac927e2d7f4aa51e26c57d8d68be1696

commit 12c1b5bdac927e2d7f4aa51e26c57d8d68be1696
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Tue Mar 13 20:05:13 2018

chromium-config: replace cros_config_host_py in chromite

BUG= chromium:813442 
TEST=Ran local unittests

Change-Id: Ibc2b84657e882c6681683a7062699be7a5c26957
Reviewed-on: https://chromium-review.googlesource.com/959173
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/12c1b5bdac927e2d7f4aa51e26c57d8d68be1696/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/12c1b5bdac927e2d7f4aa51e26c57d8d68be1696/cbuildbot/commands.py
[modify] https://crrev.com/12c1b5bdac927e2d7f4aa51e26c57d8d68be1696/cbuildbot/commands_unittest.py

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/efec46678f530e39b69fdfa6d42fc8bde8dac08c

commit efec46678f530e39b69fdfa6d42fc8bde8dac08c
Author: Greg Meinke <gmeinke@chromium.org>
Date: Wed Mar 14 02:00:19 2018

chromeos-config: Replace cros_config_host_py with cros_config_host

BUG= chromium:813442 
TEST=Ran all package unit tests

Change-Id: I1978bea553329fc42caaf4abd369f5d284e62fd5
Reviewed-on: https://chromium-review.googlesource.com/946521
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/efec46678f530e39b69fdfa6d42fc8bde8dac08c/chromeos-config/README.md
[modify] https://crrev.com/efec46678f530e39b69fdfa6d42fc8bde8dac08c/chromeos-config/setup.py

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8c2cc13a506d89b20486ce33bfad78c4cb6a0b3d

commit 8c2cc13a506d89b20486ce33bfad78c4cb6a0b3d
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Wed Mar 14 18:55:57 2018

chromeos-config: Update README.me

Update missed reference to cros_config_host_py in the README.md

BUG= chromium:813442 
TEST=None

Change-Id: Ib77616122aa903d64aba0c5d65031cfe04271512
Reviewed-on: https://chromium-review.googlesource.com/962707
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/8c2cc13a506d89b20486ce33bfad78c4cb6a0b3d/chromeos-config/README.md

Status: Fixed (was: Started)
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5

commit b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Mar 16 22:50:01 2018

Roll src/third_party/chromite/ 3b75c9d82..3ad8f333d (31 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b75c9d82ebf..3ad8f333d567

$ git log 3b75c9d82..3ad8f333d --date=short --no-merges --format='%ad %ae %s'
2018-03-16 dgarrett Revert "Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq.""
2018-03-16 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."
2018-03-14 ayatane autotest-pre-cq: Remove builder and stage [2/2]
2018-03-16 dgarrett Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."
2018-03-15 dgarrett chromeos_config: Move fuzzer builds into new bucket.
2018-03-16 dgarrett Revert "commands: RunBranchUtilTest -> RunLocalTryjob"
2018-03-13 dgarrett pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq.
2018-02-07 dgarrett commands: RunBranchUtilTest -> RunLocalTryjob
2018-03-14 dgarrett cbuildbot_run: Switch more build links to Legoland.
2018-03-13 dgarrett swarming_lib: Remove SWARMING_TASK_ID from cmds.
2018-03-08 dgarrett moblab_vm_unitest: Fix lint issues.
2018-03-14 ihf chromeos_config: add more arcnext experimental coverage.
2018-03-14 ayatane autotest-pre-cq: Remove this [1/2]
2018-03-14 norvez chromeos_config: remove dead code
2018-03-09 dgarrett summarize_build_stats: Add blank line at beginning.
2018-01-09 dgarrett cros tryjob: Remove buildbot URL generation.
2017-09-14 craigb image_test: Remove check that kernel is not ELF.
2018-03-15 ihf Revert "chromeos_config: temporarily mark eve-arcnext-paladin experimental"
2018-03-15 ihf Revert "chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq"
2018-03-13 lhchavez chromeos_config: Add betty-arcnext builder config
2018-03-13 achuith cbuildbot: Add missing files to index.
2018-03-13 akeshet completion_stages: add a has_important_slave metric to master completion
2018-03-13 dgarrett precq-launcher: Start using Legoland build details page.
2018-03-08 dgarrett chromite-pre-cq: Disable CidbIntegrationTest.
2018-03-14 akeshet chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq
2018-03-13 akeshet chromeos_config: temporarily mark eve-arcnext-paladin experimental
2018-03-12 haddowk [chromite] Make guado_moblab important again
2018-03-13 chrome-bot Update config settings by config-updater.
2018-03-12 gmeinke chromium-config: replace cros_config_host_py in chromite
2018-03-12 yunlian Enable ThinLTO on all AMD64 boards.
2018-03-12 achuith cbuildbot: Log timing of GenerateUploadJSON.

Created with:
  roll-dep src/third_party/chromite
BUG=821930, 822517 , 821615 ,None,821618,821227,None,821664,821930,None,815377,747385,461595,821664,821664,811989,819419,821618,820305,821664,821664,819017,813442,707803,811989


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib6aaddf338307e994865a092ecb322a432148692
Reviewed-on: https://chromium-review.googlesource.com/967273
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543855}
[modify] https://crrev.com/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5/DEPS

Sign in to add a comment