New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813435 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Space at style name

Reported by eugeny.s...@sivintech.com, Feb 18 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36

Steps to reproduce the problem:
1. Open styles panel
2. Write a style name with space(like: "background color")
3. The style become undeletable, uneditable and so on.

What is the expected behavior?
Warning message

What went wrong?
See steps to reproduce. It should be clear to understand

Did this work before? N/A 

Chrome version: 64.0.3282.167  Channel: stable
OS Version: OS X 10.13.3
Flash Version: 

I(my girlfriend) have found a bug!) Yuppy)
 

Comment 1 by ajha@chromium.org, Feb 19 2018

 Issue 813434  has been merged into this issue.

Comment 2 by ajha@chromium.org, Feb 19 2018

Labels: Needs-Triage-M64
Labels: Triaged-ET Needs-Feedback
Tested the issue on chrome reported version 64.0.3282.167 using Mac 10.13.1 with steps mentioned below:
1) Launched chrome reported version and opened Devtools > Styles panel
2) Clicked on "+" and added the style "background color" and clicked on enter
Observations:
Right clicked on the added "background color" style and clicked on cut and enter, again "background color" appears, tried to add the color as "background color: White" to the added style, unable to add to it.

@Reporter:
Please find the attached screencast for your reference and let us know if you are observing the same which i have captured in the screencast, provide your inpus on it which helps in further triaging the issue.

Thanks!
813435.mp4
2.9 MB View Download
This is the behavior I've mentioned about.
chromium-bug.png
9.7 KB View Download
This styles are not clickable, not editable and shows no warning message
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 19 2018

Cc: viswa.karala@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: vamshi.kommuri@chromium.org
Labels: M-66 FoundIn-66 Target-66 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Checked the issue as per the comments#4 and #5 given by reporter.

Able to reproduce the issue on reported chrome version 64.0.3282.167 and on the latest canary 66.0.3350.0 using windows 10, Ubuntu 14.04 and Mac 10.13.1. As the issue is seen from M60(60.0.3072.0) considering it a Non-Regression and marking it as Untriaged.
Note: We are unable to edit the text "qwer rewq: rewq;" as this isn't clickable.

Thanks!

Comment 8 by alph@chromium.org, Mar 3 2018

Cc: krajshree@chromium.org einbinder@chromium.org
 Issue 815500  has been merged into this issue.

Comment 9 by alph@chromium.org, Mar 3 2018

Owner: einbinder@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e328358f9e11cda5257454afba56dd2a7cd0b72

commit 7e328358f9e11cda5257454afba56dd2a7cd0b72
Author: Joel Einbinder <einbinder@chromium.org>
Date: Mon Jun 11 23:22:22 2018

DevTools: Show malformed CSS properties in the Styles Sidebar

Previously CSS that was not correctly parsed would not appear in the
styles sidebar. If a mistake was made when editing CSS in the sidebar,
the property being edited could dissapear because it would no longer
be parsed correctly.

Bug: 813435
Change-Id: I20cb6b1e977545693c3f75171479d8e9041d83d9
Reviewed-on: https://chromium-review.googlesource.com/1089295
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566196}
[modify] https://crrev.com/7e328358f9e11cda5257454afba56dd2a7cd0b72/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-expected.txt
[add] https://crrev.com/7e328358f9e11cda5257454afba56dd2a7cd0b72/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-parse-invalid-properties-expected.txt
[add] https://crrev.com/7e328358f9e11cda5257454afba56dd2a7cd0b72/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-parse-invalid-properties.js
[modify] https://crrev.com/7e328358f9e11cda5257454afba56dd2a7cd0b72/third_party/blink/renderer/devtools/front_end/sdk/CSSStyleDeclaration.js

Cc: l...@chromium.org
 Issue 877822  has been merged into this issue.

Sign in to add a comment