New issue
Advanced search Search tips

Issue 813427 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: constructor_initial_map->instance_size() <= instance_size in objects.cc

Project Member Reported by ClusterFuzz, Feb 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5754965478604800

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  constructor_initial_map->instance_size() <= instance_size in objects.cc
  FastInitializeDerivedMap
  v8::internal::JSFunction::GetDerivedMap
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=51254:51255

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5754965478604800

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 18 2018

Labels: Test-Predator-Auto-Owner
Owner: cbruni@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/7b27040e66c8a83006aebc90fe97d21bb42156a7 ([runtime] Harden JSFunction::CalculateInstanceSizeHelper(...)).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 2 by och...@chromium.org, Feb 18 2018

Labels: Security_Impact-Head
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 19 2018

Labels: M-66
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 19 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 19 2018

Labels: Pri-1

Comment 6 by cbruni@chromium.org, Feb 20 2018

This is an overzealous CHECK, fix on the way.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/da83b61848bd4ee5426b7c3c773f7cd8f627ddb8

commit da83b61848bd4ee5426b7c3c773f7cd8f627ddb8
Author: Camillo Bruni <cbruni@chromium.org>
Date: Tue Feb 20 13:28:37 2018

[runtime] Fix overzealous check for derived constructor instance size

Bug:  chromium:813427 
Change-Id: Ie0b096b20f335648e7920c5ebe4ff0fa3b5ab9d5
Reviewed-on: https://chromium-review.googlesource.com/926003
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51393}
[modify] https://crrev.com/da83b61848bd4ee5426b7c3c773f7cd8f627ddb8/src/objects.cc
[add] https://crrev.com/da83b61848bd4ee5426b7c3c773f7cd8f627ddb8/test/mjsunit/regress/regress-crbug-813427.js

Project Member

Comment 8 by ClusterFuzz, Feb 21 2018

ClusterFuzz has detected this issue as fixed in range 51392:51393.

Detailed report: https://clusterfuzz.com/testcase?key=5754965478604800

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  constructor_initial_map->instance_size() <= instance_size in objects.cc
  FastInitializeDerivedMap
  v8::internal::JSFunction::GetDerivedMap
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=51254:51255
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=51392:51393

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5754965478604800

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Feb 21 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5754965478604800 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 21 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-65
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 22 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ for M65 merge review. Thank you.
govind@ - good for 65
Labels: -Merge-Review-65 Merge-Approved-65
Approving merge to M65 branch 3325 based on comment #14. Please merge before 4:00 PM PT Monday (02/26) so we can pick it up for last beta release next week. Thank you.

Comment 16 by adamk@chromium.org, Feb 23 2018

Issue 813492 has been merged into this issue.
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 23 2018

Labels: merge-merged-6.5
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/aa11600b89a7799f947e6bbdcb7e33e396a12534

commit aa11600b89a7799f947e6bbdcb7e33e396a12534
Author: Camillo Bruni <cbruni@chromium.org>
Date: Fri Feb 23 23:28:04 2018

Merged: [runtime] Fix overzealous check for derived constructor instance size

Cherry-picked from commit da83b61848bd4ee5426b7c3c773f7cd8f627ddb8.

Bug:  chromium:813427 
Change-Id: I1a3091f27c20e970b11af6a75f2dad7c869714ca
Reviewed-on: https://chromium-review.googlesource.com/935583
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.5@{#55}
Cr-Branched-From: 73c55f57fe8506011ff854b15026ca765b669700-refs/heads/6.5.254@{#1}
Cr-Branched-From: 594a1a0b6e551397cfdf50870f6230da34db2dc8-refs/heads/master@{#50664}
[modify] https://crrev.com/aa11600b89a7799f947e6bbdcb7e33e396a12534/src/objects.cc
[add] https://crrev.com/aa11600b89a7799f947e6bbdcb7e33e396a12534/test/mjsunit/regress/regress-crbug-813427.js

Comment 18 by adamk@chromium.org, Feb 23 2018

Labels: -Merge-Approved-65 merge-merged-65
Cc: pbomm...@chromium.org
Project Member

Comment 20 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Labels: -ReleaseBlock-Stable -M-66 M-65
Project Member

Comment 22 by sheriffbot@chromium.org, May 30 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment