input type="file" after selecting file, needs pressing "done" - twice
Reported by
kinos...@gmail.com,
Feb 18 2018
|
|||||||||||
Issue descriptionSteps to reproduce the problem: 1. click <input type="file"/> 2. select a file 3. press "done" (nothing happens) 4. press "done" again (it loads) What is the expected behavior? file to load on first press of "done", or better yet, since it is NOT <input type="file" multiple />, having to first select (check) the file, and then press "done" is redundant - poor UX. What went wrong? After selecting which file to load, the user needs to press "done" - twice to load. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 64.0.3282.137 Channel: stable OS Version: 7.1.2; MI 5X Flash Version: The behaviour is seen in Chrome-Mobile, webview, but NOT when android app loads a webview. NOTE: you can see example of the problem here https://kinoseed.com/ (click on source or target image to load a file) Device tested: MI 5X
,
Feb 19 2018
,
Feb 19 2018
Tested the issue in Android and able to reproduce the issue. Steps Followed: 1. Launch Chrome. 2. Navigate to the URL: https://kinoseed.com/ 3. Tap on the button "Add Source Image". 4. Navigate to any folder to select an image. 5. Tap on "Done" button, observed that image is not added. 6. Tap on "Done" button again, observed that image is added. Chrome versions tested: 64.0.3282.140 (Beta) OS: Android 8, Android 7.0.0 Android Devices: Pixel, SM-J710F Build/NRD90M Using the per-revision bisect providing the bisect results, Good Build - 64.0.3249.0 (511318) Bad Build - 64.0.3250.0 (511680) CL for the above builds: https://chromium.googlesource.com/chromium/src/+log/64.0.3249.0..64.0.3250.0?pretty=fuller&n=10000 Unable to provide the per-revision bisect results because for all the Chromium builds invoked gave different flow to add images. And in that flow "Done" button is not seen. (Can be observed in the screencast). Hence, providing manual bisect. Possible suspect CL: https://chromium.googlesource.com/chromium/src/+/5f447acc481e3277bed61e2bb6d308b4d36362ce From the CL above, assigning the issue to the owner concerned. @guidou: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned. Please navigate to below link for log's and video-- go/chrome-androidlogs/813422 Note: 1. This issue is not observed in Desktop.
,
Feb 20 2018
,
Sep 14
Any chance we can get this bug triaged this year?
,
Sep 14
pnangunoori@: Sorry that I missed your message. The suspect CL is completely unrelated to this bug.
,
Sep 14
,
Sep 14
Is there a more specific category for integration with the Android photo picker?
,
Sep 18
The code is in ui/android/java/src/org/chromium/ui/base/, and OWNERS says "COMPONENT: UI" :-P peter@, would you take a look at this please?
,
Sep 18
I can repro on Canary, but not my local build. I'll investigate.
,
Sep 18
Adding Theresa and Ted, as Android UI experts. I've been debugging this and it seems that the button is enabled, a click handler is hooked up from the start and when I change the styling and long-press the button, it shows touch highlighting for both presses. I've tried using a custom click handler and it also shows that only the second click is delivered to the handler. I'm not sure how to debug this problem further... Any tips would be helpful.
,
Sep 20
To go back before 64.0.3249.0 you need to manually enable the PhotoPicker via chrome://flags (look for photo). 64.0.3249.0 is listed as good above, but is also bad.
,
Sep 20
OK, after a lot of trial and error, I've discovered that: 63.0.3238.0 is the last known good. 63.0.3239.0 is the first broken build.
,
Sep 20
The list of CLs is: https://chromium.googlesource.com/chromium/src/+log/63.0.3238.0..63.0.3239.0?pretty=fuller&n=10000 Which I suspect points to this culprit... https://chromium.googlesource.com/chromium/src/+/d55e1134f11347975fbc1dc2d7243267d8109390
,
Sep 20
Fix is in review: https://chromium-review.googlesource.com/c/chromium/src/+/1236435
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6738399c6daa2b2730b7150e04476a797515bbff commit 6738399c6daa2b2730b7150e04476a797515bbff Author: Finnur Thorarinsson <finnur@chromium.org> Date: Thu Sep 20 16:42:49 2018 Photo Picker: Fix the double-tap to click problem. The SelectableListToolbar is setting FocusInTouchMode to true for all its children. This is problematic for the Done button, as it then requires two taps to click. Also, while I was at it, use the same styling for the Done button as the Done button in the Contacts Picker. Bug: 813422 , 656015 Change-Id: I277626563885621b3bf677697d464a3299e6658f Reviewed-on: https://chromium-review.googlesource.com/1236435 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#592832} [modify] https://crrev.com/6738399c6daa2b2730b7150e04476a797515bbff/chrome/android/java/res/layout/photo_picker_toolbar.xml [modify] https://crrev.com/6738399c6daa2b2730b7150e04476a797515bbff/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
,
Sep 21
,
Sep 25
Works as per expected behavior that is "Done" works on single click. Issue verified on 71.0.3561.0
,
Nov 12
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by pnangunoori@chromium.org
, Feb 19 2018