Gray "border" of broken images gets larger with zooming in
Reported by
tobias...@gmail.com,
Feb 18 2018
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36 Example URL: Steps to reproduce the problem: 1. Open the attached HTML file 2. Zoom in What is the expected behavior? The zooming should scale up everything by the same factor. What went wrong? The broken image icon's gray border gets proportionally larger, the more one zooms in. When I have set a display scaling is > 100% in Windows, the sizing of the broken image icon's border is already oversized to begin with. Does it occur on multiple sites: N/A Is it a problem with a plugin? N/A Did this work before? Yes I don't know Does this work in other browsers? N/A Chrome version: 64.0.3282.167 Channel: n/a OS Version: 10.0 Flash Version:
,
Feb 18 2018
,
Feb 19 2018
,
Feb 19 2018
,
Feb 19 2018
Able to reproduce this issue on reported version 64.0.3382.167, on latest beta 65.0.3325.57 and on latest canary 66.0.3350.0 using HTML file given in comment#2. i.e; On zooming In grey border size increases. Good Build: 60.0.3078.0 Bad Build: 60.0.3079.0 You are probably looking for a change made after 466545 (known good), but no later than 466546 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/32d9f5075ba7f767d2c6c6d41794dc70b5ff7bf3..fe767186a3dc40ea14b5f807ff5438bd78f79c95 Review-Url: https://codereview.chromium.org/2593263003 Suspecting same from changelog. As robhogan@ 's last visit is >30 days assigning to one of the reviewer @meacer @ meacer: Please confirm the bug and help in re-assigning if it is not related to your change. Thanks!
,
Feb 20 2018
We're double scaling. I'll fix this. Regressions more than 5 releases back are not considered regressions. This is not a P1 because it doesn't prevent web site usage or inhibit finctionality in a significant way (but it is really ugly, I agree, so we'll fix it).
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb584c992a341fff6b7c723401c1b55f687d5f17 commit cb584c992a341fff6b7c723401c1b55f687d5f17 Author: Stephen Chenney <schenney@chromium.org> Date: Fri Mar 09 18:20:52 2018 Account for zoom in fallback image sizing The code that set the size of the container for the fallback image is using the missing image's style's width and height, setting it directly on the replaced container. But the style's sizes are zoomed while the replaced container style should be pre-zoom. Fix it. R=pdr@chromium.org BUG=813417 Change-Id: I230f45442dfbd5936e820633bcf85f387a0a82fb Reviewed-on: https://chromium-review.googlesource.com/956502 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#542153} [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/images/missing-image-border-zoom.html [modify] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-with-size-hidpi-expected.png [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/mac/images/missing-image-border-zoom-expected.png [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/mac/images/missing-image-border-zoom-expected.txt [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/missing-image-border-zoom-expected.png [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/missing-image-border-zoom-expected.png [modify] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/win/fast/hidpi/broken-image-with-size-hidpi-expected.png [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/win/images/missing-image-border-zoom-expected.png [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/win/images/missing-image-border-zoom-expected.txt [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/missing-image-border-zoom-expected.png [add] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/missing-image-border-zoom-expected.png [modify] https://crrev.com/cb584c992a341fff6b7c723401c1b55f687d5f17/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp |
|||||
►
Sign in to add a comment |
|||||
Comment 1 Deleted