Clean AdapterLost metrics pollution |
||||||
Issue descriptionWe are recording a lot of AdapterLost metrics when there are actually no adapter lost happening, as evident from looking at minnie's metrics. minnie cannot have USB disconnection as the bluetooth adapter is not even USB interface but UART, but AdapterLost metrics contain a lot of samples.
,
Feb 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/f829a0edb783eac013303dd79d84acec26ddd759 commit f829a0edb783eac013303dd79d84acec26ddd759 Author: Sonny Sasaka <sonnysasaka@chromium.org> Date: Sat Feb 24 05:06:54 2018 CHROMIUM: Refine adapter lost metrics. Currently adapter lost events are detected from adapter_free function. This is a bit risky because we have been assuming that adapter_free is *only* called when there is USB disconnection, where in fact that function could be reached from many other unexpected events, e.g. bluetoothd process killed, bug in adapter object ref-counting, etc. This CL adds a new metrics which uses adapter lost detection closer to its source, which is index_removed function which is a callback of the adapter lost event from kernel directly. Additionally, this metrics is not recorded if suspend/resume just happened since the adapter lost may be caused by normal power cut off instead of hardware bug. The corresponding UMA histogram CL is at http://crosreview.com/930482. BUG= chromium:813390 TEST=Simulate adapter lost with 'rmmod btusb' and 'modprobe btusb' and check from the log that metrics is sent. Simulate system suspend and check that metrics is not send even though USB disconnection happens. Change-Id: I92c3829606d301ebb474e6182e4cdf1b7c27cf83 Reviewed-on: https://chromium-review.googlesource.com/924505 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/f829a0edb783eac013303dd79d84acec26ddd759/src/metrics.c [modify] https://crrev.com/f829a0edb783eac013303dd79d84acec26ddd759/src/adapter.c [modify] https://crrev.com/f829a0edb783eac013303dd79d84acec26ddd759/src/metrics.h
,
Apr 19 2018
,
Apr 19 2018
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d0f53fc4126529af8a277418eed2c93225e57d3 commit 0d0f53fc4126529af8a277418eed2c93225e57d3 Author: Sonny Sasaka <sonnysasaka@chromium.org> Date: Thu Aug 16 00:02:12 2018 Add UMA metrics BlueZ.ChipLost2 This deprecates BlueZ.ChipLost because we need to filter out suspend/resume events even when adapter is disabled. Corresponding CL where metrics is used: https://crrev.com/c/1176398. BUG= chromium:813390 Change-Id: I8620fdd1c0225a97226d462e234643882f6553a5 Reviewed-on: https://chromium-review.googlesource.com/1176371 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#583453} [modify] https://crrev.com/0d0f53fc4126529af8a277418eed2c93225e57d3/tools/metrics/histograms/histograms.xml
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/876f380713e4f8339e87c787e9edbad027b1c341 commit 876f380713e4f8339e87c787e9edbad027b1c341 Author: Miao-chen Chou <mcchou@chromium.org> Date: Fri Aug 17 21:04:52 2018 Add UMA metrics BlueZ.ChipLost2 This deprecates BlueZ.ChipLost because we need to filter out suspend/resume events even when adapter is disabled. Corresponding CL where metrics is used: https://crrev.com/c/1176398. BUG= chromium:813390 TBR=sonnysasaka@chromium.org (cherry picked from commit 0d0f53fc4126529af8a277418eed2c93225e57d3) Change-Id: I8620fdd1c0225a97226d462e234643882f6553a5 Reviewed-on: https://chromium-review.googlesource.com/1176371 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583453} Reviewed-on: https://chromium-review.googlesource.com/1179254 Cr-Commit-Position: refs/branch-heads/3440@{#807} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/876f380713e4f8339e87c787e9edbad027b1c341/tools/metrics/histograms/histograms.xml
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ca1577594b284ef0104902ec317205a061f26e7 commit 8ca1577594b284ef0104902ec317205a061f26e7 Author: Miao-chen Chou <mcchou@chromium.org> Date: Fri Aug 17 21:05:53 2018 Add UMA metrics BlueZ.ChipLost2 This deprecates BlueZ.ChipLost because we need to filter out suspend/resume events even when adapter is disabled. Corresponding CL where metrics is used: https://crrev.com/c/1176398. BUG= chromium:813390 TBR=sonnysasaka@chromium.org (cherry picked from commit 0d0f53fc4126529af8a277418eed2c93225e57d3) Change-Id: I8620fdd1c0225a97226d462e234643882f6553a5 Reviewed-on: https://chromium-review.googlesource.com/1176371 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583453} Reviewed-on: https://chromium-review.googlesource.com/1179255 Cr-Commit-Position: refs/branch-heads/3497@{#696} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/8ca1577594b284ef0104902ec317205a061f26e7/tools/metrics/histograms/histograms.xml
,
Sep 26
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Feb 23 2018