New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 813368 link

Starred by 1 user
Status: WontFix
Owner:
erikc...@chromium.org
Closed: Feb 2018
Cc:
etienneb@chromium.org
primiano@chromium.org
wittman@chromium.org
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

Stack sampling profiler and heap profiler should not be allowed to run simultaneously.

Project Member Reported by erikc...@chromium.org, Feb 17 2018 
It seems likely that the two will have racey deadlocks. The easiest solution [given that heap profiler runs on fewer devices] would be to disable stack sampling profiler via a flag checked in StackSamplingConfiguration::IsProfilerEnabledForCurrentProcess() when heap profiling is enabled in ProfilingClient::StartProfiling.

Comment 1 by wittman@chromium.org, Feb 20 2018 

The stack sampling profiler doesn't use the heap while threads are suspended so deadlock shouldn't be an issue. This is by design, to avoid deadlocking on locks taken in native heap implementations. I don't think the heap profiler adds any new wrinkles to this scenario.

Comment 2 by erikc...@chromium.org, Feb 20 2018

Status: WontFix (was: Assigned)
Ah alright then.
►

Sign in to add a comment