New issue
Advanced search Search tips

Issue 813306 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 771643



Sign in to add a comment

Heap-use-after-free in blink::CompositedLayerRasterInvalidator::SetTracksRasterInvalidations

Project Member Reported by ClusterFuzz, Feb 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6343551018074112

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x60f00008b0f0
Crash State:
  blink::CompositedLayerRasterInvalidator::SetTracksRasterInvalidations
  blink::GraphicsLayer::UpdateTrackingRasterInvalidations
  blink::UpdateTrackingRasterInvalidationsRecursive
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=537349:537412

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6343551018074112

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 17 2018

Components: Blink>Compositing Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Feb 17 2018

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/297ee9e2ac0fea6624373b0a17b7b78a4b08c033 ([SPv175] Clear paint property tree node change flags after painting).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 17 2018

Labels: M-66
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 17 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 17 2018

Labels: Pri-1
Project Member

Comment 6 by ClusterFuzz, Feb 19 2018

Labels: OS-Windows
Labels: -Pri-1 -Security_Severity-High -ReleaseBlock-Stable Pri-2
The crash is in code for testing only. It doesn't affect official build.
Blocking: 771643

Comment 9 by kenrb@chromium.org, Feb 27 2018

Labels: -Type-Bug-Security -Restrict-View-SecurityTeam -Security_Impact-Head Type-Bug
Clearing security flags, since this arises from a call to a testRunner method.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c53de6319c9387bb765f4a57a49ee09995d099f2

commit c53de6319c9387bb765f4a57a49ee09995d099f2
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Mar 02 21:52:03 2018

[PE] Reset raster invalidator in GraphicsLayer::SetDrawsContent(false)

Bug:  813306 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0d431f44cb0347d49445e749ca29d58fc8bd8024
Reviewed-on: https://chromium-review.googlesource.com/946629
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540643}
[modify] https://crrev.com/c53de6319c9387bb765f4a57a49ee09995d099f2/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/c53de6319c9387bb765f4a57a49ee09995d099f2/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp

Project Member

Comment 11 by ClusterFuzz, Mar 3 2018

ClusterFuzz has detected this issue as fixed in range 540622:540643.

Detailed report: https://clusterfuzz.com/testcase?key=6343551018074112

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x60f00008b0f0
Crash State:
  blink::CompositedLayerRasterInvalidator::SetTracksRasterInvalidations
  blink::GraphicsLayer::UpdateTrackingRasterInvalidations
  blink::UpdateTrackingRasterInvalidationsRecursive
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=537349:537412
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=540622:540643

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6343551018074112

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Mar 3 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6343551018074112 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment