New issue
Advanced search Search tips

Issue 813288 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Ill in multi-return.cc

Project Member Reported by ClusterFuzz, Feb 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4793072337289216

Fuzzer: libFuzzer_v8_multi_return_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Ill
Crash Address: 0x000001d6b2d8
Crash State:
  multi-return.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=536705:536714

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4793072337289216

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 17 2018

Components: Blink>JavaScript
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: clemensh@chromium.org
Owner: ahaas@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ba5409a6fd1f9e6a95b740e2eb28bdaf57ed3747

commit ba5409a6fd1f9e6a95b740e2eb28bdaf57ed3747
Author: Andreas Haas <ahaas@chromium.org>
Date: Wed Mar 21 09:56:12 2018

[wasm] Make multi-return tests wasm-specific

The multi-return tests and fuzzer used a custom call descriptor which
was based on the default RegisterConfiguration. This meant that for the
tests, all available registers could be used to pass parameters and to
return values. This caused a problem, because in some cases we need a
scratch register in the frame deconstruction.

With this CL I change both the tests and the fuzzer to use the
WebAssembly call descriptor. Thereby we only use 2 registers for
returns, and one of the other registers can be used as scratch
register.

WebAssembly is the only use case at the moment which wants to return
values not only through registers but also over the stack. Therefore
I think it's acceptable to only test the WebAssembly usecase.

R=mstarzinger@chromium.org

Bug:  chromium:813288 
Change-Id: I31bed757af5f3e8589d2b3dfb6f0112ddecd1a20
Reviewed-on: https://chromium-review.googlesource.com/970656
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52099}
[modify] https://crrev.com/ba5409a6fd1f9e6a95b740e2eb28bdaf57ed3747/test/cctest/compiler/test-multiple-return.cc
[modify] https://crrev.com/ba5409a6fd1f9e6a95b740e2eb28bdaf57ed3747/test/fuzzer/multi-return.cc

Project Member

Comment 4 by ClusterFuzz, Mar 22 2018

ClusterFuzz has detected this issue as fixed in range 544719:544730.

Detailed report: https://clusterfuzz.com/testcase?key=4793072337289216

Fuzzer: libFuzzer_v8_multi_return_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Ill
Crash Address: 0x000001d6b2d8
Crash State:
  multi-return.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=536705:536714
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=544719:544730

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4793072337289216

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Mar 22 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4793072337289216 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment