New issue
Advanced search Search tips

Issue 813282 link

Starred by 1 user
Status: Fixed
Owner:
derat@chromium.org
Closed: Mar 2018
Cc:
jclinton@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

tast fails to move remote tests' output files across disks in the lab

Project Member Reported by derat@chromium.org, Feb 17 2018 
When running remote tests in the lab, tast currently logs an error when trying to collect output files:

2018/02/16 14:02:08 Failed to copy test output data: rename /tmp/tast_out.508141594 /usr/local/autotest/results/177213828-chromeos-test/chromeos6-row2-rack24-host18/tast_Runner/results/out.tmp: invalid cross-device link

The problem is that I'm attempting to just move the output files to the results dir, but they're coming from a dir in /tmp that's on a different device.

The easy fix is to put the temp dir within the results dir.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/041dfe02a801556a654c7be844a3c76931a40a4f

commit 041dfe02a801556a654c7be844a3c76931a40a4f
Author: Daniel Erat <derat@chromium.org>
Date: Sat Feb 17 18:05:11 2018

tast: Write remote test output under results dir.

Write remote tests' output into a temporary directory under
the results dir rather than under /tmp to guarantee that it
can be moved directly to its final location in the results
dir later.

BUG= chromium:813282 
TEST=manual: passed a directory under /run via -resultsdir
     and checked that the output dir is moved successfully

Change-Id: Idf33abbbc0be7d60b232ef6c647310019fbdd85d
Reviewed-on: https://chromium-review.googlesource.com/923557
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/041dfe02a801556a654c7be844a3c76931a40a4f/src/chromiumos/tast/runner/runner.go
[modify] https://crrev.com/041dfe02a801556a654c7be844a3c76931a40a4f/src/chromiumos/cmd/tast/run/remote.go
[modify] https://crrev.com/041dfe02a801556a654c7be844a3c76931a40a4f/src/chromiumos/cmd/tast/run/remote_test.go
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/937b024e76e0ac259e502933ff1b7092105fb630

commit 937b024e76e0ac259e502933ff1b7092105fb630
Author: Daniel Erat <derat@chromium.org>
Date: Sun Mar 04 04:04:18 2018

tast: Add test to check that runner pkg honors out dir.

Add a unit test for the runner package that verifies that
ParseArgs and RunTests use a custom output directory when
one is supplied.

BUG= chromium:813282 
TEST=test passes

Change-Id: I8db5073d15cc9f50eb59f696be9540119e77f103
Reviewed-on: https://chromium-review.googlesource.com/945138
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/937b024e76e0ac259e502933ff1b7092105fb630/src/chromiumos/tast/runner/runner_test.go

Comment 3 by derat@chromium.org, Mar 4 2018

Status: Fixed (was: Started)
►

Sign in to add a comment