New issue
Advanced search Search tips

Issue 813253 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

'Restart Chrome' incorrect size and button

Project Member Reported by bettes@chromium.org, Feb 17 2018

Issue description

Two issues: 
- dialog width should be 448px
- remove the close-x

 
4STcEzx1P6L.png
66.2 KB View Download

Comment 1 by bsep@chromium.org, Feb 17 2018

Owner: kylixrd@chromium.org
Status: Assigned (was: Untriaged)
The main bug is 684167. It looks like Allen explicitly made it 320 with a close button, so there must be some confusion. Maybe it can show up both as a bubble and as a centered modal?
It looks like I may have gotten a little over-zealous about which dialogs/bubbles are to be 320 and which ones aren't.

Should it still have the close (X)? Maybe that should be removed along with returning to use the 448 width?
Here's the view back to 448 and without the close (X).
RelaunchChromeDialogNoCloseX.png
5.9 KB View Download

Comment 4 by bettes@chromium.org, Feb 20 2018

448, without the close-x LGTM. Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec7a56f794d44c15255294d6d8e84f419573ba4

commit aec7a56f794d44c15255294d6d8e84f419573ba4
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Feb 20 22:20:00 2018

Restored relaunch chrome dialog width to 448. Removed the close (X) button.

Bug:  813253 
Change-Id: I11c496289a4e693b78595de76e1398f896643348
Reviewed-on: https://chromium-review.googlesource.com/927449
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537907}
[modify] https://crrev.com/aec7a56f794d44c15255294d6d8e84f419573ba4/chrome/browser/ui/views/update_recommended_message_box.cc
[modify] https://crrev.com/aec7a56f794d44c15255294d6d8e84f419573ba4/chrome/browser/ui/views/update_recommended_message_box.h

Status: Fixed (was: Assigned)

Sign in to add a comment