New issue
Advanced search Search tips

Issue 813236 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

"git cl owners" misses choosing OWNERS for some files

Project Member Reported by w...@chromium.org, Feb 16 2018

Issue description

While working on https://chromium-review.googlesource.com/c/chromium/src/+/914805 at one point I had to add a change to //net/dns/dns_util.h which means that I need a //net OWNERS review in addition to the reviewers I already had.

Presubmit spots the missing OWNER:

  wez@bitey:~/Projects/git-cr-fuchsia/src$ git cl presubmit
  Running presubmit commit checks ...

  ** Presubmit ERRORS **
  Missing LGTM from an OWNER for these files:
      net/dns/dns_util.h

  Presubmit checks took 32.2s to calculate.

  Was the presubmit check useful? If not, run "git cl presubmit -v"
  to figure out which PRESUBMIT.py was run, then run git blame
  on the file to figure out who to ask for help.


But the git cl owners tool does not:

  wez@bitey:~/Projects/git-cr-fuchsia/src$ git cl owners


  ** You selected these owners **

 

Comment 1 by w...@chromium.org, Feb 16 2018

Status: WontFix (was: Untriaged)
User error: This CL has a valid OWNER for //net, who just happens to be absent, but is of course still regarded by git cl owners as a valid OWNER reviewer. :P

Sign in to add a comment