WebXR: Do not provide poses to frames without focus |
|||||||||||||||
Issue descriptionThis is implemented for WebVR and needs to be implemented for WebXR.
,
Apr 11 2018
I'll add this for 67, since its something we want before developers start using WebXR.
,
Apr 12 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/666960b1e56dcb39c6c0d7fb3c596c99998b101b commit 666960b1e56dcb39c6c0d7fb3c596c99998b101b Author: Bill Orr <billorr@chromium.org> Date: Wed Apr 18 22:06:53 2018 WebXR: Do not provide poses to frames without focus This change plumbs through focus (both blink/frame and device) to XRSessions, so we only call raf callbacks when focused. BUG= 813230 Change-Id: I0aefdce989f6dd60b4cd0acf1a1477fdb2e845b8 Reviewed-on: https://chromium-review.googlesource.com/1011288 Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551842} [modify] https://crrev.com/666960b1e56dcb39c6c0d7fb3c596c99998b101b/third_party/blink/renderer/modules/xr/xr.cc [modify] https://crrev.com/666960b1e56dcb39c6c0d7fb3c596c99998b101b/third_party/blink/renderer/modules/xr/xr.h [modify] https://crrev.com/666960b1e56dcb39c6c0d7fb3c596c99998b101b/third_party/blink/renderer/modules/xr/xr_device.cc [modify] https://crrev.com/666960b1e56dcb39c6c0d7fb3c596c99998b101b/third_party/blink/renderer/modules/xr/xr_device.h [modify] https://crrev.com/666960b1e56dcb39c6c0d7fb3c596c99998b101b/third_party/blink/renderer/modules/xr/xr_frame_provider.cc [modify] https://crrev.com/666960b1e56dcb39c6c0d7fb3c596c99998b101b/third_party/blink/renderer/modules/xr/xr_frame_provider.h [modify] https://crrev.com/666960b1e56dcb39c6c0d7fb3c596c99998b101b/third_party/blink/renderer/modules/xr/xr_session.cc [modify] https://crrev.com/666960b1e56dcb39c6c0d7fb3c596c99998b101b/third_party/blink/renderer/modules/xr/xr_session.h
,
Apr 19 2018
Tested Canary with this fix, requesting merge.
,
Apr 19 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d commit 0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d Author: Bill Orr <billorr@chromium.org> Date: Fri Apr 20 05:46:32 2018 Revert "WebXR: Do not provide poses to frames without focus" This reverts commit 666960b1e56dcb39c6c0d7fb3c596c99998b101b. Reason for revert: Causing a test bug. Reverting while I investigate that bug ( crbug.com/835047 ). Original change's description: > WebXR: Do not provide poses to frames without focus > > This change plumbs through focus (both blink/frame and device) to XRSessions, so we > only call raf callbacks when focused. > > BUG= 813230 > > Change-Id: I0aefdce989f6dd60b4cd0acf1a1477fdb2e845b8 > Reviewed-on: https://chromium-review.googlesource.com/1011288 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Commit-Queue: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551842} TBR=ddorwin@chromium.org,bajones@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813230 Change-Id: I5c1e1dcb9aaef3fe46c085d6572cea81673e4789 Reviewed-on: https://chromium-review.googlesource.com/1020800 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552268} [modify] https://crrev.com/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d/third_party/blink/renderer/modules/xr/xr.cc [modify] https://crrev.com/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d/third_party/blink/renderer/modules/xr/xr.h [modify] https://crrev.com/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d/third_party/blink/renderer/modules/xr/xr_device.cc [modify] https://crrev.com/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d/third_party/blink/renderer/modules/xr/xr_device.h [modify] https://crrev.com/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d/third_party/blink/renderer/modules/xr/xr_frame_provider.cc [modify] https://crrev.com/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d/third_party/blink/renderer/modules/xr/xr_frame_provider.h [modify] https://crrev.com/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d/third_party/blink/renderer/modules/xr/xr_session.cc [modify] https://crrev.com/0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d/third_party/blink/renderer/modules/xr/xr_session.h
,
Apr 20 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2018
Looks like CL listed at #4 got reverted at #7. Doesn't look like it is ready to be merged to M67, correct?
,
Apr 20 2018
,
Apr 20 2018
correct - removed the merge request.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a commit bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a Author: Bill Orr <billorr@chromium.org> Date: Wed Apr 25 08:07:30 2018 Reland "WebXR: Do not provide poses to frames without focus" This reverts commit 0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d. Reason for revert: Found the issue with the broken tests. Original change's description: > Revert "WebXR: Do not provide poses to frames without focus" > > This reverts commit 666960b1e56dcb39c6c0d7fb3c596c99998b101b. > > Reason for revert: Causing a test bug. Reverting while I investigate that bug ( crbug.com/835047 ). > > > > Original change's description: > > WebXR: Do not provide poses to frames without focus > > > > This change plumbs through focus (both blink/frame and device) to XRSessions, so we > > only call raf callbacks when focused. > > > > BUG= 813230 > > > > Change-Id: I0aefdce989f6dd60b4cd0acf1a1477fdb2e845b8 > > Reviewed-on: https://chromium-review.googlesource.com/1011288 > > Reviewed-by: Brandon Jones <bajones@chromium.org> > > Reviewed-by: David Dorwin <ddorwin@chromium.org> > > Commit-Queue: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#551842} > > TBR=ddorwin@chromium.org,bajones@chromium.org,billorr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 813230 > Change-Id: I5c1e1dcb9aaef3fe46c085d6572cea81673e4789 > Reviewed-on: https://chromium-review.googlesource.com/1020800 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552268} Change-Id: I065ccb0972a33e553aa73140bd649a939a6547f8 Bug: 813230 Reviewed-on: https://chromium-review.googlesource.com/1022560 Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553481} [modify] https://crrev.com/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a/third_party/blink/renderer/modules/xr/xr.cc [modify] https://crrev.com/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a/third_party/blink/renderer/modules/xr/xr.h [modify] https://crrev.com/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a/third_party/blink/renderer/modules/xr/xr_device.cc [modify] https://crrev.com/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a/third_party/blink/renderer/modules/xr/xr_device.h [modify] https://crrev.com/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a/third_party/blink/renderer/modules/xr/xr_frame_provider.cc [modify] https://crrev.com/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a/third_party/blink/renderer/modules/xr/xr_frame_provider.h [modify] https://crrev.com/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a/third_party/blink/renderer/modules/xr/xr_session.cc [modify] https://crrev.com/bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a/third_party/blink/renderer/modules/xr/xr_session.h
,
Apr 25 2018
Pls request a merge to M67 when CL listed at #12 is ready to merge if needed. Thank you.
,
Apr 27 2018
,
Apr 27 2018
Added the wrong label for requesting merge.
,
Apr 27 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 27 2018
How is the change listed at #12 looking in canary? Is it safe to merge to M67 now?
,
Apr 27 2018
I've verified that it is working correctly on the latest Canary. The test failures previously seen in #4 are no longer present.
,
Apr 27 2018
Approving merge to M67 branch 3396 based on comment #18. Please merge ASAP. Thank you.
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56c5f35f6ed2ab62270c3f9352bff06be111f18b commit 56c5f35f6ed2ab62270c3f9352bff06be111f18b Author: Bill Orr <billorr@chromium.org> Date: Fri Apr 27 19:52:23 2018 Reland "WebXR: Do not provide poses to frames without focus" This reverts commit 0ad90c2fd1974ec017e0804a8b61bf5e1d75f15d. Reason for revert: Found the issue with the broken tests. Original change's description: > Revert "WebXR: Do not provide poses to frames without focus" > > This reverts commit 666960b1e56dcb39c6c0d7fb3c596c99998b101b. > > Reason for revert: Causing a test bug. Reverting while I investigate that bug ( crbug.com/835047 ). > > > > Original change's description: > > WebXR: Do not provide poses to frames without focus > > > > This change plumbs through focus (both blink/frame and device) to XRSessions, so we > > only call raf callbacks when focused. > > > > BUG= 813230 > > > > Change-Id: I0aefdce989f6dd60b4cd0acf1a1477fdb2e845b8 > > Reviewed-on: https://chromium-review.googlesource.com/1011288 > > Reviewed-by: Brandon Jones <bajones@chromium.org> > > Reviewed-by: David Dorwin <ddorwin@chromium.org> > > Commit-Queue: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#551842} > > TBR=ddorwin@chromium.org,bajones@chromium.org,billorr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 813230 > Change-Id: I5c1e1dcb9aaef3fe46c085d6572cea81673e4789 > Reviewed-on: https://chromium-review.googlesource.com/1020800 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552268} Change-Id: I065ccb0972a33e553aa73140bd649a939a6547f8 Bug: 813230 Reviewed-on: https://chromium-review.googlesource.com/1022560 Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#553481}(cherry picked from commit bc7ad9d19352f9f6d7cb387f2c50a909ca92b44a) Reviewed-on: https://chromium-review.googlesource.com/1033398 Cr-Commit-Position: refs/branch-heads/3396@{#357} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/56c5f35f6ed2ab62270c3f9352bff06be111f18b/third_party/blink/renderer/modules/xr/xr.cc [modify] https://crrev.com/56c5f35f6ed2ab62270c3f9352bff06be111f18b/third_party/blink/renderer/modules/xr/xr.h [modify] https://crrev.com/56c5f35f6ed2ab62270c3f9352bff06be111f18b/third_party/blink/renderer/modules/xr/xr_device.cc [modify] https://crrev.com/56c5f35f6ed2ab62270c3f9352bff06be111f18b/third_party/blink/renderer/modules/xr/xr_device.h [modify] https://crrev.com/56c5f35f6ed2ab62270c3f9352bff06be111f18b/third_party/blink/renderer/modules/xr/xr_frame_provider.cc [modify] https://crrev.com/56c5f35f6ed2ab62270c3f9352bff06be111f18b/third_party/blink/renderer/modules/xr/xr_frame_provider.h [modify] https://crrev.com/56c5f35f6ed2ab62270c3f9352bff06be111f18b/third_party/blink/renderer/modules/xr/xr_session.cc [modify] https://crrev.com/56c5f35f6ed2ab62270c3f9352bff06be111f18b/third_party/blink/renderer/modules/xr/xr_session.h
,
May 4 2018
,
May 8 2018
,
Jul 4
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by sko...@chromium.org
, Feb 27 2018