New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813227 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Copy mobmonitor code into platform moblab

Project Member Reported by mattmallett@chromium.org, Feb 16 2018

Issue description

Copy the code into /platform/moblab and update any references, handle any dependencies so that mobmonitor no longer depends on chromite. This will make mobmonitor more independent and easier to develop going forward.

 
Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/873e6bf85e996370ee1225a4ab172fa17c146887

commit 873e6bf85e996370ee1225a4ab172fa17c146887
Author: Matt Mallett <mattmallett@chromium.org>
Date: Sat Feb 24 05:06:38 2018

[moblab] Copying mobmonitor code into platform/moblab

Copying code out of chromite, project-moblab into a central
place to make development and maintenance of mobmonitor easier
going forward. Removing all dependencies to chromite.

Updating the ebuild to pull source from the right place, put it
in a moblab specific directory.

BUG= chromium:813227 
TEST=Built image and tested on local moblab device
CQ-DEPEND=CL:933098

Change-Id: I1f5e09bedb064f209253a86d1df212d16943b23a
Reviewed-on: https://chromium-review.googlesource.com/933377
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/873e6bf85e996370ee1225a4ab172fa17c146887/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-9999.ebuild
[add] https://crrev.com/873e6bf85e996370ee1225a4ab172fa17c146887/project-moblab/sys-apps/mobmonitor/mobmonitor-9999.ebuild
[modify] https://crrev.com/873e6bf85e996370ee1225a4ab172fa17c146887/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/mobmonitor-init.conf

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/moblab/+/96653b8d75c85d804558682a91da8ec15e66be8b

commit 96653b8d75c85d804558682a91da8ec15e66be8b
Author: Matt Mallett <mattmallett@chromium.org>
Date: Sat Feb 24 05:06:37 2018

[moblab] Copying mobmonitor code into platform/moblab

Copying code out of chromite, project-moblab into a central
place to make development and maintenance of mobmonitor easier
going forward. Removing all dependencies to chromite.

As a part of the move, re-implementing a few chromite util
functions and removing mobmoncli, rpc: they are not needed
for our use case.

BUG= chromium:813227 
TEST=Rewrote unit tests to be chromite independent and continue
to provide test coverage. Updated ebuild files and created a
build to do manual testing on local device.

Change-Id: Iefc0016c5874188d901f4e6591c10575fbe07a8b
Reviewed-on: https://chromium-review.googlesource.com/933098
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/mobmonitor_unittest.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfile/__init__.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/templates/healthstatuscontainer.html
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/dut_check.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/__init__.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/templates/actionrepairdialog.html
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/mobmonitor.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/autotest_common.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/js/main.js
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/system/systeminfo.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfile/manager.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/network_check.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/__init__.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/common.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/heartbeat_check_unittest.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/disk_check.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/moblab_actions.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/css/style.css
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/util/__init__.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/system/__init__.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/js/healthdisplay.js
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/boto_check.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/heartbeat_check.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/util/collect_logs.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/README
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/servo_check.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/system/systeminfo_unittest.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/js/actionrepairdialog.js
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfile/manager_unittest.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/devserver/__init__.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/js/rpc.js
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/templates/index.html
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/js/template.js
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/moblab/upstart_services_running_check.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/util/osutils.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/static/js/util.js
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/checkfiles/devserver/gs_check.py
[add] https://crrev.com/96653b8d75c85d804558682a91da8ec15e66be8b/src/mobmonitor/util/osutils_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment