New issue
Advanced search Search tips

Issue 813226 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Implement CreateProxyConfigService and CreateProxyService in for Cronet native library

Project Member Reported by w...@chromium.org, Feb 16 2018

Issue description

At present these are stubbed-out with NOTIMPLEMENTED(), and return nullptr.

They should be properly implemented for the platforms that will use the "native" Cronet library.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91c173412d07fe1919fba05c9b189cfc0d82b117

commit 91c173412d07fe1919fba05c9b189cfc0d82b117
Author: Misha Efimov <mef@chromium.org>
Date: Mon Apr 02 21:31:07 2018

[Cronet] Make cronet_tests run in Linux Release config.

- Add libcronet.so to cronet_tests rpath.
- Use trivial ProxyResolutionService to avoid crashes.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3a114b098a4d78e4087be948dfd3ce303d6df737
Bug:  813226 
Reviewed-on: https://chromium-review.googlesource.com/987521
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547521}
[modify] https://crrev.com/91c173412d07fe1919fba05c9b189cfc0d82b117/components/cronet/BUILD.gn
[modify] https://crrev.com/91c173412d07fe1919fba05c9b189cfc0d82b117/components/cronet/cronet_global_state_stubs.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment