Fetching a revoked blob URL can flakily succeed |
||||
Issue descriptionFetching a blob URL right after revoking the URL should fail, but a workaround introduced to fix a regression in downloading blob URLs (https://chromium.googlesource.com/chromium/src/+/a3dd29b25f01eef7bf726aef971d554ed153a4f0) unfortunately causes race conditions where sometimes such a fetch might succeed anyway. This is causing a bunch of (layout) test flakiness. Ultimately mojo blob URLs in combination with network service will fix this, but until then I'm not sure if there is much point in trying to figure out another workaround on top of the existing workarounds, so we should probably just mark all the relevant tests as flaky.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b925d250f22b48a34e5bd88ac5905dfc1994090 commit 2b925d250f22b48a34e5bd88ac5905dfc1994090 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Thu Apr 05 19:41:35 2018 Revert "Bounce Blob URL revoking through the UI thread to give navigation a chance." This reverts part of commit 8a5561649b9567c394ef1ff1619745b02ed7759d. The original change that caused the problems this was working around was reverted, so also revert the workaround to fix the issues the workaround caused. Bug: 813224 Change-Id: Ic0659a38b6ddcf828c2476d6b9fa4e266c364b57 Reviewed-on: https://chromium-review.googlesource.com/998436 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#548527} [modify] https://crrev.com/2b925d250f22b48a34e5bd88ac5905dfc1994090/content/browser/blob_storage/blob_dispatcher_host.cc
,
Apr 5 2018
,
Jun 15 2018
,
Jun 15 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mek@chromium.org
, Feb 16 2018