New issue
Advanced search Search tips

Issue 813217 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Use EnableIf in spellcheck.mojom

Project Member Reported by xiaoche...@chromium.org, Feb 16 2018 
We have a lot of platform-dependent APIs in components/spellcheck/common/spellcheck.mojom.

Currently, the are commented with enabled platforms in spellcheck.mojom, and have dummy implementations on other platforms.

We should re-specify these APIs with the mojo EnableIf attribute, and remove the dummy implementations.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73091994177b60aa02097405ae3cf510774e511f

commit 73091994177b60aa02097405ae3cf510774e511f
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Feb 20 21:04:48 2018

Use EnableIf in spellcheck mojom

The SpellCheckHost mojom has some platform-dependent APIs.

This patch uses the EnableIf mojo attribute so that we don't need
to leave dummy API implementations on unsupported platforms.

Bug:  813217 
Change-Id: I407ebc6687c404b1583ceeac346a29cb775847ee
Reviewed-on: https://chromium-review.googlesource.com/905579
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537879}
[modify] https://crrev.com/73091994177b60aa02097405ae3cf510774e511f/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/73091994177b60aa02097405ae3cf510774e511f/components/spellcheck/browser/spell_check_host_impl.cc
[modify] https://crrev.com/73091994177b60aa02097405ae3cf510774e511f/components/spellcheck/browser/spell_check_host_impl.h
[modify] https://crrev.com/73091994177b60aa02097405ae3cf510774e511f/components/spellcheck/common/BUILD.gn
[modify] https://crrev.com/73091994177b60aa02097405ae3cf510774e511f/components/spellcheck/common/spellcheck.mojom
[modify] https://crrev.com/73091994177b60aa02097405ae3cf510774e511f/components/spellcheck/renderer/spellcheck_provider_test.cc
[modify] https://crrev.com/73091994177b60aa02097405ae3cf510774e511f/components/spellcheck/renderer/spellcheck_provider_test.h

Comment 2 by xiaoche...@chromium.org, Feb 20 2018

Status: Fixed (was: Available)
►

Sign in to add a comment